From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF098C00A89 for ; Mon, 2 Nov 2020 17:01:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A83D20786 for ; Mon, 2 Nov 2020 17:01:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CVojIyxC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A83D20786 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=paulk.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=i7hHG7c0yut4noHqpxBNOHYiC/NAo8p0kaKQcBLwA0o=; b=CVojIyxCYeGzCdcABUQR5ouPa UIqq+1UgRrXzthLFXVJV1L1eWxODfbST3++5b2wf83AXXc4SFEOo4JqQqVW1UdhXkac0MJm9cvLPd PGBMdQg0Qrgl2p4KoxKUuBvstj4dS25eNOZ3EJ2k8KkABdVWq1W57ZlNswvjN39NYBXK/le2dVRFf Pa9t05ssbptAvIb9umISNDxzyrslmajODMQWWx1andayc+vLkxGjgpORCzeSG5IJ2Qumd1pdhp8/n 6GAHZj+IjOrXT5qfVg5yqL6W5HBLRkz4E2+rS0ABVivg/mBazpwIClfbpVsmtT9s3a52+iCx0Oatp aUIx3DmHA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZdBG-0001Qw-7q; Mon, 02 Nov 2020 16:59:42 +0000 Received: from leonov.paulk.fr ([185.233.101.22]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZdBC-0001Pi-Jk for linux-arm-kernel@lists.infradead.org; Mon, 02 Nov 2020 16:59:40 +0000 Received: from gagarine.paulk.fr (gagarine [192.168.1.127]) by leonov.paulk.fr (Postfix) with ESMTPS id E1A51C0139 for ; Mon, 2 Nov 2020 17:59:34 +0100 (CET) Received: by gagarine.paulk.fr (Postfix, from userid 114) id 51087C1DD0; Mon, 2 Nov 2020 17:59:34 +0100 (CET) Received: from collins (unknown [192.168.1.1]) by gagarine.paulk.fr (Postfix) with ESMTPSA id A4BB9C1DCD; Mon, 2 Nov 2020 17:59:22 +0100 (CET) Date: Mon, 2 Nov 2020 17:59:22 +0100 From: Paul Kocialkowski To: Maxime Ripard Subject: Re: [PATCH 6/9] ARM: dts: sun8i-v3s: Add the V3s NMI IRQ controller Message-ID: <20201102165922.GB2037@collins> References: <20201031182137.1879521-1-contact@paulk.fr> <20201031182137.1879521-7-contact@paulk.fr> <20201102101211.wtkmgfm2rcm5gdyp@gilmour.lan> <20201102102522.GB11809@aptenodytes> <20201102134418.vn7i3e4gpwomxcnj@gilmour.lan> MIME-Version: 1.0 In-Reply-To: <20201102134418.vn7i3e4gpwomxcnj@gilmour.lan> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_115939_035588_47209D23 X-CRM114-Status: GOOD ( 23.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Matteo Scordino , linux-kernel@vger.kernel.org, Chen-Yu Tsai , Rob Herring , linux-arm-kernel@lists.infradead.org, Icenowy Zheng Content-Type: multipart/mixed; boundary="===============1049264649794595691==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1049264649794595691== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="L6iaP+gRLNZHKoI4" Content-Disposition: inline --L6iaP+gRLNZHKoI4 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon 02 Nov 20, 14:44, Maxime Ripard wrote: > On Mon, Nov 02, 2020 at 11:25:22AM +0100, Paul Kocialkowski wrote: > > Hi, > >=20 > > On Mon 02 Nov 20, 11:12, Maxime Ripard wrote: > > > On Sat, Oct 31, 2020 at 07:21:34PM +0100, Paul Kocialkowski wrote: > > > > The V3s/V3 has a NMI interrupt controller, mainly used for the AXP2= 09. > > > > Its address follows the sytsem controller block, which was previous= ly > > > > incorrectly described as spanning over 0x1000 address bytes. > > >=20 > > > Is it after, or right in the middle of it? > >=20 > > That's up for interpretation actually: > > - The V3 datasheet mentions that System Control is 0x01C00000 --- 0x01C= 00FFF; > > - In practice, sunxi_sram.c uses a regmap with max_reg set to 0x30 for = the > > V3s/H3 so this gives us some room. > >=20 > > Looking at other SoCs with the same setup (take sun8i-r40 for instance), > > system-control is limited to 0x30 and the NMI controller follows it. > > In the case of R40, the SRAM controlled is also said to be 4K-long in t= he > > Allwinner docs. > >=20 > > So all in all, this leads me to believe that the system-controller inst= ance > > stops well before 0x1c000d0 on the V3s as well. Otherwise, we should al= so > > make the R40 consistent. >=20 > That's a bit unfortunate, but yeah, I guess we want to remain consistent = here. Honestly I think the Allwinner docs are plain wrong on this one. IIRC they used to describe the NMI as a separate controller in the memory map. I think they just overlook it now and copy/paste 4K size for each controller regardless of the actual hardware, so I'm not very worried. Cheers, Pauls --=20 Developer of free digital technology and hardware support. Website: https://www.paulk.fr/ Coding blog: https://code.paulk.fr/ Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/ --L6iaP+gRLNZHKoI4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEAbcMXZQMtj1fphLChP3B6o/ulQwFAl+gOuoACgkQhP3B6o/u lQwWBA//b32OKC11RTCgxme9fX39MvwYZCzJcPyISRTBGEEnoxuDxrhdtbywcbwq V6WV0alqd6C/VaflLa8rnUBeVJFBmVhqi1C3+A4DLu6sRE8siW2yjBU9SbFyrKI7 oGVUD3RL7dR+Zks247PU+HwMzqr93K2cx2bDfyAE/4xf2vt6TpPlHrcYkFKKrrK0 pMf3nsf+YIwBC1VY5RJlhw4WxAkzVnmJ4Rr7CDsGnaWHJ5FU8MLVM4mbVUXwcBsh qlH3iX0ezx8TBplXL+pJeSz/XwpUULuWTb4vmH59f2vF0dEqOSUe6O3hyNtNvn67 WUtfp2qeM6c2U0v6gze8q1D1aewKDLzJnUAiL0YflVXqn1g94Gz3Wm4yZmHOpOi7 0r3jlDK6fuzaaGztURiBYbWDAC1m5BGbeWPlvLc0MaEWk5F3sCHqdg7q80tgu/iN ILsXYlwei8Oobs/U9U3dlaWZq8CJ973IRVDfzRypD4QSn7E+gvXBEdT5DYXvrkZx 4FVPUoejI/mj2hTvzna6GjlnM3AwZYP6rNd9uTCwaI6dlPqPb20oeztY4b94LnpY WdPfy2ErQdcZBmZC3tU18Ll8qFw/y6Q4Bf6KugOSPDg9OJzyX37WuibLA6aszgfi kmK/UX3oHAN/NUqZga3QXAqjCmx5ladqnTRf/ZjBCgmNmCYfO/U= =ByNw -----END PGP SIGNATURE----- --L6iaP+gRLNZHKoI4-- --===============1049264649794595691== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1049264649794595691==--