From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DF5AC00A89 for ; Mon, 2 Nov 2020 17:25:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BACED21D91 for ; Mon, 2 Nov 2020 17:25:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="x7brM75Q"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mXsQpv/A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BACED21D91 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dqgVB7DIRFYrbIf47vddHIxmuune91oWmS8Fpp4drnk=; b=x7brM75QANZftx+1VRTRC1tzz UQGaN8ov78TfElpHG4YtmF89PqCaQtECViXQqmoegEvS0AirvHcyhLHtngYsalzZeKEnNaXWvpbTa 7w3zt/S+V6bRVXMvu4/QSmORZh8iz4LoXF6ZzZQoN3MiCZRec1jakS6gtjstLa5xfRF1/y+BZ2Kii K7l8YQdK7HwGqem0PszKtncmJqaF9jja9iAlTs7aUye8ZR32lMiQs5eKdAq2Eoc9oqVUvBF1hc9ob cSoSHFfzMEVbTd3UiMnS4LLKL6hxTZUDj09VtW1kAk+DaCgrqBDqp/6aM9HFWCXSSiuh9Vh0e26Va QjLoVmKEA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZdYS-00082N-C6; Mon, 02 Nov 2020 17:23:40 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZdYP-000807-Et for linux-arm-kernel@lists.infradead.org; Mon, 02 Nov 2020 17:23:38 +0000 Received: by mail-pl1-x641.google.com with SMTP id t6so7137272plq.11 for ; Mon, 02 Nov 2020 09:23:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ATZTaWKB7FLAcEtv7JwaiUAx+9bWAX/DQcn3u1wg8I8=; b=mXsQpv/AF/HFFU1B5YrdH/Fh702XYsDb6sDBm8SI+HXlcUIhRuahhb4vQwJF7prFqH XRBXcEPlFrYrxTvaWP7mzHDnTzxOVtplmMopT+QJbEYDjXwZiPi2L/SbdYElDs78QriR BnezgALmcqxzV0opn59fIYU0TuTinuRDTjE7q7xzpIJsVyi7HVMOxFMcnkJ+VqOhTv+x QLs8qpd9WkQa6lodiVaoNaO/qe59XNT9XQ7X3saHywnBzes0V9WiyhLrSViTx/LuC9KE ZKfUKoS8830r7MqJj4EUGxVZrJuYsaLXqwych3K14iBDdEK8Et1zLpdk9jQ53g/ea4FK VMtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ATZTaWKB7FLAcEtv7JwaiUAx+9bWAX/DQcn3u1wg8I8=; b=qcDTz3hZ8Z6aUdsoQtxW12zBh7zbEYRD+rV7XxVfDOBahIU2746SuqulMvNnXrW8WH uS+aWsbm27kWDZLjefzEnp5yiKKnVanlKK2qMN8AYOCCRHMJbn5oM3MnfcnduEGScniQ FyNEt3aFleNlYtC7RBQpGEa88OrEqiLkIwQa1L4TfJxa4RQL3RD138dDjLno4z/vx3tg OyFF+uINAi0KQ84oy3bgEW0i3bgaBo0cddNwTBkCMv014RRpCsEGbobDP8BHvhTynEyC VJkiYkoHF3IBDp2qgUOCNy5z39+blcpGtF85icPS4tUZ8bKODkkD5ZsooTFL7/u9sS0N Fmbg== X-Gm-Message-State: AOAM531Xqw9AMjgGsSZFVbEylv0lkdTHr31V7hoA7cjrQYtXrYwI5+U8 nh2cmoD3hF3G+SP5W0TsoU7TY2S7WUBrLw== X-Google-Smtp-Source: ABdhPJyjDCbGH+Kdv6bAKAIDQ7KElZ+TVN8Kdmk5KprdCDWo2WIIlqle/ccjedkmKtbr39jIL2Gskg== X-Received: by 2002:a17:902:8c8a:b029:d6:d1e7:e78e with SMTP id t10-20020a1709028c8ab02900d6d1e7e78emr4187252plo.39.1604337812915; Mon, 02 Nov 2020 09:23:32 -0800 (PST) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id m23sm13407953pgk.84.2020.11.02.09.23.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 09:23:32 -0800 (PST) Date: Mon, 2 Nov 2020 10:23:30 -0700 From: Mathieu Poirier To: Qi Liu Subject: Re: [PATCH] coresight: funnel: Remove unnecessary .owner of static funnel driver Message-ID: <20201102172330.GB2749502@xps15> References: <1604139150-18659-1-git-send-email-liuqi115@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1604139150-18659-1-git-send-email-liuqi115@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_122337_529791_31F888C0 X-CRM114-Status: GOOD ( 19.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Al.Grant@arm.com, suzuki.poulose@arm.com, linuxarm@huawei.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Liu, On Sat, Oct 31, 2020 at 06:12:30PM +0800, Qi Liu wrote: > As driver.owner has been set in platform_driver_register(), it is > unnecessary to set it in static funnel driver, so remove it from > struct static_funnel_driver. > > Signed-off-by: Qi Liu > --- > drivers/hwtracing/coresight/coresight-funnel.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c > index af40814..07bc203 100644 > --- a/drivers/hwtracing/coresight/coresight-funnel.c > +++ b/drivers/hwtracing/coresight/coresight-funnel.c > @@ -356,7 +356,6 @@ static struct platform_driver static_funnel_driver = { > .remove = static_funnel_remove, > .driver = { > .name = "coresight-static-funnel", > - .owner = THIS_MODULE, I received two identical patches (with a different title) from you. Since there was no explanation I will discard the first one and work with this one. You are correct, platform_driver_register() does take care of THIS_MODULE. Please send another revision where you will do three things: 1) CC the coresight mailing list, as instructed by get_maintainer.pl 1) Also fix the replicator driver. 2) Add a comment that clearly mentions THIS_MODULE doesn't need to be set: .name = "coresight-static-funnel", /* THIS_MODULE is taken care of by platform_driver_register() */ .of_match_table = static_funnel_match, .acpi_match_table = ACPI_PTR(static_funnel_ids), .pm = &funnel_dev_pm_ops, Thanks, Mathieu > -- > 2.8.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel