From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F071CC00A89 for ; Mon, 2 Nov 2020 19:41:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A8162225E for ; Mon, 2 Nov 2020 19:41:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="k0Yz9BgE"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="cSRBOUtk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A8162225E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/gG6EZ6qowTdyI6Kq8TsyImckWs1bPXpTE+Av8nsfDw=; b=k0Yz9BgEulOBRhc5e2h9fYx9E Xn5L+2XsxMfDpyd2PVvztBUp5s1/TDLEc9fZKPOcGyaHBEABcsGx2ppMXhyDmnglS5jVTt5b4KBX0 pyMaxF85O6vtjGNbnwfgGSBdEdWSI/vqYDUPn4rmOTV/6stpsmih4Xt0Xu/lHbReu8XBA8pSo8nvo +K9eS6WKBCRsysUfRdobPyqsSE4PXkRB1Ek1Aij43KUBNwSI6PfC0Udy+77hyrDSfnZWrv/NxliAl BZCe2pSX7OmXm/Np2ucZRxeieey0Sbgb1nSQ1WTK/GFFOVJobuSeQZaUBlY9CMdKIAN0/Dltwei+9 ztzK8jTIw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZfgV-0003IZ-Dg; Mon, 02 Nov 2020 19:40:07 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZfgQ-0003G2-2V; Mon, 02 Nov 2020 19:40:03 +0000 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2F8CA22268; Mon, 2 Nov 2020 19:39:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604346000; bh=IWunD2Cz2xcaCwPBQNJRvEa6f66eGVu+ZtfdVqx9Ivk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cSRBOUtkHP+xHtFE878bi0AZQGfo0GAygXV2x1BUU+joBUGj/03cbHOYhxbsOxBoD +DrMG+Qro8hQLQ4rlVnq0Xf+SR9GmrAw7nPRFzY3UPRWJWTFIvABJVAz2xF+YU20hr SH6n/VG6nEZIsoqBbXt3mmxNdFr+TZdllKa7DAGY= Date: Mon, 2 Nov 2020 20:40:55 +0100 From: Greg KH To: "siddhant gupta(siddhant1223)" Subject: Re: [PATCH] staging: mt7621-dma: Prefer Using BIT Macro instead of left shifting on 1. Message-ID: <20201102194055.GA2429929@kroah.com> References: <20201102193402.GA14965@Sleakybeast> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201102193402.GA14965@Sleakybeast> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_144002_317924_DC3CB577 X-CRM114-Status: GOOD ( 15.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, matthias.bgg@gmail.com, mamatashukla555@gmail.com, himadrispandya@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 03, 2020 at 01:04:02AM +0530, siddhant gupta(siddhant1223) wrote: > > Replace left shifting on 1 by a BIT macro to fix checkpatch warning. > > Signed-off-by: Siddhant Gupta > > --- > drivers/staging/mt7621-dma/mtk-hsdma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c > index 354536783e1c..a9e1a1b14035 100644 > --- a/drivers/staging/mt7621-dma/mtk-hsdma.c > +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c > @@ -72,7 +72,7 @@ > #define HSDMA_GLO_TX_DMA BIT(0) > > #define HSDMA_BT_SIZE_16BYTES (0 << HSDMA_GLO_BT_SHIFT) > -#define HSDMA_BT_SIZE_32BYTES (1 << HSDMA_GLO_BT_SHIFT) > +#define HSDMA_BT_SIZE_32BYTES BIT(HSDMA_GLO_BT_SHIFT) > #define HSDMA_BT_SIZE_64BYTES (2 << HSDMA_GLO_BT_SHIFT) > #define HSDMA_BT_SIZE_128BYTES (3 << HSDMA_GLO_BT_SHIFT) In looking at the code, does this change really make sense? (hint, I don't think so...) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel