From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B091C00A89 for ; Mon, 2 Nov 2020 21:48:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A7E36206F9 for ; Mon, 2 Nov 2020 21:48:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lsZuqOui"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PmBlyYUx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A7E36206F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eiUve19VkNo7QP4nsPXRzk0ZXqQUaBmlpiFOjkGqOq4=; b=lsZuqOui0v5ooBx6IakdVriIJ 8KE5+ZpvY2SQLy7BKJVbuYXjcx0TJxsyWRW4btL3OcD4IHzaZGWLG/iafA/dmjzTPDAeCCqqCvBVb 4DKoUj0OYz+AynIMb3G3GxL/MdCNQcZL9gOwNt/1LLCZW2F/ZnZOT0L19LUml7JJzX8tE9oy/tSb8 dI4oyYAdRVm8XdPemwkXxSt4kEgsvfLRRrNZ4A4AtBLANI6wAmlZcbfu1ewR1JKWrxQWpiuhU+ILt CYQYSiD52ahvCmHZcGLFAObdjJXEtiWgFIhIrVmfcnFZWMwlivFpc6hEQMi5wKn8caxJSbAzICwA5 +F0Z52YUg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZhf1-0006Ov-0T; Mon, 02 Nov 2020 21:46:43 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZhew-0006Ns-9b for linux-arm-kernel@lists.infradead.org; Mon, 02 Nov 2020 21:46:39 +0000 Received: by mail-pf1-x441.google.com with SMTP id e7so12292304pfn.12 for ; Mon, 02 Nov 2020 13:46:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NuAK5iU+OB5uwgmefiNZ92vlEQCJHA3+TVIKzsNC8/Q=; b=PmBlyYUxet0pQz4Kq7fTrLy5nPvS/FiNVis6+GO0WuqHhybCtrLbmb89ZojZH+caQT BYwdEgUSIAnFnVx/BdCKv2E9nEtFAYMGfol+eXsTlcBAJjm4GYaq8lY8VakgxbRSzwfL X2KFvZAAu+5G8djht/XSlC5F12rPHBnwkUHEMVjjv47S7Y6w6WgPBSmxzNri3nQPrk4p 0yMHBC8j/+mmI5Hd0wCTaxk8MWGzIJuTOQKtc1jxySg+n3YG12HM4jMCi8fa4bp+cCDG 43VLHSE5VSo5STKVUza8IG7D6ndFh44r82gSW2XBaT9OTbvLZoMSYESEHju8kMtIkWvU oDGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NuAK5iU+OB5uwgmefiNZ92vlEQCJHA3+TVIKzsNC8/Q=; b=pM05cNOk7L1uKE/ilKsNZlDp1xIxbM3PJLCbqEGM47PvenNInIrIrYz9PgMwQh4NOW gnKO5Orf38beP93ha8mYirLC/J0cT3Pu9liVjdtJB7CJn8vyMt7vYBAleumd9ezukQkC 2OB05yo4Zhpo4Q3DQBAjlFG2A+Ep3sVdvDaByux4j9bNC1d7zHlVW5WYO/pXJqrATGgW WhiUXEBVC/RqJxCeAcTX7RrXH+bE6qiYuwg7XRcQkQPTBJhQWJ/Eb6p3e/XF+LYBMj2R HGtru3xE7ZjV61WS7HaNAVAHcK7S05j3DbIr47orlkSvPGYvpRVCNxR8JXH6OWVBzlcp q5Dg== X-Gm-Message-State: AOAM532DPzEYNyGFQjPNdjX6GHL7cerAvyQeMLoECiHjPgrhzFGDf7Kh sp+AgJ41QVoYrPXd7J5tmCwFaQ== X-Google-Smtp-Source: ABdhPJy2WBxIE36mCDneHzdb8Jqk4jEXiLdHF0aRYDJZcW7w78FEN7ogF1O0a7WLCCGS5s2YPRUdcw== X-Received: by 2002:a62:25c7:0:b029:156:72a3:b0c0 with SMTP id l190-20020a6225c70000b029015672a3b0c0mr23140079pfl.59.1604353596231; Mon, 02 Nov 2020 13:46:36 -0800 (PST) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id ca5sm453566pjb.27.2020.11.02.13.46.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 13:46:35 -0800 (PST) Date: Mon, 2 Nov 2020 14:46:33 -0700 From: Mathieu Poirier To: Suzuki K Poulose Subject: Re: [PATCH v3 06/26] coresight: etm4x: Handle access to TRCSSPCICRn Message-ID: <20201102214633.GD2749502@xps15> References: <20201028220945.3826358-1-suzuki.poulose@arm.com> <20201028220945.3826358-8-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201028220945.3826358-8-suzuki.poulose@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201102_164638_698120_C52288C9 X-CRM114-Status: GOOD ( 19.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: coresight@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Suzuki, On Wed, Oct 28, 2020 at 10:09:25PM +0000, Suzuki K Poulose wrote: > TRCSSPCICR is present only if all of the following are true: > TRCIDR4.NUMSSCC > n. > TRCIDR4.NUMPC > 0b0000 . > TRCSSCSR.PC == 0b1 > > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-etm4x-core.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c > index d78a37b6592c..0310eac9dc16 100644 > --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c > +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c > @@ -175,8 +175,9 @@ static int etm4_enable_hw(struct etmv4_drvdata *drvdata) > drvdata->base + TRCSSCCRn(i)); > writel_relaxed(config->ss_status[i], > drvdata->base + TRCSSCSRn(i)); > - writel_relaxed(config->ss_pe_cmp[i], > - drvdata->base + TRCSSPCICRn(i)); > + if (drvdata->nr_pe) Aren't you missing to check the value of the PC bit in TRCSSCSRn? /* * TRCSSCSRn:PC, bit[3]: Indidate support for single-shot PE * comparator input. */ if (drvdata->nr_pe && (config->ss_status[i] & BIT(3))) I have picked up patches 1 to 5 and added a "Cc:stable" to paches 2, 4 and 5. More comments to come tomorrow. Thanks, Mathieu > + writel_relaxed(config->ss_pe_cmp[i], > + drvdata->base + TRCSSPCICRn(i)); > } > for (i = 0; i < drvdata->nr_addr_cmp; i++) { > writeq_relaxed(config->addr_val[i], > @@ -1228,7 +1229,8 @@ static int etm4_cpu_save(struct etmv4_drvdata *drvdata) > for (i = 0; i < drvdata->nr_ss_cmp; i++) { > state->trcssccr[i] = readl(drvdata->base + TRCSSCCRn(i)); > state->trcsscsr[i] = readl(drvdata->base + TRCSSCSRn(i)); > - state->trcsspcicr[i] = readl(drvdata->base + TRCSSPCICRn(i)); > + if (drvdata->nr_pe) > + state->trcsspcicr[i] = readl(drvdata->base + TRCSSPCICRn(i)); > } > > for (i = 0; i < drvdata->nr_addr_cmp * 2; i++) { > @@ -1344,8 +1346,9 @@ static void etm4_cpu_restore(struct etmv4_drvdata *drvdata) > drvdata->base + TRCSSCCRn(i)); > writel_relaxed(state->trcsscsr[i], > drvdata->base + TRCSSCSRn(i)); > - writel_relaxed(state->trcsspcicr[i], > - drvdata->base + TRCSSPCICRn(i)); > + if (drvdata->nr_pe) > + writel_relaxed(state->trcsspcicr[i], > + drvdata->base + TRCSSPCICRn(i)); > } > > for (i = 0; i < drvdata->nr_addr_cmp * 2; i++) { > -- > 2.24.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel