From: Lee Jones <lee.jones@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-pwm@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pwm: ab8500: Add error message if pwmchip_add() fails
Date: Tue, 3 Nov 2020 08:18:05 +0000 [thread overview]
Message-ID: <20201103081805.GG4488@dell> (raw)
In-Reply-To: <20201103080039.fuoupa3p5tz3jrws@pengutronix.de>
On Tue, 03 Nov 2020, Uwe Kleine-König wrote:
> On Mon, Oct 26, 2020 at 09:33:00AM +0000, Lee Jones wrote:
> > On Thu, 22 Oct 2020, Uwe Kleine-König wrote:
> >
> > > On Wed, Aug 12, 2020 at 09:11:39AM +0100, Lee Jones wrote:
> > > > On Wed, 12 Aug 2020, Uwe Kleine-König wrote:
> > > >
> > > > > pwmchip_add() doesn't emit an error message, so add one in the driver.
> > > >
> > > > Maybe placing one there would be a good idea.
> > > >
> > > > It would certainly cut down on a lot of superfluous strings.
> > >
> > > Hmm, I'm not convinced. Do you want to work on that? If not I suggest to
> > > still apply the patch as currently it is justified.
> >
> > I haven't looked at implementing it. Does it look difficult/
>
> Probably it isn't, needs just some endurance to actually do it. (And I
> won't invest that in the near future, also because I'm not convinced
> that the result is beneficial.)
I'll add it to my TODO list.
In the mean time, don't let this halt the patch.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-03 8:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 7:52 [PATCH] pwm: ab8500: Add error message if pwmchip_add() fails Uwe Kleine-König
2020-08-12 8:11 ` Lee Jones
2020-10-22 19:22 ` Uwe Kleine-König
2020-10-26 9:33 ` Lee Jones
2020-11-03 8:00 ` Uwe Kleine-König
2020-11-03 8:18 ` Lee Jones [this message]
2020-11-06 13:55 ` Linus Walleij
2020-11-11 18:07 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103081805.GG4488@dell \
--to=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).