[PATCH] pwm: ab8500: Add error message if pwmchip_add() fails

[PATCH] pwm: ab8500: Add error message if pwmchip_add() fails

[Uwe Kleine-König]

pwmchip_add() doesn't emit an error message, so add one in the driver.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/pwm/pwm-ab8500.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pwm/pwm-ab8500.c b/drivers/pwm/pwm-ab8500.c
index fdf3964db4a6..4b6f9e24e11d 100644
--- a/drivers/pwm/pwm-ab8500.c
+++ b/drivers/pwm/pwm-ab8500.c
@@ -106,7 +106,7 @@ static int ab8500_pwm_probe(struct platform_device *pdev)
 
 	err = pwmchip_add(&ab8500->chip);
 	if (err < 0)
-		return err;
+		return dev_err_probe(&pdev->dev, err, "Failed to add pwm chip\n");
 
 	dev_dbg(&pdev->dev, "pwm probe successful\n");
 	platform_set_drvdata(pdev, ab8500);
-- 
2.27.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] pwm: ab8500: Add error message if pwmchip_add() fails

[Lee Jones]

On Wed, 12 Aug 2020, Uwe Kleine-König wrote:

> pwmchip_add() doesn't emit an error message, so add one in the driver.

Maybe placing one there would be a good idea.

It would certainly cut down on a lot of superfluous strings.

> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/pwm/pwm-ab8500.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pwm/pwm-ab8500.c b/drivers/pwm/pwm-ab8500.c
> index fdf3964db4a6..4b6f9e24e11d 100644
> --- a/drivers/pwm/pwm-ab8500.c
> +++ b/drivers/pwm/pwm-ab8500.c
> @@ -106,7 +106,7 @@ static int ab8500_pwm_probe(struct platform_device *pdev)
>  
>  	err = pwmchip_add(&ab8500->chip);
>  	if (err < 0)
> -		return err;
> +		return dev_err_probe(&pdev->dev, err, "Failed to add pwm chip\n");
>  
>  	dev_dbg(&pdev->dev, "pwm probe successful\n");
>  	platform_set_drvdata(pdev, ab8500);

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] pwm: ab8500: Add error message if pwmchip_add() fails

[Uwe Kleine-König]

[-- Attachment #1.1: Type: text/plain, Size: 618 bytes --]

On Wed, Aug 12, 2020 at 09:11:39AM +0100, Lee Jones wrote:
> On Wed, 12 Aug 2020, Uwe Kleine-König wrote:
> 
> > pwmchip_add() doesn't emit an error message, so add one in the driver.
> 
> Maybe placing one there would be a good idea.
> 
> It would certainly cut down on a lot of superfluous strings.

Hmm, I'm not convinced. Do you want to work on that? If not I suggest to
still apply the patch as currently it is justified.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] pwm: ab8500: Add error message if pwmchip_add() fails

[Lee Jones]

On Thu, 22 Oct 2020, Uwe Kleine-König wrote:

> On Wed, Aug 12, 2020 at 09:11:39AM +0100, Lee Jones wrote:
> > On Wed, 12 Aug 2020, Uwe Kleine-König wrote:
> > 
> > > pwmchip_add() doesn't emit an error message, so add one in the driver.
> > 
> > Maybe placing one there would be a good idea.
> > 
> > It would certainly cut down on a lot of superfluous strings.
> 
> Hmm, I'm not convinced. Do you want to work on that? If not I suggest to
> still apply the patch as currently it is justified.

I haven't looked at implementing it.  Does it look difficult/

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] pwm: ab8500: Add error message if pwmchip_add() fails

[Uwe Kleine-König]

[-- Attachment #1.1: Type: text/plain, Size: 1020 bytes --]

On Mon, Oct 26, 2020 at 09:33:00AM +0000, Lee Jones wrote:
> On Thu, 22 Oct 2020, Uwe Kleine-König wrote:
> 
> > On Wed, Aug 12, 2020 at 09:11:39AM +0100, Lee Jones wrote:
> > > On Wed, 12 Aug 2020, Uwe Kleine-König wrote:
> > > 
> > > > pwmchip_add() doesn't emit an error message, so add one in the driver.
> > > 
> > > Maybe placing one there would be a good idea.
> > > 
> > > It would certainly cut down on a lot of superfluous strings.
> > 
> > Hmm, I'm not convinced. Do you want to work on that? If not I suggest to
> > still apply the patch as currently it is justified.
> 
> I haven't looked at implementing it.  Does it look difficult/

Probably it isn't, needs just some endurance to actually do it. (And I
won't invest that in the near future, also because I'm not convinced
that the result is beneficial.)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] pwm: ab8500: Add error message if pwmchip_add() fails

[Lee Jones]

On Tue, 03 Nov 2020, Uwe Kleine-König wrote:

> On Mon, Oct 26, 2020 at 09:33:00AM +0000, Lee Jones wrote:
> > On Thu, 22 Oct 2020, Uwe Kleine-König wrote:
> > 
> > > On Wed, Aug 12, 2020 at 09:11:39AM +0100, Lee Jones wrote:
> > > > On Wed, 12 Aug 2020, Uwe Kleine-König wrote:
> > > > 
> > > > > pwmchip_add() doesn't emit an error message, so add one in the driver.
> > > > 
> > > > Maybe placing one there would be a good idea.
> > > > 
> > > > It would certainly cut down on a lot of superfluous strings.
> > > 
> > > Hmm, I'm not convinced. Do you want to work on that? If not I suggest to
> > > still apply the patch as currently it is justified.
> > 
> > I haven't looked at implementing it.  Does it look difficult/
> 
> Probably it isn't, needs just some endurance to actually do it. (And I
> won't invest that in the near future, also because I'm not convinced
> that the result is beneficial.)

I'll add it to my TODO list.

In the mean time, don't let this halt the patch.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] pwm: ab8500: Add error message if pwmchip_add() fails

[Linus Walleij]

On Wed, Aug 12, 2020 at 9:52 AM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:

> pwmchip_add() doesn't emit an error message, so add one in the driver.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] pwm: ab8500: Add error message if pwmchip_add() fails

[Thierry Reding]

[-- Attachment #1.1: Type: text/plain, Size: 339 bytes --]

On Wed, Aug 12, 2020 at 09:52:14AM +0200, Uwe Kleine-König wrote:
> pwmchip_add() doesn't emit an error message, so add one in the driver.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/pwm/pwm-ab8500.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel