public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH] phy: amlogic: Replace devm_reset_control_array_get()
@ 2020-11-03  4:37 Yejune Deng
  2020-11-03  9:04 ` Remi Pommarel
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Yejune Deng @ 2020-11-03  4:37 UTC (permalink / raw)
  To: khilman, narmstrong, jbrunet, martin.blumenstingl, p.zabel, repk,
	yejune.deng, lorenzo.pieralisi
  Cc: linux-amlogic, vkoul, linux-kernel, linux-arm-kernel, kishon

devm_reset_control_array_get_exclusive() looks more readable

Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
---
 drivers/phy/amlogic/phy-meson-axg-pcie.c       | 2 +-
 drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c | 2 +-
 drivers/soc/amlogic/meson-ee-pwrc.c            | 3 +--
 drivers/soc/amlogic/meson-gx-pwrc-vpu.c        | 2 +-
 4 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/phy/amlogic/phy-meson-axg-pcie.c b/drivers/phy/amlogic/phy-meson-axg-pcie.c
index 377ed0d..3204f02 100644
--- a/drivers/phy/amlogic/phy-meson-axg-pcie.c
+++ b/drivers/phy/amlogic/phy-meson-axg-pcie.c
@@ -155,7 +155,7 @@ static int phy_axg_pcie_probe(struct platform_device *pdev)
 	if (IS_ERR(priv->regmap))
 		return PTR_ERR(priv->regmap);
 
-	priv->reset = devm_reset_control_array_get(dev, false, false);
+	priv->reset = devm_reset_control_array_get_exclusive(dev);
 	if (IS_ERR(priv->reset))
 		return PTR_ERR(priv->reset);
 
diff --git a/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c b/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c
index 08e3227..bab6345 100644
--- a/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c
+++ b/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c
@@ -418,7 +418,7 @@ static int phy_g12a_usb3_pcie_probe(struct platform_device *pdev)
 	if (ret)
 		goto err_disable_clk_ref;
 
-	priv->reset = devm_reset_control_array_get(dev, false, false);
+	priv->reset = devm_reset_control_array_get_exclusive(dev);
 	if (IS_ERR(priv->reset))
 		return PTR_ERR(priv->reset);
 
diff --git a/drivers/soc/amlogic/meson-ee-pwrc.c b/drivers/soc/amlogic/meson-ee-pwrc.c
index ed7d2fb..3a879a4 100644
--- a/drivers/soc/amlogic/meson-ee-pwrc.c
+++ b/drivers/soc/amlogic/meson-ee-pwrc.c
@@ -413,8 +413,7 @@ static int meson_ee_pwrc_init_domain(struct platform_device *pdev,
 			dev_warn(&pdev->dev, "Invalid resets count %d for domain %s\n",
 				 count, dom->desc.name);
 
-		dom->rstc = devm_reset_control_array_get(&pdev->dev, false,
-							 false);
+		dom->rstc = devm_reset_control_array_get_exclusive(&pdev->dev)
 		if (IS_ERR(dom->rstc))
 			return PTR_ERR(dom->rstc);
 	}
diff --git a/drivers/soc/amlogic/meson-gx-pwrc-vpu.c b/drivers/soc/amlogic/meson-gx-pwrc-vpu.c
index 8790627..b4615b2 100644
--- a/drivers/soc/amlogic/meson-gx-pwrc-vpu.c
+++ b/drivers/soc/amlogic/meson-gx-pwrc-vpu.c
@@ -304,7 +304,7 @@ static int meson_gx_pwrc_vpu_probe(struct platform_device *pdev)
 		return PTR_ERR(regmap_hhi);
 	}
 
-	rstc = devm_reset_control_array_get(&pdev->dev, false, false);
+	rstc = devm_reset_control_array_get_exclusive(&pdev->dev);
 	if (IS_ERR(rstc)) {
 		if (PTR_ERR(rstc) != -EPROBE_DEFER)
 			dev_err(&pdev->dev, "failed to get reset lines\n");
-- 
1.9.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] phy: amlogic: Replace devm_reset_control_array_get()
  2020-11-03  4:37 [PATCH] phy: amlogic: Replace devm_reset_control_array_get() Yejune Deng
@ 2020-11-03  9:04 ` Remi Pommarel
  2020-11-08 22:13 ` Martin Blumenstingl
  2020-11-16  7:24 ` Vinod Koul
  2 siblings, 0 replies; 8+ messages in thread
From: Remi Pommarel @ 2020-11-03  9:04 UTC (permalink / raw)
  To: Yejune Deng
  Cc: lorenzo.pieralisi, narmstrong, martin.blumenstingl, khilman,
	linux-kernel, kishon, vkoul, p.zabel, linux-amlogic,
	linux-arm-kernel, jbrunet

Hi

On Tue, Nov 03, 2020 at 12:37:54PM +0800, Yejune Deng wrote:
> devm_reset_control_array_get_exclusive() looks more readable
> 
> Signed-off-by: Yejune Deng <yejune.deng@gmail.com>

Reviewed-by: Remi Pommarel <repk@triplefau.lt> for phy-meson-axg-pcie

Thanks.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] phy: amlogic: Replace devm_reset_control_array_get()
  2020-11-03  4:37 [PATCH] phy: amlogic: Replace devm_reset_control_array_get() Yejune Deng
  2020-11-03  9:04 ` Remi Pommarel
@ 2020-11-08 22:13 ` Martin Blumenstingl
  2020-11-16  7:24 ` Vinod Koul
  2 siblings, 0 replies; 8+ messages in thread
From: Martin Blumenstingl @ 2020-11-08 22:13 UTC (permalink / raw)
  To: Yejune Deng
  Cc: lorenzo.pieralisi, Neil Armstrong, khilman, linux-kernel, kishon,
	vkoul, repk, p.zabel, linux-amlogic, linux-arm-kernel, jbrunet

On Tue, Nov 3, 2020 at 5:38 AM Yejune Deng <yejune.deng@gmail.com> wrote:
>
> devm_reset_control_array_get_exclusive() looks more readable
>
> Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] phy: amlogic: Replace devm_reset_control_array_get()
  2020-11-03  4:37 [PATCH] phy: amlogic: Replace devm_reset_control_array_get() Yejune Deng
  2020-11-03  9:04 ` Remi Pommarel
  2020-11-08 22:13 ` Martin Blumenstingl
@ 2020-11-16  7:24 ` Vinod Koul
  2 siblings, 0 replies; 8+ messages in thread
From: Vinod Koul @ 2020-11-16  7:24 UTC (permalink / raw)
  To: Yejune Deng
  Cc: lorenzo.pieralisi, narmstrong, martin.blumenstingl, khilman,
	linux-kernel, kishon, repk, p.zabel, linux-amlogic,
	linux-arm-kernel, jbrunet

On 03-11-20, 12:37, Yejune Deng wrote:
> devm_reset_control_array_get_exclusive() looks more readable

Applied, thanks

-- 
~Vinod

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH] phy: amlogic: replace devm_reset_control_array_get()
@ 2020-11-18  2:36 Yejune Deng
  2020-11-18 14:55 ` Philipp Zabel
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Yejune Deng @ 2020-11-18  2:36 UTC (permalink / raw)
  To: kishon, vkoul, khilman, narmstrong, jbrunet, martin.blumenstingl,
	p.zabel, lorenzo.pieralisi, repk, yejune.deng
  Cc: linux-amlogic, linux-kernel, linux-arm-kernel

devm_reset_control_array_get_exclusive() looks more readable

Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
---
 drivers/phy/amlogic/phy-meson-axg-pcie.c       | 2 +-
 drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/amlogic/phy-meson-axg-pcie.c b/drivers/phy/amlogic/phy-meson-axg-pcie.c
index 377ed0d..3204f02 100644
--- a/drivers/phy/amlogic/phy-meson-axg-pcie.c
+++ b/drivers/phy/amlogic/phy-meson-axg-pcie.c
@@ -155,7 +155,7 @@ static int phy_axg_pcie_probe(struct platform_device *pdev)
 	if (IS_ERR(priv->regmap))
 		return PTR_ERR(priv->regmap);
 
-	priv->reset = devm_reset_control_array_get(dev, false, false);
+	priv->reset = devm_reset_control_array_get_exclusive(dev);
 	if (IS_ERR(priv->reset))
 		return PTR_ERR(priv->reset);
 
diff --git a/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c b/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c
index 08e3227..bab6345 100644
--- a/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c
+++ b/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c
@@ -418,7 +418,7 @@ static int phy_g12a_usb3_pcie_probe(struct platform_device *pdev)
 	if (ret)
 		goto err_disable_clk_ref;
 
-	priv->reset = devm_reset_control_array_get(dev, false, false);
+	priv->reset = devm_reset_control_array_get_exclusive(dev);
 	if (IS_ERR(priv->reset))
 		return PTR_ERR(priv->reset);
 
-- 
1.9.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] phy: amlogic: replace devm_reset_control_array_get()
  2020-11-18  2:36 [PATCH] phy: amlogic: replace devm_reset_control_array_get() Yejune Deng
@ 2020-11-18 14:55 ` Philipp Zabel
  2020-11-22 21:55 ` Martin Blumenstingl
  2020-11-30 11:02 ` Vinod Koul
  2 siblings, 0 replies; 8+ messages in thread
From: Philipp Zabel @ 2020-11-18 14:55 UTC (permalink / raw)
  To: Yejune Deng, kishon, vkoul, khilman, narmstrong, jbrunet,
	martin.blumenstingl, lorenzo.pieralisi, repk
  Cc: linux-amlogic, linux-kernel, linux-arm-kernel

Hi Yejune,

On Wed, 2020-11-18 at 10:36 +0800, Yejune Deng wrote:
> devm_reset_control_array_get_exclusive() looks more readable
> 
> Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
> ---
>  drivers/phy/amlogic/phy-meson-axg-pcie.c       | 2 +-
>  drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/phy/amlogic/phy-meson-axg-pcie.c b/drivers/phy/amlogic/phy-meson-axg-pcie.c
> index 377ed0d..3204f02 100644
> --- a/drivers/phy/amlogic/phy-meson-axg-pcie.c
> +++ b/drivers/phy/amlogic/phy-meson-axg-pcie.c
> @@ -155,7 +155,7 @@ static int phy_axg_pcie_probe(struct platform_device *pdev)
>  	if (IS_ERR(priv->regmap))
>  		return PTR_ERR(priv->regmap);
>  
> -	priv->reset = devm_reset_control_array_get(dev, false, false);
> +	priv->reset = devm_reset_control_array_get_exclusive(dev);
>  	if (IS_ERR(priv->reset))
>  		return PTR_ERR(priv->reset);
>  
> diff --git a/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c b/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c
> index 08e3227..bab6345 100644
> --- a/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c
> +++ b/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c
> @@ -418,7 +418,7 @@ static int phy_g12a_usb3_pcie_probe(struct platform_device *pdev)
>  	if (ret)
>  		goto err_disable_clk_ref;
>  
> -	priv->reset = devm_reset_control_array_get(dev, false, false);
> +	priv->reset = devm_reset_control_array_get_exclusive(dev);
>  	if (IS_ERR(priv->reset))
>  		return PTR_ERR(priv->reset);
>  

Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>

regards
Philipp

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] phy: amlogic: replace devm_reset_control_array_get()
  2020-11-18  2:36 [PATCH] phy: amlogic: replace devm_reset_control_array_get() Yejune Deng
  2020-11-18 14:55 ` Philipp Zabel
@ 2020-11-22 21:55 ` Martin Blumenstingl
  2020-11-30 11:02 ` Vinod Koul
  2 siblings, 0 replies; 8+ messages in thread
From: Martin Blumenstingl @ 2020-11-22 21:55 UTC (permalink / raw)
  To: Yejune Deng
  Cc: lorenzo.pieralisi, Neil Armstrong, khilman, linux-kernel, kishon,
	vkoul, repk, p.zabel, linux-amlogic, linux-arm-kernel, jbrunet

On Wed, Nov 18, 2020 at 3:36 AM Yejune Deng <yejune.deng@gmail.com> wrote:
>
> devm_reset_control_array_get_exclusive() looks more readable
>
> Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] phy: amlogic: replace devm_reset_control_array_get()
  2020-11-18  2:36 [PATCH] phy: amlogic: replace devm_reset_control_array_get() Yejune Deng
  2020-11-18 14:55 ` Philipp Zabel
  2020-11-22 21:55 ` Martin Blumenstingl
@ 2020-11-30 11:02 ` Vinod Koul
  2 siblings, 0 replies; 8+ messages in thread
From: Vinod Koul @ 2020-11-30 11:02 UTC (permalink / raw)
  To: Yejune Deng
  Cc: lorenzo.pieralisi, narmstrong, martin.blumenstingl, khilman,
	linux-kernel, kishon, repk, p.zabel, linux-amlogic,
	linux-arm-kernel, jbrunet

On 18-11-20, 10:36, Yejune Deng wrote:
> devm_reset_control_array_get_exclusive() looks more readable

Applied, thanks

-- 
~Vinod

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-11-30 11:04 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-03  4:37 [PATCH] phy: amlogic: Replace devm_reset_control_array_get() Yejune Deng
2020-11-03  9:04 ` Remi Pommarel
2020-11-08 22:13 ` Martin Blumenstingl
2020-11-16  7:24 ` Vinod Koul
  -- strict thread matches above, loose matches on Subject: below --
2020-11-18  2:36 [PATCH] phy: amlogic: replace devm_reset_control_array_get() Yejune Deng
2020-11-18 14:55 ` Philipp Zabel
2020-11-22 21:55 ` Martin Blumenstingl
2020-11-30 11:02 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox