From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EE83C2D0A3 for ; Tue, 3 Nov 2020 09:16:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B0CAB204FD for ; Tue, 3 Nov 2020 09:16:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MYvYXyCj"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="qln8MdI6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B0CAB204FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5N3nX7TkJXN5rNtJd/WaPf3ijIpbctfayxk2HF5y69o=; b=MYvYXyCjbeUSGtjXtt1oRByCx +SeEArasIlYQpRneh1xteIIjSr96OS2Mivb73F64h7Rxbsx7vGKemoSnZfEH5CU51X5aY2r9BCey8 VwYdGEen2hL/Bqv0tXNu+jL9HJML7HQOvYWj7bRUwt6z+P2kH1I6eUgrugMCPETpz5CI6Z8fKwd++ u3/xuLmACkTQyFb5J2C2TUIlbu0He7GUd05aJbQbOYDWSmHHLpQkd3dg2u5FV2tkG0JobcdafkvfX YdkQ6qmgWmXPujLBUHiWjChqAZ0dnYO+0TEOiQa2zZkK2hIGtozqjYb2G4VPt61QddSX+CYaNcHBA ib47/7CaA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZsOz-00048F-G9; Tue, 03 Nov 2020 09:14:55 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZsOs-00046W-Qz for linux-arm-kernel@lists.infradead.org; Tue, 03 Nov 2020 09:14:48 +0000 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0CB8020756; Tue, 3 Nov 2020 09:14:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604394885; bh=ZHBZOejCjX5l8sZRwuQR75aiAkvpCacnS9a7dm3ZHWw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qln8MdI6DivkRV8z0NNzzjlNCxVzjVdA/Fv1NgjVip/n/1gFGnqFFvPb71GuAnUIO /2eNbcs3wGdBPupCY+nPbaFzvLuxEUzYibz1rSSFzK875xRQ0sASb7T2390zB6JrJ9 /8V+j5a9jQGnLDsnL73G32hmgIebDkvEIp3AO60Y= Date: Tue, 3 Nov 2020 10:15:38 +0100 From: Greg KH To: Daniel Vetter Subject: Re: [PATCH v2 1/1] Fonts: Replace discarded const qualifier Message-ID: <20201103091538.GA2663113@kroah.com> References: <20201030181822.570402-1-lee.jones@linaro.org> <20201102183242.2031659-1-yepeilin.cs@gmail.com> <20201103085324.GL4488@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201103_041448_050747_6EFA339F X-CRM114-Status: GOOD ( 25.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux Kernel Mailing List , stable , Russell King - ARM Linux , Lee Jones , Peilin Ye , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 03, 2020 at 09:58:18AM +0100, Daniel Vetter wrote: > On Tue, Nov 3, 2020 at 9:53 AM Lee Jones wrote: > > > > On Mon, 02 Nov 2020, Peilin Ye wrote: > > > > > From: Lee Jones > > > > > > Commit 6735b4632def ("Fonts: Support FONT_EXTRA_WORDS macros for built-in > > > fonts") introduced the following error when building rpc_defconfig (only > > > this build appears to be affected): > > > > > > `acorndata_8x8' referenced in section `.text' of arch/arm/boot/compressed/ll_char_wr.o: > > > defined in discarded section `.data' of arch/arm/boot/compressed/font.o > > > `acorndata_8x8' referenced in section `.data.rel.ro' of arch/arm/boot/compressed/font.o: > > > defined in discarded section `.data' of arch/arm/boot/compressed/font.o > > > make[3]: *** [/scratch/linux/arch/arm/boot/compressed/Makefile:191: arch/arm/boot/compressed/vmlinux] Error 1 > > > make[2]: *** [/scratch/linux/arch/arm/boot/Makefile:61: arch/arm/boot/compressed/vmlinux] Error 2 > > > make[1]: *** [/scratch/linux/arch/arm/Makefile:317: zImage] Error 2 > > > > > > The .data section is discarded at link time. Reinstating acorndata_8x8 as > > > const ensures it is still available after linking. Do the same for the > > > other 12 built-in fonts as well, for consistency purposes. > > > > > > Cc: > > > Cc: Russell King > > > Fixes: 6735b4632def ("Fonts: Support FONT_EXTRA_WORDS macros for built-in fonts") > > > Signed-off-by: Lee Jones > > > Co-developed-by: Peilin Ye > > > Signed-off-by: Peilin Ye > > > --- > > > Changes in v2: > > > - Fix commit ID to 6735b4632def in commit message (Russell King > > > ) > > > - Add `const` back for all 13 built-in fonts (Daniel Vetter > > > ) > > > - Add a Fixes: tag > > > > > > lib/fonts/font_10x18.c | 2 +- > > > lib/fonts/font_6x10.c | 2 +- > > > lib/fonts/font_6x11.c | 2 +- > > > lib/fonts/font_6x8.c | 2 +- > > > lib/fonts/font_7x14.c | 2 +- > > > lib/fonts/font_8x16.c | 2 +- > > > lib/fonts/font_8x8.c | 2 +- > > > lib/fonts/font_acorn_8x8.c | 2 +- > > > lib/fonts/font_mini_4x6.c | 2 +- > > > lib/fonts/font_pearl_8x8.c | 2 +- > > > lib/fonts/font_sun12x22.c | 2 +- > > > lib/fonts/font_sun8x16.c | 2 +- > > > lib/fonts/font_ter16x32.c | 2 +- > > > 13 files changed, 13 insertions(+), 13 deletions(-) > > > > LGTM. > > > > Thanks for keeping my authorship. Much appreciated. > > Should I stuff this into drm-misc-fixes? Or will someone else pick > this up? Greg? > > I guess drm-misc-fixes might be easiest since there's a bunch of other > fbcon/font stuff in the queue in drm-misc from Peilin. You can take it: Reviewed-by: Greg Kroah-Hartman _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel