From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCBC0C2D0A3 for ; Tue, 3 Nov 2020 09:35:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 52712223BD for ; Tue, 3 Nov 2020 09:35:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PBe5gCKb"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="euhf9CUD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 52712223BD Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=J6hOsOpurOHSFpUcqmD5zkqDL/92p64UUWqvOPySQAI=; b=PBe5gCKbcQNfyhSFYOyM6Bhopb hJQPlfOCMXxl+H0w6bcWGLjRDzAjfkYnTYl+2sCyM1E63oanF3BhyTlfR783EQc+pda2z36vZp3Wb +hfBo8TibthKrmTsyJ6sqKnKWFQbr/vYxoLVrS8mOl+uu0Vktcn39hHl8RbTN8FtQfjvIiyDZEmrG 08MK5YJNKIOWSCcMic4tEkwVFBErlO9ENJTTQChyzBG09I4eB64DhAEkd3erhomcwCj+mrC0524GG uL4A2rc//zqjnTGpx4AzBqfZgSw2KOWJJBMoy75jgQ6UDR42zVceY988YVhJEH8AAczmMLh0OYTVr UXcjxLYQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZsgq-0007v5-GT; Tue, 03 Nov 2020 09:33:20 +0000 Received: from esa2.microchip.iphmx.com ([68.232.149.84]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZsgo-0007uB-AE for linux-arm-kernel@lists.infradead.org; Tue, 03 Nov 2020 09:33:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1604395998; x=1635931998; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=HlIb1TDqPqPTkeLT43BZ/oxQ5DQ4JwFhlTX3cQe6Ppk=; b=euhf9CUDB97G4Cko1z3PKz9sGcP44ksO/IA/t2n381c9vR1d9nwtHZFO g498AT4AAFmb/Lh7A6yRYNw1b8a90IGZ8QiPisGzY4ZkNTo6DwxsgTdlD c9kbF/lSabW5KQSXhKkQG1GYaemlNMN9BuLeP3CzgC1V+kyQmDl10SNs6 5v/OQVLMr7hmfKgX7uHd1buXqqyMi1IcAxoJ/b853uk6fUmlKhw3tM0YG iyOkRNREGYxVh+oTBimR2lckpB09+Sq4YrzVWDaw0MS5tm3OFR/VNzCg8 AKosWYImfnWZq62+n1l7VWP3nPUu+ttjyUWRo3SvFdPaOF/pD5rP6S2so g==; IronPort-SDR: 43h/BbcwN+gHozNy93mKsMGDEchoXmVDj9BqQI6KEzuxQVMQAdl6zblSUbShWgXYMGvgdYu7hd JBadLSBwSH7ChW1KdusnXAga3Jd8eT5AKf32Ywlbz6cbBGky5dE0KHYzDdn8BEQ5spY7GmAdeV mdk6eUW7nKOBW1J2WZGyfP6d03RXNQn6pDWSw6BPXdi0V4138b+a43R8JuP5r5KfdQKGAWLk8Z 1CDCp2kwj2eX8HK+yC66Ixjjei+se4LmtbCFUUjnNj/oucy1tNPFRuBmQ0gOC13yMSqZWHyeA6 nCQ= X-IronPort-AV: E=Sophos;i="5.77,447,1596524400"; d="scan'208";a="94873908" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 03 Nov 2020 02:33:15 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Tue, 3 Nov 2020 02:33:15 -0700 Received: from rob-ult-m19940.amer.actel.com (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.1979.3 via Frontend Transport; Tue, 3 Nov 2020 02:33:12 -0700 From: Codrin Ciubotariu To: , Subject: [PATCH] mfd: at91-usart: do not use compatible to register child devices Date: Tue, 3 Nov 2020 11:32:46 +0200 Message-ID: <20201103093246.1288956-1-codrin.ciubotariu@microchip.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201103_043318_599784_DFF40EFE X-CRM114-Status: GOOD ( 10.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, radu_nicolae.pirea@upb.ro, ludovic.desroches@microchip.com, Codrin Ciubotariu , lee.jones@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There are no separate serial/SPI devices under the at91-usart MFD, but actually the MFD is used as a serial or a SPI device. There are no DT sub-nodes for the MFD children, so we should use platform device API to register the drivers. Suggested-by: Lee Jones Signed-off-by: Codrin Ciubotariu --- drivers/mfd/at91-usart.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/mfd/at91-usart.c b/drivers/mfd/at91-usart.c index 6a8351a4588e..7f08cb60c58b 100644 --- a/drivers/mfd/at91-usart.c +++ b/drivers/mfd/at91-usart.c @@ -15,15 +15,11 @@ #include #include -static const struct mfd_cell at91_usart_spi_subdev = { - .name = "at91_usart_spi", - .of_compatible = "microchip,at91sam9g45-usart-spi", -}; +static const struct mfd_cell at91_usart_spi_subdev = + MFD_CELL_NAME("at91_usart_spi"); -static const struct mfd_cell at91_usart_serial_subdev = { - .name = "atmel_usart_serial", - .of_compatible = "atmel,at91rm9200-usart-serial", -}; +static const struct mfd_cell at91_usart_serial_subdev = + MFD_CELL_NAME("atmel_usart_serial"); static int at91_usart_mode_probe(struct platform_device *pdev) { -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel