From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AC05C388F7 for ; Tue, 3 Nov 2020 09:55:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC504223BD for ; Tue, 3 Nov 2020 09:55:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rGJSGTPz"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="JFvItVm0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC504223BD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2n5i6WJyjKGcenKEAKdvEYQZtL3IBE9H/auffYXi0Z8=; b=rGJSGTPzyylS1Krv7zHm6zTF3 ols1sg7HeYv+1mYb4aNZemco64Rj7cYkwz5nSErXhNXB+EpyJTv6qwRZ7q9ObBUXlZEqi7kULnCIb o93Nzqy3jMIm0+v2CrPCCu5lAblMYK1j9KibFHyJ9R7z7PmUIML7kNAZETL8h4i0srngZ910WSwd0 Zs8oqtJI3jwAFkd3SmfVTsEvyGc1+RVTA+7mT6p3zqa9w0C6aY7TdVb9HbCRPAZ8jlp3ZYMzAHg6C RhcDNLFl+XhgyDR2mudzQ3ZeCCASZFZPJ6QI9Yptx/nKzgC6bVqemDcNXl1DUHu1L8cWCiK7i8Sns 1PX5mMLNA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZszl-00022y-Uf; Tue, 03 Nov 2020 09:52:54 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZszj-00021b-8x for linux-arm-kernel@lists.infradead.org; Tue, 03 Nov 2020 09:52:52 +0000 Received: by mail-wr1-x443.google.com with SMTP id e6so527788wro.1 for ; Tue, 03 Nov 2020 01:52:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=tZURvADMiFaiJPFlm7U63ViQDE3v0TWLHH+E89RNfTM=; b=JFvItVm0kvcse/IWL2EVvynsnyi3W9vwJPwpyUL/PNg0EQ+xrW0PyyNzU1ol/wNHEO KaTQ0NgjUNksEIYXCiwvrhpgL+3p4v0N9HRRwbJKbHy3ZzVI/cknLbneL1Cxn+hHuf48 l1uke1kys9PZZ5UZYsV8oF8VXShVo0/kZGOIY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=tZURvADMiFaiJPFlm7U63ViQDE3v0TWLHH+E89RNfTM=; b=pNgY8VBlUje/vaGCJ35srbDgNyvT/7ZgylfJjXeusv5PkwiMdR8VTTaaALboRPObMj UaE0Ni3YDsqoXJ9KDEdh9DyDUUgcppiQdzLfy62Dzh3pOI10C5z2YlHMzYAID8Z6XE24 LLl7eOKctJQSO5NZFd3EEsX4mf510c4kbVqvDgrdtJeb2Fue04CDvspRoycEBoijnbCu TthA5+p9x0L4Y9R5cfrH4JPKm9gKdu9kkbseTTVjNqqAD3p6PuY0gB56DiqDt9OEVl1i StyMgB3bZ5PE63yXRkrWsVdXbkD51gNGHsDux1eqJsmxjLKNGeUVi6Yr3Lta27b2+m02 8/iw== X-Gm-Message-State: AOAM533azrhw27CNjm8rifE8clFC0pYJ7UYcqdDQbbtOE+kHtKajm5N1 VD7vfm1fCInk7wz4997RE5ShD0cfm/1bYN9c X-Google-Smtp-Source: ABdhPJzusxtA0XkuTlkE8VCJBhBzvhLspVAmN9cw157VA0KKY9W4itB4ZEmLrfkkEt6x4UM89bMmbQ== X-Received: by 2002:adf:9f49:: with SMTP id f9mr17860205wrg.122.1604397162504; Tue, 03 Nov 2020 01:52:42 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id w11sm2515722wmg.36.2020.11.03.01.52.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2020 01:52:41 -0800 (PST) Date: Tue, 3 Nov 2020 10:52:39 +0100 From: Daniel Vetter To: Greg KH Subject: Re: [PATCH v2 1/1] Fonts: Replace discarded const qualifier Message-ID: <20201103095239.GW401619@phenom.ffwll.local> Mail-Followup-To: Greg KH , Lee Jones , Peilin Ye , Russell King - ARM Linux , Linux ARM , Linux Kernel Mailing List , stable References: <20201030181822.570402-1-lee.jones@linaro.org> <20201102183242.2031659-1-yepeilin.cs@gmail.com> <20201103085324.GL4488@dell> <20201103091538.GA2663113@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201103091538.GA2663113@kroah.com> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201103_045251_445037_8BFFBFD5 X-CRM114-Status: GOOD ( 28.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Linux Kernel Mailing List , stable , Russell King - ARM Linux , Lee Jones , Peilin Ye , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 03, 2020 at 10:15:38AM +0100, Greg KH wrote: > On Tue, Nov 03, 2020 at 09:58:18AM +0100, Daniel Vetter wrote: > > On Tue, Nov 3, 2020 at 9:53 AM Lee Jones wrote: > > > > > > On Mon, 02 Nov 2020, Peilin Ye wrote: > > > > > > > From: Lee Jones > > > > > > > > Commit 6735b4632def ("Fonts: Support FONT_EXTRA_WORDS macros for built-in > > > > fonts") introduced the following error when building rpc_defconfig (only > > > > this build appears to be affected): > > > > > > > > `acorndata_8x8' referenced in section `.text' of arch/arm/boot/compressed/ll_char_wr.o: > > > > defined in discarded section `.data' of arch/arm/boot/compressed/font.o > > > > `acorndata_8x8' referenced in section `.data.rel.ro' of arch/arm/boot/compressed/font.o: > > > > defined in discarded section `.data' of arch/arm/boot/compressed/font.o > > > > make[3]: *** [/scratch/linux/arch/arm/boot/compressed/Makefile:191: arch/arm/boot/compressed/vmlinux] Error 1 > > > > make[2]: *** [/scratch/linux/arch/arm/boot/Makefile:61: arch/arm/boot/compressed/vmlinux] Error 2 > > > > make[1]: *** [/scratch/linux/arch/arm/Makefile:317: zImage] Error 2 > > > > > > > > The .data section is discarded at link time. Reinstating acorndata_8x8 as > > > > const ensures it is still available after linking. Do the same for the > > > > other 12 built-in fonts as well, for consistency purposes. > > > > > > > > Cc: > > > > Cc: Russell King > > > > Fixes: 6735b4632def ("Fonts: Support FONT_EXTRA_WORDS macros for built-in fonts") > > > > Signed-off-by: Lee Jones > > > > Co-developed-by: Peilin Ye > > > > Signed-off-by: Peilin Ye > > > > --- > > > > Changes in v2: > > > > - Fix commit ID to 6735b4632def in commit message (Russell King > > > > ) > > > > - Add `const` back for all 13 built-in fonts (Daniel Vetter > > > > ) > > > > - Add a Fixes: tag > > > > > > > > lib/fonts/font_10x18.c | 2 +- > > > > lib/fonts/font_6x10.c | 2 +- > > > > lib/fonts/font_6x11.c | 2 +- > > > > lib/fonts/font_6x8.c | 2 +- > > > > lib/fonts/font_7x14.c | 2 +- > > > > lib/fonts/font_8x16.c | 2 +- > > > > lib/fonts/font_8x8.c | 2 +- > > > > lib/fonts/font_acorn_8x8.c | 2 +- > > > > lib/fonts/font_mini_4x6.c | 2 +- > > > > lib/fonts/font_pearl_8x8.c | 2 +- > > > > lib/fonts/font_sun12x22.c | 2 +- > > > > lib/fonts/font_sun8x16.c | 2 +- > > > > lib/fonts/font_ter16x32.c | 2 +- > > > > 13 files changed, 13 insertions(+), 13 deletions(-) > > > > > > LGTM. > > > > > > Thanks for keeping my authorship. Much appreciated. > > > > Should I stuff this into drm-misc-fixes? Or will someone else pick > > this up? Greg? > > > > I guess drm-misc-fixes might be easiest since there's a bunch of other > > fbcon/font stuff in the queue in drm-misc from Peilin. > > You can take it: > > Reviewed-by: Greg Kroah-Hartman Applied to drm-misc-fixes, thanks everyone! Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel