From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8426C2D0A3 for ; Tue, 3 Nov 2020 12:45:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6EEB522243 for ; Tue, 3 Nov 2020 12:45:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sq72//PS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6EEB522243 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2waTZ2cMvZi0qRKYlm8/99b4EY4c552atJ4cYL7ImFg=; b=sq72//PSGxlaiREH/77RDyS3R BT3Cq6VlR4EVmJeJntIWhllC9lOaEt8dF9Kd+OC5Avdrnkdm+LAMX5KrFZ7+axMQwFBKCU6K2Z/o4 gDuPfjGMjX/VfYfhwR2RkA36DoQs2ZS8v46T9DxF2xKN2IsqAYJH+xiJ5GxsBPfX8I7ms6THys9FG 4QB5HiD3GpD8Si8Ui8qNoUW/xOxAg/cxLKdiZhwvKH5nz7+yUbNvZ1+MsOrHFmE9axW6gjO6tmQnI wfVnpSLvgKWqC8ObYgBUH7UNJ3+d4pe1hxzDQigdACKT7hD3k1ikA1sTzolH94RnWYzNxgZqLom3L 6bvYkX6BA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZvg0-0005yR-V9; Tue, 03 Nov 2020 12:44:41 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZvfx-0005wr-NV for linux-arm-kernel@lists.infradead.org; Tue, 03 Nov 2020 12:44:38 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3EA3A106F; Tue, 3 Nov 2020 04:44:36 -0800 (PST) Received: from C02TD0UTHF1T.local (unknown [10.57.57.89]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 46A003F718; Tue, 3 Nov 2020 04:44:33 -0800 (PST) Date: Tue, 3 Nov 2020 12:44:31 +0000 From: Mark Rutland To: Will Deacon Subject: Re: [PATCH v4 2/4] arm64: cpufeatures: Add capability for LDAPR instruction Message-ID: <20201103124431.GB40454@C02TD0UTHF1T.local> References: <20201103121721.5166-1-will@kernel.org> <20201103121721.5166-3-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201103121721.5166-3-will@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201103_074438_034542_E8FFB2FD X-CRM114-Status: GOOD ( 22.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kees Cook , Peter Zijlstra , Catalin Marinas , Masahiro Yamada , linux-kernel@vger.kernel.org, Sami Tolvanen , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 03, 2020 at 12:17:19PM +0000, Will Deacon wrote: > Armv8.3 introduced the LDAPR instruction, which provides weaker memory > ordering semantics than LDARi (RCpc vs RCsc). Generally, we provide an > RCsc implementation when implementing the Linux memory model, but LDAPR > can be used as a useful alternative to dependency ordering, particularly > when the compiler is capable of breaking the dependencies. > > Since LDAPR is not available on all CPUs, add a cpufeature to detect it at > runtime and allow the instruction to be used with alternative code > patching. > > Acked-by: Peter Zijlstra (Intel) > Signed-off-by: Will Deacon Acked-by: Mark Rutland Mark. > --- > arch/arm64/Kconfig | 3 +++ > arch/arm64/include/asm/cpucaps.h | 3 ++- > arch/arm64/kernel/cpufeature.c | 10 ++++++++++ > 3 files changed, 15 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 1d466addb078..356c50b0447f 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -1388,6 +1388,9 @@ config ARM64_PAN > The feature is detected at runtime, and will remain as a 'nop' > instruction if the cpu does not implement the feature. > > +config AS_HAS_LDAPR > + def_bool $(as-instr,.arch_extension rcpc) > + > config ARM64_LSE_ATOMICS > bool > default ARM64_USE_LSE_ATOMICS > diff --git a/arch/arm64/include/asm/cpucaps.h b/arch/arm64/include/asm/cpucaps.h > index e7d98997c09c..64ea0bb9f420 100644 > --- a/arch/arm64/include/asm/cpucaps.h > +++ b/arch/arm64/include/asm/cpucaps.h > @@ -66,7 +66,8 @@ > #define ARM64_HAS_TLB_RANGE 56 > #define ARM64_MTE 57 > #define ARM64_WORKAROUND_1508412 58 > +#define ARM64_HAS_LDAPR 59 > > -#define ARM64_NCAPS 59 > +#define ARM64_NCAPS 60 > > #endif /* __ASM_CPUCAPS_H */ > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > index dcc165b3fc04..b7b6804cb931 100644 > --- a/arch/arm64/kernel/cpufeature.c > +++ b/arch/arm64/kernel/cpufeature.c > @@ -2136,6 +2136,16 @@ static const struct arm64_cpu_capabilities arm64_features[] = { > .cpu_enable = cpu_enable_mte, > }, > #endif /* CONFIG_ARM64_MTE */ > + { > + .desc = "RCpc load-acquire (LDAPR)", > + .capability = ARM64_HAS_LDAPR, > + .type = ARM64_CPUCAP_SYSTEM_FEATURE, > + .sys_reg = SYS_ID_AA64ISAR1_EL1, > + .sign = FTR_UNSIGNED, > + .field_pos = ID_AA64ISAR1_LRCPC_SHIFT, > + .matches = has_cpuid_feature, > + .min_field_value = 1, > + }, > {}, > }; > > -- > 2.29.1.341.ge80a0c044ae-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel