From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73D47C2D0A3 for ; Tue, 3 Nov 2020 13:15:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E41B421534 for ; Tue, 3 Nov 2020 13:15:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FUrpwDJf"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="nW9trrfa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E41B421534 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=98rtpCWrKoebqXc4+eD7qQCs7rZXrLocu7Z7+XulAkI=; b=FUrpwDJfEdpMtQd6lflgHARxq QWRfP1/yM0PFjb1epoaa2dDlZtZga9S1LnrDi493bT4dn1KrImJHXaTn6nZyso+nqRT3sZhfff8XR jDHMTBTWaZzAp1/TlR5mt0iH1CZ5BqnFFb9HEDtixVgzAFWkTY8wRNM/sdcjNYUPIoJknLXjRH5he fals6MVeX3aLI6HBAJnhWIXnIrCsLDjW3xDD4315pvWtUrEVIp+bKTY8HFf9M1R5PrW2nbwyIS8TB d4o1p01KvXXUZKotgNr5X2d7rroLjMIXdr6BrBo6l8W+/5esC3yCsza4UG1XBu9rvFkETJhA3ptHL F+/Sm3gfA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZw83-0003TZ-Ot; Tue, 03 Nov 2020 13:13:39 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZw7z-0003RX-1k for linux-arm-kernel@lists.infradead.org; Tue, 03 Nov 2020 13:13:36 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4D0B72224E; Tue, 3 Nov 2020 13:13:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604409213; bh=edRL5vtp4UROAk8/UZchdi8Kc9ie+fR/3lbZyGEaEFQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nW9trrfaMaPkLCAzLMM/FnvqZRGSr7WdRcehCQL8uHDQ60eZt09Ns9cOCK3lK+1W0 H0ucgrgfXuc9U9pecI2pF9DbWNLycCqIMYBJXVx03yQwWX84z9EwMRpYVazqCnsE+I SBbK9POfUQRXZF7TMK/Zy7BZna7uocOlQhYNozQE= Date: Tue, 3 Nov 2020 13:13:29 +0000 From: Will Deacon To: Mark Rutland Subject: Re: [PATCH v4 4/4] arm64: lto: Strengthen READ_ONCE() to acquire when CONFIG_LTO=y Message-ID: <20201103131328.GC5219@willie-the-truck> References: <20201103121721.5166-1-will@kernel.org> <20201103121721.5166-5-will@kernel.org> <20201103125845.GD40454@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201103125845.GD40454@C02TD0UTHF1T.local> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201103_081335_491022_67AE94C1 X-CRM114-Status: GOOD ( 15.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kees Cook , Peter Zijlstra , Catalin Marinas , Masahiro Yamada , linux-kernel@vger.kernel.org, Sami Tolvanen , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 03, 2020 at 12:58:45PM +0000, Mark Rutland wrote: > On Tue, Nov 03, 2020 at 12:17:21PM +0000, Will Deacon wrote: > > When building with LTO, there is an increased risk of the compiler > > converting an address dependency headed by a READ_ONCE() invocation > > into a control dependency and consequently allowing for harmful > > reordering by the CPU. > > > > Ensure that such transformations are harmless by overriding the generic > > READ_ONCE() definition with one that provides acquire semantics when > > building with LTO. > > > > Acked-by: Peter Zijlstra (Intel) > > Signed-off-by: Will Deacon > > [...] > > Could we add a note above __READ_ONCE() along the lines of the commit > message, e.g. > > /* > * With LTO a compiler might convert an address dependency headed by a > * READ_ONCE() into a control dependency, allowing for harmful > * reordering by the CPU. > * > * To prevent this, upgrade READ_OONCE() to provide acquire semantics > * when building with LTO. It's not halloween any moooore :) But yes, I'll add something to that effect, cheers. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel