From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFE3DC2D0A3 for ; Tue, 3 Nov 2020 14:41:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2AECF2054F for ; Tue, 3 Nov 2020 14:41:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gjSEHRIe"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="tYRtCsCJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2AECF2054F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GlZaxRwHSTc1M4SKrMZP4+7q2FwUOwt42HOIyQ2h4lM=; b=gjSEHRIenzV+EephZpmOn2/hP o4EWxU4fyqW/mZYSVN3REldelhw0X+HGa70Q38uVcLikIiLHxlq/tmrEajZfoqgxYPyyVT4gbtNFk a9yp6cPKN/qXfM4JLgOUMraqexsfRrksTysJDQcogkx21OQaSH2YEe4ZpMi50LiWwDOyRgAj+lwEx JKqqDcdP7omnEjDiNOiM668QLTWdKjZGzE/z9RBaMMH9cOkWOXjLtnKoX31cJtzXlqQyUzuUoK3Ac og0OprYxQzCjoaX4gqMMik37tAEiaDU8PULv9BX7gjOBwUcDGYfh0R8aESlyrKkZVLzWaM/TmTmon Tk9ZiqtYQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZxT5-00006h-AP; Tue, 03 Nov 2020 14:39:27 +0000 Received: from mail-lj1-x243.google.com ([2a00:1450:4864:20::243]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZxSw-0008W0-6L for linux-arm-kernel@lists.infradead.org; Tue, 03 Nov 2020 14:39:20 +0000 Received: by mail-lj1-x243.google.com with SMTP id x6so19306291ljd.3 for ; Tue, 03 Nov 2020 06:39:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=M/CcLnAggfPJTPHCvJqAFAyQXrrFbGX8RqEWGTOIlRk=; b=tYRtCsCJ97u7yAlrOFN203Mpt9jz/EvbuW4V+3hipSUNsR5M8ZDqWsq7efoMiN9R5c nhVCnARjFr5alomHWUrG2S/QRxbOVwaEaiSQTgeF0uEgCJ7a2rbupEC/g2AUeshC9i6C wIKR126viYncqhHiZROMnSmO9imaid0rNJepyxM6rr8Apn+RPbJ3qWs7P+ZnHrSgvOWA QcXHZrEHzXM4SVCDzBK7zqXcUTu3T+G1dUvHRbLGUKs/I2DIfrL0bitkL+B4SCLYpFfX lHpCGqsodauH4LxSQSOtDBLKGW1a7DHfcCp5nbfeol5ZCBBoivuqpYvLjRQisIJ68BoF UMSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=M/CcLnAggfPJTPHCvJqAFAyQXrrFbGX8RqEWGTOIlRk=; b=cx4G5qzPF4V6MFmphOWjf4pgNN5MXNmVdmClqHdRt7uukFQd41du/SCFOakIrl8rqj biUSxnL+o1WpBREEvkwD5/Wfdn70dPpYDxZfzRcwK7sAT/IY9rvmdruTYX1c1pZM9Oe2 j7mZ0QGvRgUhEgXxKUwIFqdxtTlKhdeGDq/10tKTem1VEfhqf2F0ql9jbdMohdFmtDCQ kWtWLBX4+xBHshlyuBzSg/fHnNyjz6Cs4D5zp+wQF3xkNKHolrcAmwmRs+nPCB/qQEy2 Xwh21KCa0LIbiGdq5H1NZfBXTcr8+IBtNf8CCYI+1fPzC+M9siUU3I17TMJkF3jX6m+b Zzgg== X-Gm-Message-State: AOAM533+xyu75RyF4vb8M/nuAMyF2Wb/cyFEM6S9879Ui4ZlgA5U9pFG ui0ElQNUkNuUJML4CohuWeqrfw== X-Google-Smtp-Source: ABdhPJz+L8qrHCJkzOuQS8/wvO1dQM/ksNE/UzgTA6Cx0Ac2GRFSZ5fX6eoakfcdH0CZnI4/h7s3ng== X-Received: by 2002:a2e:879a:: with SMTP id n26mr9115208lji.347.1604414356208; Tue, 03 Nov 2020 06:39:16 -0800 (PST) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id g27sm4334360ljl.91.2020.11.03.06.39.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2020 06:39:15 -0800 (PST) Received: by box.localdomain (Postfix, from userid 1000) id 65F1510231C; Tue, 3 Nov 2020 17:39:16 +0300 (+03) Date: Tue, 3 Nov 2020 17:39:16 +0300 From: "Kirill A. Shutemov" To: Mike Rapoport Subject: Re: [PATCH v3 2/4] PM: hibernate: make direct map manipulations more explicit Message-ID: <20201103143916.otz2o4h2dlmewn3h@box> References: <20201101170815.9795-1-rppt@kernel.org> <20201101170815.9795-3-rppt@kernel.org> <20201103110816.t6a3ebtgcm7mfogy@box> <20201103121350.GI4879@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201103121350.GI4879@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201103_093918_459302_476FE89B X-CRM114-Status: GOOD ( 23.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Rafael J . Wysocki" , David Hildenbrand , Peter Zijlstra , Benjamin Herrenschmidt , Dave Hansen , linux-mm@kvack.org, Paul Mackerras , Pavel Machek , "H. Peter Anvin" , sparclinux@vger.kernel.org, Christoph Lameter , Will Deacon , linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, Michael Ellerman , x86@kernel.org, Mike Rapoport , Christian Borntraeger , Ingo Molnar , Catalin Marinas , Len Brown , Albert Ou , Vasily Gorbik , linux-pm@vger.kernel.org, Heiko Carstens , David Rientjes , Borislav Petkov , Andy Lutomirski , Paul Walmsley , Thomas Gleixner , Joonsoo Kim , linux-arm-kernel@lists.infradead.org, "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Pekka Enberg , Palmer Dabbelt , Andrew Morton , "Edgecombe, Rick P" , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 03, 2020 at 02:13:50PM +0200, Mike Rapoport wrote: > On Tue, Nov 03, 2020 at 02:08:16PM +0300, Kirill A. Shutemov wrote: > > On Sun, Nov 01, 2020 at 07:08:13PM +0200, Mike Rapoport wrote: > > > diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c > > > index 46b1804c1ddf..054c8cce4236 100644 > > > --- a/kernel/power/snapshot.c > > > +++ b/kernel/power/snapshot.c > > > @@ -76,6 +76,32 @@ static inline void hibernate_restore_protect_page(void *page_address) {} > > > static inline void hibernate_restore_unprotect_page(void *page_address) {} > > > #endif /* CONFIG_STRICT_KERNEL_RWX && CONFIG_ARCH_HAS_SET_MEMORY */ > > > > > > +static inline void hibernate_map_page(struct page *page, int enable) > > > +{ > > > + if (IS_ENABLED(CONFIG_ARCH_HAS_SET_DIRECT_MAP)) { > > > + unsigned long addr = (unsigned long)page_address(page); > > > + int ret; > > > + > > > + /* > > > + * This should not fail because remapping a page here means > > > + * that we only update protection bits in an existing PTE. > > > + * It is still worth to have WARN_ON() here if something > > > + * changes and this will no longer be the case. > > > + */ > > > + if (enable) > > > + ret = set_direct_map_default_noflush(page); > > > + else > > > + ret = set_direct_map_invalid_noflush(page); > > > + > > > + if (WARN_ON(ret)) > > > > _ONCE? > > I've changed it to pr_warn() after David said people enable panic on > warn in production kernels. pr_warn_once()? :P -- Kirill A. Shutemov _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel