From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA69FC2D0A3 for ; Tue, 3 Nov 2020 16:13:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D0FD223AB for ; Tue, 3 Nov 2020 16:13:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CRI8ntqs"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="M4I1V0JI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D0FD223AB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CS71mFHkQ4YopmJRnPMO94l7TwPqgDbvNd73RnStBY0=; b=CRI8ntqshpngG1K621rzl55xG bnis5ArHrwrVLm7gd2lyPghQBmP3Taj8qABjvHyz8RghX6uiGqucTFGP+hpq289JuZzBTZv3VNobQ fQrPGRS+qI3jgeZwJUBgwtdRRCdRN93AvQv1/8k/BYk2Sx6KVzzQkGWEI8GPwAXf15bKZIFFgqVDj HF2hV0wwWccNiKnqehZyQXC/gPOEoKLOSpjaexp8jBQndPaluU+HFRsygnRkUQ9BAjElohioAgQEU rbNmHUReB7D0tsTnLYjGXePy0/7pcCBdykyQQ0vGApy3UC0M+HTt5sBcVRalGIz0a905MoCDdguI3 2UdCm6kuw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZyvE-0005xE-FH; Tue, 03 Nov 2020 16:12:36 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZyvA-0005wB-Nb for linux-arm-kernel@lists.infradead.org; Tue, 03 Nov 2020 16:12:34 +0000 Received: by mail-pg1-x541.google.com with SMTP id x13so14024971pgp.7 for ; Tue, 03 Nov 2020 08:12:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=l1ro1Lxvrl7gs3AZydmjoaVsX0+iaNCcctscSnkcqnc=; b=M4I1V0JI8M9T9QZVAfPJ0Hya0JkBihCise1QUaNdIOipsmhywpCxPXK7Sk74GW/ICG dZVv0zCOTYnRn52uJLM8/OvNVou7mqHV0H9AFUWc8rmmgVrKRpSdRJNzQDiT16KR7FgT ny2EmeXN6anD+FvA8gzt0Dfv7U88Ggve+mFNSG3TTrmVedaTmdJOcX2e0Teh3x0j/Y7h dPuMZRYsGNPqXlbeddCop6E2wEu16hx8xa9K9c8HMNvBaybIfSuqFi9K84T+YjdIy6bO HHyfbeGEGaC6K0sAgSRf0RpcW+cL+lsHlFtwGYeu5wWALB7aPEYOTyY8F3ftgiu+mUnM R4hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=l1ro1Lxvrl7gs3AZydmjoaVsX0+iaNCcctscSnkcqnc=; b=lG5rlC6DNwNu6gGPbKkF26VHgC6GacgqDRKj5sup/uF4z4OpgektBX+rIdJHtV12wT R1nOARqLXo2Mc8JxOqHsyqDvOBff+HdijJQlcyxBbLRmUi+ZMqXvBasz80IkyAEeHRL7 y7+yyPl7EXzp0lGf9urQSy5U1e1kH8LmQ5OqPnAJT/uQCWgTQ6RPqH4jts27Y39/d0jF 63yc6xsYudsRMMYw1pwXqlrp69gbwbt9/KFfI+LkJNO5BQnHF6yvbhJWknJE4RGQFc+R sfwQC6krDWOsOnjWtk6JuhUyNplH9sHApbjWa+a9S+M7k7qIrNUs6pFygEzPqprxXLU+ nsIw== X-Gm-Message-State: AOAM531YsSiyNs4GupLq1lG09bdtvVIvTUItA4E2GKFV+T1nlDzvUzS+ RXwCxIWWH14HYEip1u4eMVkkNQ== X-Google-Smtp-Source: ABdhPJxvfv94PiWJ+DS1wTXAsJ/iZiU4YCpLmiB2EsmcJKEnuF6SZNX3Q5X9Kpc+cNmSARsc9GwQZg== X-Received: by 2002:a63:fb4a:: with SMTP id w10mr17269993pgj.285.1604419950333; Tue, 03 Nov 2020 08:12:30 -0800 (PST) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id y23sm3912228pju.35.2020.11.03.08.12.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2020 08:12:29 -0800 (PST) Date: Tue, 3 Nov 2020 09:12:27 -0700 From: Mathieu Poirier To: Qi Liu Subject: Re: [PATCH] coresight: Remove unnecessary THIS_MODULE of funnel and replicator driver Message-ID: <20201103161227.GA2852321@xps15> References: <1604409708-12400-1-git-send-email-liuqi115@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1604409708-12400-1-git-send-email-liuqi115@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201103_111233_064448_06C8C9C1 X-CRM114-Status: GOOD ( 19.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: suzuki.poulose@arm.com, coresight@lists.linaro.org, linuxarm@huawei.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 03, 2020 at 09:21:48PM +0800, Qi Liu wrote: > As THIS_MODULE has been set in platform_driver_register(), so remove it > from static funnel driver and static replicator driver to avoid set it > twice. > > Signed-off-by: Qi Liu > --- > drivers/hwtracing/coresight/coresight-funnel.c | 2 +- > drivers/hwtracing/coresight/coresight-replicator.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c > index af40814..39be46b 100644 > --- a/drivers/hwtracing/coresight/coresight-funnel.c > +++ b/drivers/hwtracing/coresight/coresight-funnel.c > @@ -356,7 +356,7 @@ static struct platform_driver static_funnel_driver = { > .remove = static_funnel_remove, > .driver = { > .name = "coresight-static-funnel", > - .owner = THIS_MODULE, > + /* THIS_MODULE is taken care of by platform_driver_register() */ > .of_match_table = static_funnel_match, > .acpi_match_table = ACPI_PTR(static_funnel_ids), > .pm = &funnel_dev_pm_ops, > diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c > index 62afdde..6772f23 100644 > --- a/drivers/hwtracing/coresight/coresight-replicator.c > +++ b/drivers/hwtracing/coresight/coresight-replicator.c > @@ -374,7 +374,7 @@ static struct platform_driver static_replicator_driver = { > .remove = static_replicator_remove, > .driver = { > .name = "coresight-static-replicator", > - .owner = THIS_MODULE, > + /* THIS_MODULE is taken care of by platform_driver_register() */ I have applied your patch. Next time please version you revisions. Thanks, Mathieu > .of_match_table = of_match_ptr(static_replicator_match), > .acpi_match_table = ACPI_PTR(static_replicator_acpi_ids), > .pm = &replicator_dev_pm_ops, > -- > 2.8.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel