[PATCH 0/5] Add Ethernet interface description for Odroid boards

[PATCH 0/5] Add Ethernet interface description for Odroid boards

[Łukasz Stelmach]

Add devicetree description of Ethernet devices on Odroid boards. These
descriptions enable setting MAC addresses with a bootloader.

Łukasz Stelmach (5):
  ARM: dts: exynos: Fix ethernet description for Odroid XU3
  ARM: dts: exynos: Add Ethernet interface description for Odroid X3
    Lite
  ARM: dts: exynos: Add Ethernet interface description for Odroid XU
  ARM: dts: exynos: Add Ethernet interface description for Odroid U3
  ARM: dts: exynos: Add Ethernet interface description for Odroid X/X2

 arch/arm/boot/dts/exynos4412-odroidu3.dts     | 12 ++++++++
 arch/arm/boot/dts/exynos4412-odroidx.dts      | 28 +++++++++++++++++++
 arch/arm/boot/dts/exynos5410-odroidxu.dts     | 15 ++++++++++
 .../boot/dts/exynos5422-odroidxu3-lite.dts    | 22 +++++++++++++++
 arch/arm/boot/dts/exynos5422-odroidxu3.dts    |  8 ++++--
 5 files changed, 83 insertions(+), 2 deletions(-)

-- 
2.26.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 1/5] ARM: dts: exynos: Fix ethernet description for Odroid XU3

[Łukasz Stelmach]

Create ethernet alias and assign appropriate compatible properties.

Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
---
 arch/arm/boot/dts/exynos5422-odroidxu3.dts | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index d0f6ac5fa79d..2a4153484664 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -15,6 +15,10 @@
 / {
 	model = "Hardkernel Odroid XU3";
 	compatible = "hardkernel,odroid-xu3", "samsung,exynos5800", "samsung,exynos5";
+
+	aliases {
+		ethernet = &ethernet;
+	};
 };
 
 &i2c_0 {
@@ -76,13 +80,13 @@ &usbhost2 {
 	#size-cells = <0>;
 
 	hub@1 {
-		compatible = "usb8087,0024";
+		compatible = "usb0424,9514";
 		reg = <1>;
 		#address-cells = <1>;
 		#size-cells = <0>;
 
 		ethernet: usbether@1 {
-			compatible = "usb0c45,6310";
+			compatible = "usb0424,ec00";
 			reg = <1>;
 			local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
 		};
-- 
2.26.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/5] ARM: dts: exynos: Fix ethernet description for Odroid XU3

[Krzysztof Kozlowski]

On Tue, Nov 03, 2020 at 01:46:14PM +0100, Łukasz Stelmach wrote:
> Create ethernet alias 

Your commit msg should explain why.


> and assign appropriate compatible properties.

Then what was before? Indeed they do not look like anything
reasonable... old VID do not appear on any of Odroid boards.

> 
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> ---

Best regards,
Krzysztof

>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> index d0f6ac5fa79d..2a4153484664 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> @@ -15,6 +15,10 @@
>  / {
>  	model = "Hardkernel Odroid XU3";
>  	compatible = "hardkernel,odroid-xu3", "samsung,exynos5800", "samsung,exynos5";
> +
> +	aliases {
> +		ethernet = &ethernet;
> +	};
>  };
>  
>  &i2c_0 {
> @@ -76,13 +80,13 @@ &usbhost2 {
>  	#size-cells = <0>;
>  
>  	hub@1 {
> -		compatible = "usb8087,0024";
> +		compatible = "usb0424,9514";
>  		reg = <1>;
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  
>  		ethernet: usbether@1 {
> -			compatible = "usb0c45,6310";
> +			compatible = "usb0424,ec00";
>  			reg = <1>;
>  			local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
>  		};
> -- 
> 2.26.2
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/5] ARM: dts: exynos: Fix ethernet description for Odroid XU3

[Lukasz Stelmach]

[-- Attachment #1.1: Type: text/plain, Size: 2001 bytes --]

It was <2020-11-03 wto 17:36>, when Krzysztof Kozlowski wrote:
> On Tue, Nov 03, 2020 at 01:46:14PM +0100, Łukasz Stelmach wrote:
>> Create ethernet alias 
>
> Your commit msg should explain why.
>

OK. (And a separate patch - ack)

>> and assign appropriate compatible properties.
>
> Then what was before? Indeed they do not look like anything
> reasonable... old VID do not appear on any of Odroid boards.
>

The first is acutally an Intel hub, the second is a webcam. Where did
I found them? I can't be sure today.

In case of USB devices the kernel uses topology information to match
devices instead of compatible properties and u-boot uses
aliases. Therefore, bad IDs don't break anything.

>> 
>> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
>> ---
>
> Best regards,
> Krzysztof
>
>>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 8 ++++++--
>>  1 file changed, 6 insertions(+), 2 deletions(-)
>> 
>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> index d0f6ac5fa79d..2a4153484664 100644
>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> @@ -15,6 +15,10 @@
>>  / {
>>  	model = "Hardkernel Odroid XU3";
>>  	compatible = "hardkernel,odroid-xu3", "samsung,exynos5800", "samsung,exynos5";
>> +
>> +	aliases {
>> +		ethernet = &ethernet;
>> +	};
>>  };
>>  
>>  &i2c_0 {
>> @@ -76,13 +80,13 @@ &usbhost2 {
>>  	#size-cells = <0>;
>>  
>>  	hub@1 {
>> -		compatible = "usb8087,0024";
>> +		compatible = "usb0424,9514";
>>  		reg = <1>;
>>  		#address-cells = <1>;
>>  		#size-cells = <0>;
>>  
>>  		ethernet: usbether@1 {
>> -			compatible = "usb0c45,6310";
>> +			compatible = "usb0424,ec00";
>>  			reg = <1>;
>>  			local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
>>  		};
>> -- 
>> 2.26.2
>> 
>
>

-- 
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/5] ARM: dts: exynos: Fix ethernet description for Odroid XU3

[Krzysztof Kozlowski]

On Tue, Nov 03, 2020 at 01:46:14PM +0100, Łukasz Stelmach wrote:
> Create ethernet alias and assign appropriate compatible properties.
> 
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> index d0f6ac5fa79d..2a4153484664 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> @@ -15,6 +15,10 @@
>  / {
>  	model = "Hardkernel Odroid XU3";
>  	compatible = "hardkernel,odroid-xu3", "samsung,exynos5800", "samsung,exynos5";
> +
> +	aliases {
> +		ethernet = &ethernet;

Ahh, and one more thing - these are two separate issues to fix, so two
patches.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 2/5] ARM: dts: exynos: Add Ethernet interface description for Odroid X3 Lite

[Łukasz Stelmach]

Add Ethernet interface description for Odroid X3 Lite.

Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
---
 .../boot/dts/exynos5422-odroidxu3-lite.dts    | 22 +++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts b/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts
index 98feecad5489..62c5928aa994 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts
@@ -16,6 +16,10 @@
 / {
 	model = "Hardkernel Odroid XU3 Lite";
 	compatible = "hardkernel,odroid-xu3-lite", "samsung,exynos5800", "samsung,exynos5";
+
+	aliases {
+		ethernet = &ethernet;
+	};
 };
 
 &arm_a7_pmu {
@@ -103,3 +107,21 @@ &pwm {
 &usbdrd_dwc3_1 {
 	dr_mode = "peripheral";
 };
+
+&usbhost2 {
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	hub@1 {
+		compatible = "usb0424,9514";
+		reg = <1>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		ethernet: usbether@1 {
+			compatible = "usb0424,ec00";
+			reg = <1>;
+			local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
+		};
+	};
+};
-- 
2.26.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 2/5] ARM: dts: exynos: Add Ethernet interface description for Odroid X3 Lite

[Krzysztof Kozlowski]

On Tue, Nov 03, 2020 at 01:46:15PM +0100, Łukasz Stelmach wrote:
> Add Ethernet interface description for Odroid X3 Lite.

Odroid XU3 Lite.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 3/5] ARM: dts: exynos: Add Ethernet interface description for Odroid XU

[Łukasz Stelmach]

Add Ethernet interface description for Odroid XU.

Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
---
 arch/arm/boot/dts/exynos5410-odroidxu.dts | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts
index 75b4150c26d7..882d9296fa5d 100644
--- a/arch/arm/boot/dts/exynos5410-odroidxu.dts
+++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
@@ -19,6 +19,10 @@ / {
 	model = "Hardkernel Odroid XU";
 	compatible = "hardkernel,odroid-xu", "samsung,exynos5410", "samsung,exynos5";
 
+	aliases {
+		ethernet = &ethernet;
+	};
+
 	memory@40000000 {
 		device_type = "memory";
 		reg = <0x40000000 0x7ea00000>;
@@ -653,3 +657,14 @@ &usbdrd3_1 {
 	vdd33-supply = <&ldo12_reg>;
 	vdd10-supply = <&ldo15_reg>;
 };
+
+&usbhost2 {
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	ethernet: usbether@2 {
+		compatible = "usb0424,9730";
+		reg = <2>;
+		local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
+	};
+};
-- 
2.26.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 3/5] ARM: dts: exynos: Add Ethernet interface description for Odroid XU

[Krzysztof Kozlowski]

On Tue, Nov 03, 2020 at 01:46:16PM +0100, Łukasz Stelmach wrote:
> Add Ethernet interface description for Odroid XU.
> 
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5410-odroidxu.dts | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts
> index 75b4150c26d7..882d9296fa5d 100644
> --- a/arch/arm/boot/dts/exynos5410-odroidxu.dts
> +++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
> @@ -19,6 +19,10 @@ / {
>  	model = "Hardkernel Odroid XU";
>  	compatible = "hardkernel,odroid-xu", "samsung,exynos5410", "samsung,exynos5";
>  
> +	aliases {
> +		ethernet = &ethernet;

Just like with patch 1/5 - please explain in commit msg why do you need
this.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 4/5] ARM: dts: exynos: Add Ethernet interface description for Odroid U3

[Łukasz Stelmach]

Add Ethernet interface description for Odroid U3.

Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
---
 arch/arm/boot/dts/exynos4412-odroidu3.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts
index b8549d846f86..b503f04db923 100644
--- a/arch/arm/boot/dts/exynos4412-odroidu3.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts
@@ -16,6 +16,10 @@ / {
 	model = "Hardkernel ODROID-U3 board based on Exynos4412";
 	compatible = "hardkernel,odroid-u3", "samsung,exynos4412", "samsung,exynos4";
 
+	aliases {
+		ethernet = &ethernet;
+	};
+
 	memory@40000000 {
 		device_type = "memory";
 		reg = <0x40000000 0x7FF00000>;
@@ -101,8 +105,16 @@ &usb3503 {
 };
 
 &ehci {
+	#address-cells = <1>;
+	#size-cells = <0>;
 	phys = <&exynos_usbphy 2>, <&exynos_usbphy 3>;
 	phy-names = "hsic0", "hsic1";
+
+	ethernet: usbether@2 {
+		compatible = "usb0424,9730";
+		reg = <2>;
+		local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
+	};
 };
 
 &sound {
-- 
2.26.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 5/5] ARM: dts: exynos: Add Ethernet interface description for Odroid X/X2

[Łukasz Stelmach]

Add Ethernet interface description for Odroid X/X2.

Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
---
 arch/arm/boot/dts/exynos4412-odroidx.dts | 28 ++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
index 3ea2a0101e80..8f154f431f6c 100644
--- a/arch/arm/boot/dts/exynos4412-odroidx.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
@@ -15,6 +15,10 @@ / {
 	model = "Hardkernel ODROID-X board based on Exynos4412";
 	compatible = "hardkernel,odroid-x", "samsung,exynos4412", "samsung,exynos4";
 
+	aliases {
+		ethernet = &ethernet;
+	};
+
 	memory@40000000 {
 		device_type = "memory";
 		reg = <0x40000000 0x3FF00000>;
@@ -72,8 +76,32 @@ &buck8_reg {
 };
 
 &ehci {
+	#address-cells = <1>;
+	#size-cells = <0>;
 	phys = <&exynos_usbphy 2>;
 	phy-names = "hsic0";
+
+	hub@2 {
+		compatible = "usb0424,3503";
+		reg = <2>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		hub@1 {
+			compatible = "usb0424:9514";
+			reg = <1>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			ethernet: usbether@1 {
+				compatible = "usb0424,ec00";
+				reg = <1>;
+				local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
+			};
+		};
+	};
+
+
 };
 
 &mshc_0 {
-- 
2.26.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 5/5] ARM: dts: exynos: Add Ethernet interface description for Odroid X/X2

[Krzysztof Kozlowski]

On Tue, Nov 03, 2020 at 01:46:18PM +0100, Łukasz Stelmach wrote:
> Add Ethernet interface description for Odroid X/X2.
> 
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> ---
>  arch/arm/boot/dts/exynos4412-odroidx.dts | 28 ++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
> index 3ea2a0101e80..8f154f431f6c 100644
> --- a/arch/arm/boot/dts/exynos4412-odroidx.dts
> +++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
> @@ -15,6 +15,10 @@ / {
>  	model = "Hardkernel ODROID-X board based on Exynos4412";
>  	compatible = "hardkernel,odroid-x", "samsung,exynos4412", "samsung,exynos4";
>  
> +	aliases {
> +		ethernet = &ethernet;
> +	};
> +
>  	memory@40000000 {
>  		device_type = "memory";
>  		reg = <0x40000000 0x3FF00000>;
> @@ -72,8 +76,32 @@ &buck8_reg {
>  };
>  
>  &ehci {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
>  	phys = <&exynos_usbphy 2>;
>  	phy-names = "hsic0";
> +
> +	hub@2 {
> +		compatible = "usb0424,3503";
> +		reg = <2>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		hub@1 {
> +			compatible = "usb0424:9514";

Does not look like correct compatible.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 5/5] ARM: dts: exynos: Add Ethernet interface description for Odroid X/X2

[Lukasz Stelmach]

[-- Attachment #1.1: Type: text/plain, Size: 2396 bytes --]

It was <2020-11-03 wto 17:44>, when Krzysztof Kozlowski wrote:
> On Tue, Nov 03, 2020 at 01:46:18PM +0100, Łukasz Stelmach wrote:
>> Add Ethernet interface description for Odroid X/X2.
>> 
>> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos4412-odroidx.dts | 28 ++++++++++++++++++++++++
>>  1 file changed, 28 insertions(+)
>> 
>> diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
>> index 3ea2a0101e80..8f154f431f6c 100644
>> --- a/arch/arm/boot/dts/exynos4412-odroidx.dts
>> +++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
>> @@ -15,6 +15,10 @@ / {
>>  	model = "Hardkernel ODROID-X board based on Exynos4412";
>>  	compatible = "hardkernel,odroid-x", "samsung,exynos4412", "samsung,exynos4";
>>  
>> +	aliases {
>> +		ethernet = &ethernet;
>> +	};
>> +
>>  	memory@40000000 {
>>  		device_type = "memory";
>>  		reg = <0x40000000 0x3FF00000>;
>> @@ -72,8 +76,32 @@ &buck8_reg {
>>  };
>>  
>>  &ehci {
>> +	#address-cells = <1>;
>> +	#size-cells = <0>;
>>  	phys = <&exynos_usbphy 2>;
>>  	phy-names = "hsic0";
>> +
>> +	hub@2 {
>> +		compatible = "usb0424,3503";
>> +		reg = <2>;
>> +		#address-cells = <1>;
>> +		#size-cells = <0>;
>> +
>> +		hub@1 {
>> +			compatible = "usb0424:9514";
>
> Does not look like correct compatible.

As odd as it may seem (and considering my mistakes) this is correct.

--8<---------------cut here---------------start------------->8---
root@target:~# cat /proc/device-tree/compatible ; echo
hardkernel,odroid-x2samsung,exynos4412samsung,exynos4
root@target:~# lsusb -t
/:  Bus 01.Port 1: Dev 1, Class=root_hub, Driver=exynos-ehci/3p, 480M
    |__ Port 2: Dev 2, If 0, Class=Hub, Driver=hub/3p, 480M
        |__ Port 1: Dev 3, If 0, Class=Hub, Driver=hub/5p, 480M
            |__ Port 1: Dev 4, If 0, Class=Vendor Specific Class, Driver=smsc95xx, 480M
root@target:~# lsusb
Bus 001 Device 004: ID 0424:ec00 Standard Microsystems Corp. SMSC9512/9514 Fast Ethernet Adapter
Bus 001 Device 003: ID 0424:9514 Standard Microsystems Corp. SMC9514 Hub
Bus 001 Device 002: ID 0424:3503 Standard Microsystems Corp. 
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
--8<---------------cut here---------------end--------------->8---

-- 
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 5/5] ARM: dts: exynos: Add Ethernet interface description for Odroid X/X2

[Krzysztof Kozlowski]

On Tue, 3 Nov 2020 at 18:13, Lukasz Stelmach <l.stelmach@samsung.com> wrote:
>
> It was <2020-11-03 wto 17:44>, when Krzysztof Kozlowski wrote:
> > On Tue, Nov 03, 2020 at 01:46:18PM +0100, Łukasz Stelmach wrote:
> >> Add Ethernet interface description for Odroid X/X2.
> >>
> >> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> >> ---
> >>  arch/arm/boot/dts/exynos4412-odroidx.dts | 28 ++++++++++++++++++++++++
> >>  1 file changed, 28 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
> >> index 3ea2a0101e80..8f154f431f6c 100644
> >> --- a/arch/arm/boot/dts/exynos4412-odroidx.dts
> >> +++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
> >> @@ -15,6 +15,10 @@ / {
> >>      model = "Hardkernel ODROID-X board based on Exynos4412";
> >>      compatible = "hardkernel,odroid-x", "samsung,exynos4412", "samsung,exynos4";
> >>
> >> +    aliases {
> >> +            ethernet = &ethernet;
> >> +    };
> >> +
> >>      memory@40000000 {
> >>              device_type = "memory";
> >>              reg = <0x40000000 0x3FF00000>;
> >> @@ -72,8 +76,32 @@ &buck8_reg {
> >>  };
> >>
> >>  &ehci {
> >> +    #address-cells = <1>;
> >> +    #size-cells = <0>;
> >>      phys = <&exynos_usbphy 2>;
> >>      phy-names = "hsic0";
> >> +
> >> +    hub@2 {
> >> +            compatible = "usb0424,3503";
> >> +            reg = <2>;
> >> +            #address-cells = <1>;
> >> +            #size-cells = <0>;
> >> +
> >> +            hub@1 {
> >> +                    compatible = "usb0424:9514";
> >
> > Does not look like correct compatible.
>
> As odd as it may seem (and considering my mistakes) this is correct.

Not the numbers, the format. Comma is needed.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel