From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6361C2D0A3 for ; Tue, 3 Nov 2020 19:03:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CE3A2074B for ; Tue, 3 Nov 2020 19:03:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Pt4fPxMV"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tYTtG07F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CE3A2074B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=91SrwkhJcS4yId5J430JUOd924WVvGG4W/WxXwAIwcc=; b=Pt4fPxMV2qQIcs/UD3gU66HT7 nchYTTefCOiUaF7DSkewjx/PRZ2OCYpcXeRrwCIvgpyvT7H5RG5iyDRI2zKOPf6BA9S2lnLBZGhSv tYCPLszWd33QgQnmbvQd7TvvCwQz/nId7NZu02ktN+NJC8G/hzd4+fD0rwoAykaYhQcDoBCKPD1zr j16gpWQgRPLMQeY5ayD4Ql57iEgjMkcxBG+9ipPrtM+iqbX3Mv/nNyQrPw7C5PzpzVQOpzshpf6Tq 4hJ4L1ZY2pocisGF+GWIdFd2qCxrakmu0p0bjcIsTT8j3S/WBoYeZhsEJFBGHlfdeDxJvvjBgb9tJ hXUwTnqSw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ka1aK-0004Dk-Es; Tue, 03 Nov 2020 19:03:12 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ka1aH-0004Cp-FY for linux-arm-kernel@lists.infradead.org; Tue, 03 Nov 2020 19:03:10 +0000 Received: by mail-pf1-x441.google.com with SMTP id c20so15069942pfr.8 for ; Tue, 03 Nov 2020 11:03:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=e1MCrAKSHlV5HoEC6LZZ/5ih1567h/RI8mH7ZIf3CyE=; b=tYTtG07FanUbjPGNSIIErFGjf4TN/6g2Btl5CJXOXHj5H6TAO8s/NOltPuvMTBPEPI jUVn5W6jGc88sU0JqAa0nbqz74ERcgSZftm8CIPZOemeQxjXGLrrHYIyzWVZEoPw6A/p tYyqzOLHiPWyXoupVJ2F1W01z4ovqLTvkxn6VMoNmafyYAU2CvtqFe/2QxlITv2qdT3i Dqv3yQlhD4fmqkOaNF3iyp0Zt+r8ynlhjXFtSFHVu9hT2xFJoLH84RqHFMu4BzAed8fA n+wL6qg6GkuWSUR82rQFk56hMG4+mSlSK9qUdtNRi4QRJloZP2auz6Vyy8ROLxgreyYl VgwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=e1MCrAKSHlV5HoEC6LZZ/5ih1567h/RI8mH7ZIf3CyE=; b=i9Wg/SYEWZuZPCpGwGziJyGxUfB5xsqms+XrkCQWdDw18LG399AH/WxCWj0343wjgK Wt7LyckQ5o15891qHaDPx2dfb1vFe5lh7/wFN+LrP5ShQLlyQ9yUvoHYwuzu/1CyAdUc 8r5gAs9GfUvqZj+oSmdJBKZ1OgScglYAOWV7l0ZmB27cpTzyoVO+LptKZWSINcp7ANcG UZikW8fs//m1j0GVqzn2aRbc8vSa36Zk+UhlYBfz4xNS018tqbXHxQBKqTql4B8TINnO KdQDDBRXnFu9z5XAVLLwHA3pbfusCFOU1JnRXrBH6+pX8MbvHTwcJe+40o4+Sx5pvisH A7Ng== X-Gm-Message-State: AOAM531I82FF2F9t0W0KpBxtACGQWmACUvGrNm0RLEL3fnKbXecaKzPe dB0gwXwqdH/oOAXOuW5cNMCVyA== X-Google-Smtp-Source: ABdhPJxXNtyp//WsG6sYBVzaUsGW2R1ZAdaoPmSUiqfAjZIUj9oVlLFm3S2avsp6ih93kcL/YpqZbQ== X-Received: by 2002:a65:52cb:: with SMTP id z11mr17726118pgp.368.1604430187148; Tue, 03 Nov 2020 11:03:07 -0800 (PST) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id e22sm3585340pjh.45.2020.11.03.11.03.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2020 11:03:06 -0800 (PST) Date: Tue, 3 Nov 2020 12:03:04 -0700 From: Mathieu Poirier To: Suzuki K Poulose Subject: Re: [PATCH v3 13/26] coresight: etm4x: Add commentary on the registers Message-ID: <20201103190304.GF2855763@xps15> References: <20201028220945.3826358-1-suzuki.poulose@arm.com> <20201028220945.3826358-15-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201028220945.3826358-15-suzuki.poulose@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201103_140309_788603_65FED34A X-CRM114-Status: GOOD ( 18.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: coresight@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 28, 2020 at 10:09:32PM +0000, Suzuki K Poulose wrote: > As we are about define a switch..case table for individual register > access by offset for implementing the system instruction support, > document the possible set of registers for each group to make > it easier to co-relate. > > Cc: Mathieu Poirier > Cc: Mike Leach > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-etm4x.h | 21 ++++++++++++------- > 1 file changed, 13 insertions(+), 8 deletions(-) Reviewed-by: Mathieu Poirier I'm done for today and will continue tomorrow. Thanks, Mathieu > > diff --git a/drivers/hwtracing/coresight/coresight-etm4x.h b/drivers/hwtracing/coresight/coresight-etm4x.h > index 14e0f29db6b3..510828c73db6 100644 > --- a/drivers/hwtracing/coresight/coresight-etm4x.h > +++ b/drivers/hwtracing/coresight/coresight-etm4x.h > @@ -44,13 +44,13 @@ > #define TRCVDSACCTLR 0x0A4 > #define TRCVDARCCTLR 0x0A8 > /* Derived resources registers */ > -#define TRCSEQEVRn(n) (0x100 + (n * 4)) > +#define TRCSEQEVRn(n) (0x100 + (n * 4)) /* n = 0-2 */ > #define TRCSEQRSTEVR 0x118 > #define TRCSEQSTR 0x11C > #define TRCEXTINSELR 0x120 > -#define TRCCNTRLDVRn(n) (0x140 + (n * 4)) > -#define TRCCNTCTLRn(n) (0x150 + (n * 4)) > -#define TRCCNTVRn(n) (0x160 + (n * 4)) > +#define TRCCNTRLDVRn(n) (0x140 + (n * 4)) /* n = 0-3 */ > +#define TRCCNTCTLRn(n) (0x150 + (n * 4)) /* n = 0-3 */ > +#define TRCCNTVRn(n) (0x160 + (n * 4)) /* n = 0-3 */ > /* ID registers */ > #define TRCIDR8 0x180 > #define TRCIDR9 0x184 > @@ -59,7 +59,7 @@ > #define TRCIDR12 0x190 > #define TRCIDR13 0x194 > #define TRCIMSPEC0 0x1C0 > -#define TRCIMSPECn(n) (0x1C0 + (n * 4)) > +#define TRCIMSPECn(n) (0x1C0 + (n * 4)) /* n = 1-7 */ > #define TRCIDR0 0x1E0 > #define TRCIDR1 0x1E4 > #define TRCIDR2 0x1E8 > @@ -68,9 +68,12 @@ > #define TRCIDR5 0x1F4 > #define TRCIDR6 0x1F8 > #define TRCIDR7 0x1FC > -/* Resource selection registers */ > +/* > + * Resource selection registers, n = 2-31. > + * First pair (regs 0, 1) is always present and is reserved. > + */ > #define TRCRSCTLRn(n) (0x200 + (n * 4)) > -/* Single-shot comparator registers */ > +/* Single-shot comparator registers, n = 0-7 */ > #define TRCSSCCRn(n) (0x280 + (n * 4)) > #define TRCSSCSRn(n) (0x2A0 + (n * 4)) > #define TRCSSPCICRn(n) (0x2C0 + (n * 4)) > @@ -80,11 +83,13 @@ > #define TRCPDCR 0x310 > #define TRCPDSR 0x314 > /* Trace registers (0x318-0xEFC) */ > -/* Comparator registers */ > +/* Address Comparator registers n = 0-15 */ > #define TRCACVRn(n) (0x400 + (n * 8)) > #define TRCACATRn(n) (0x480 + (n * 8)) > +/* Data Value Comparator Value registers, n = 0-7 */ > #define TRCDVCVRn(n) (0x500 + (n * 16)) > #define TRCDVCMRn(n) (0x580 + (n * 16)) > +/* ContextID/Virtual ContextID comparators, n = 0-7 */ > #define TRCCIDCVRn(n) (0x600 + (n * 8)) > #define TRCVMIDCVRn(n) (0x640 + (n * 8)) > #define TRCCIDCCTLR0 0x680 > -- > 2.24.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel