From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0860BC2D0A3 for ; Wed, 4 Nov 2020 02:44:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A34642236F for ; Wed, 4 Nov 2020 02:44:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mezoyyhW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A34642236F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=61+aSLz9uniDrv+hEediv1qu0etBjxPiazsTBn6jhm8=; b=mezoyyhWde5GX/bIuvHBFwFNB CxDGfHKVWTF/riaw8deCN/r3G4JuOsJ5h+KMygXw1LGyL8Uk73X8ktCIovoKNORrkihKZz4dfkKOy jmelGXubAcguiNkZKrNFU4ghxWoiy1zW+ldCzXgtshoGWmBaLIEeSh3lSsWeymI1yDTAe4nIHMwtH yyn/F7YmD7I5vTagIRqfOid4E4FFD2qhyAfCRnVwuXsZT4uFYF3DhBL1ZzQmirJUyBDnbdB+B86uF DHg8Eo/cz4bmhuqaxokYA3OKKTlNyWEWXSa9X7zJvhLmKogrCglFoUeHQ2oikyMNzkTFOF2lJJf0z mbWjLjqcw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ka8kj-0005GX-0F; Wed, 04 Nov 2020 02:42:25 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ka8kg-0005F3-Jb for linux-arm-kernel@lists.infradead.org; Wed, 04 Nov 2020 02:42:23 +0000 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1ka8kV-0058ru-C2; Wed, 04 Nov 2020 03:42:11 +0100 Date: Wed, 4 Nov 2020 03:42:11 +0100 From: Andrew Lunn To: =?utf-8?Q?=C5=81ukasz?= Stelmach Subject: Re: [PATCH v5 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver Message-ID: <20201104024211.GS933237@lunn.ch> References: <20201103151536.26472-1-l.stelmach@samsung.com> <20201103151536.26472-4-l.stelmach@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201103151536.26472-4-l.stelmach@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201103_214222_745710_848E7B8E X-CRM114-Status: GOOD ( 14.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, =?utf-8?Q?Bart=C5=82omiej_=C5=BBolnierkiewicz?= , jim.cromie@gmail.com, netdev@vger.kernel.org, Russell King , Rob Herring , linux-kernel@vger.kernel.org, Kukjin Kim , Krzysztof Kozlowski , Jakub Kicinski , Marek Szyprowski , "David S. Miller" , linux-arm-kernel@lists.infradead.org, Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > +config SPI_AX88796C_COMPRESSION > + bool "SPI transfer compression" > + default n > + depends on SPI_AX88796C > + help > + Say Y here to enable SPI transfer compression. It saves up > + to 24 dummy cycles during each transfer which may noticably > + speed up short transfers. This sets the default value that is > + inherited by network interfecase during probe. It can be interface > + changed in run time via spi-compression ethtool tunable. changed _at_ run time... > +static int > +ax88796c_set_tunable(struct net_device *ndev, const struct ethtool_tunable *tuna, > + const void *data) > +{ > + struct ax88796c_device *ax_local = to_ax88796c_device(ndev); > + > + switch (tuna->id) { > + case ETHTOOL_SPI_COMPRESSION: > + if (netif_running(ndev)) > + return -EBUSY; > + ax_local->capabilities &= ~AX_CAP_COMP; > + ax_local->capabilities |= *(u32 *)data ? AX_CAP_COMP : 0; You should probably validate here that data is 0 or 1. That is what ax88796c_get_tunable() will return. It seems like this controls two hardware bits: SPICR_RCEN | SPICR_QCEN Maybe at some point it would make sense to allow these bits to be set individually? If you never validate the tunable, you cannot make use of other values to control the bits individually. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel