From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13D9FC5517A for ; Wed, 4 Nov 2020 10:38:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E53E21734 for ; Wed, 4 Nov 2020 10:38:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ze1wBEhs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E53E21734 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FU1peVMH3O/auQ3oThWVAo9LMPyTDqrZLqfoPU3C74Q=; b=Ze1wBEhs4OAoVF0M7Zy3FOk6B a0WkMyawysKt8ROSLgsVSn1PxdYdzo6uCoTiWuhA1pD8ZD5skYAkGhSVY6ceC/UrYfGfltbQRsjIn q9vAts9phW8Uvm0W4RUklR2oQ6d1fI0OxZ5yOehIfE+db8VYURyfo1DAzNbob+UJBdnFPgULwHoH6 G03jHmbnJoZyoETqCnB4Oo+gSAbb+yFmjssByWGuMfQn/DowxckD4e6K5hOeF05ICN2gz1L+SkoNZ mVWc/UCdtxycEIWXpaN7/8N6qaNq7Hi9m7H7vE5lmqZiipAcgaroP4/PS0Dnzw6TobBlPmptoXinE d2+ep7kyw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaGAo-0001wT-Tq; Wed, 04 Nov 2020 10:37:51 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaGAc-0001oy-8I for linux-arm-kernel@lists.infradead.org; Wed, 04 Nov 2020 10:37:39 +0000 X-Originating-IP: 93.29.109.196 Received: from aptenodytes (196.109.29.93.rev.sfr.net [93.29.109.196]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 42D764000A; Wed, 4 Nov 2020 10:37:32 +0000 (UTC) Date: Wed, 4 Nov 2020 11:37:31 +0100 From: Paul Kocialkowski To: Maxime Ripard Subject: Re: [PATCH 12/14] media: sunxi: Add support for the A83T MIPI CSI-2 controller Message-ID: <20201104103731.GC285779@aptenodytes> References: <20201023174546.504028-1-paul.kocialkowski@bootlin.com> <20201023174546.504028-13-paul.kocialkowski@bootlin.com> <20201026170041.qsjzxlurufuuhcsq@gilmour.lan> MIME-Version: 1.0 In-Reply-To: <20201026170041.qsjzxlurufuuhcsq@gilmour.lan> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201104_053738_718727_FD9CF9E2 X-CRM114-Status: GOOD ( 25.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org, Philipp Zabel , Kishon Vijay Abraham I , Thomas Petazzoni , Greg Kroah-Hartman , Helen Koike , linux-kernel@vger.kernel.org, Chen-Yu Tsai , Hans Verkuil , linux-sunxi@googlegroups.com, Rob Herring , Vinod Koul , Yong Deng , Sakari Ailus , Hans Verkuil , Mauro Carvalho Chehab , kevin.lhopital@hotmail.com, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: multipart/mixed; boundary="===============5812505849155507159==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5812505849155507159== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KN5l+BnMqAQyZLvT" Content-Disposition: inline --KN5l+BnMqAQyZLvT Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon 26 Oct 20, 18:00, Maxime Ripard wrote: > On Fri, Oct 23, 2020 at 07:45:44PM +0200, Paul Kocialkowski wrote: > > The A83T supports MIPI CSI-2 with a composite controller, covering both= the > > protocol logic and the D-PHY implementation. This controller seems to b= e found > > on the A83T only and probably was abandonned since. > >=20 > > This implementation splits the protocol and D-PHY registers and uses th= e PHY > > framework internally. The D-PHY is not registered as a standalone PHY d= river > > since it cannot be used with any other controller. > >=20 > > There are a few notable points about the controller: > > - The initialisation sequence involes writing specific magic init value= s that > > do not seem to make any particular sense given the concerned register= fields. > > - Interrupts appear to be hitting regardless of the interrupt mask regi= sters, > > which can cause a serious flood when transmission errors occur. >=20 > Ah, so it's a separate driver too. >=20 > > This work is based on the first version of the driver submitted by > > K=C3=A9vin L'h=C3=B4pital, which was adapted to mainline from the Allwi= nner BSP. > > This version integrates MIPI CSI-2 support as a standalone V4L2 subdev > > instead of merging it in the sun6i-csi driver. > >=20 > > It was tested on a Banana Pi M3 board with an OV8865 sensor in a 4-lane > > configuration. >=20 > Co-developped-by and SoB from Kevin? Not really. I wrote this driver from scratch and even significantly reworked the register descriptions to the point that I don't think it makes sense to consider that he's an author. For parts that can be considered a derivative work, copyright attribution was given in the header. Cheers, Paul > Looking at the driver, the same comments from the v3s apply there >=20 > Maxime --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --KN5l+BnMqAQyZLvT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAl+ihGcACgkQ3cLmz3+f v9HKqAf+OuoO0165XskKVuTp2nDVtSSL8D+0v2Fji8v+foCHk2qq8v2otrqY5Ey+ ptEefRqzPa/VFRm5ZShzliEzeFK1vE+0/NE/n9QU4KdkhNUNnMGUIYGtEIvQr+Qo QOqecdSX0SR0qy/CMHbuNQJRRSzZ1AkYjq6g/023m3VMUOvGajq+2cwWYpYE0SC/ Ngjd/deVC3yvosBdjwUfzyB2zj6pNOM8PQrUnIpiO2pBsZcXqqQ4QgLmi1UgtSrz RsTW9bMwsz7IRyogs4dCrb6s3ooCuK+Ox3v7bqng99Eqe/n6oIveLzRNS5QnlKMa rDjvmpkshuvTgPMU/kQlaGL1k20Lxw== =i052 -----END PGP SIGNATURE----- --KN5l+BnMqAQyZLvT-- --===============5812505849155507159== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5812505849155507159==--