From: Andrew Lunn <andrew@lunn.ch>
To: Lukasz Stelmach <l.stelmach@samsung.com>
Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
"Bartłomiej Żolnierkiewicz" <b.zolnierkie@samsung.com>,
jim.cromie@gmail.com, netdev@vger.kernel.org,
"Russell King" <linux@armlinux.org.uk>,
"Rob Herring" <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org, "Kukjin Kim" <kgene@kernel.org>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Jakub Kicinski" <kuba@kernel.org>,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
"David S. Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org,
"Heiner Kallweit" <hkallweit1@gmail.com>
Subject: Re: [PATCH v5 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver
Date: Wed, 4 Nov 2020 14:02:12 +0100 [thread overview]
Message-ID: <20201104130212.GU933237@lunn.ch> (raw)
In-Reply-To: <dleftj361ps9sa.fsf%l.stelmach@samsung.com>
> >> +static int
> >> +ax88796c_set_tunable(struct net_device *ndev, const struct ethtool_tunable *tuna,
> >> + const void *data)
> >> +{
> >> + struct ax88796c_device *ax_local = to_ax88796c_device(ndev);
> >> +
> >> + switch (tuna->id) {
> >> + case ETHTOOL_SPI_COMPRESSION:
> >> + if (netif_running(ndev))
> >> + return -EBUSY;
> >> + ax_local->capabilities &= ~AX_CAP_COMP;
> >> + ax_local->capabilities |= *(u32 *)data ? AX_CAP_COMP : 0;
> >
> > You should probably validate here that data is 0 or 1. That is what
> > ax88796c_get_tunable() will return.
> >
> > It seems like this controls two hardware bits:
> >
> > SPICR_RCEN | SPICR_QCEN
> >
> > Maybe at some point it would make sense to allow these bits to be set
> > individually? If you never validate the tunable, you cannot make use
> > of other values to control the bits individually.
>
> Good point. What is your recommendation for the userland facing
> interface, so that future changes will be least disruptive?
I would KISS and just validate data is 0 or 1, and leave it at that.
That then later gives you the option to have other values, if that is
ever interesting.
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-04 13:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20201103151538eucas1p2682c895caedc83638c9a99e7f307e42b@eucas1p2.samsung.com>
2020-11-03 15:15 ` [PATCH v5 0/5] AX88796C SPI Ethernet Adapter Łukasz Stelmach
2020-11-03 15:15 ` [PATCH v5 1/5] dt-bindings: vendor-prefixes: Add asix prefix Łukasz Stelmach
2020-11-03 15:15 ` [PATCH v5 2/5] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter Łukasz Stelmach
2020-11-05 22:26 ` Rob Herring
2020-11-06 19:41 ` Krzysztof Kozlowski
2020-11-03 15:15 ` [PATCH v5 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver Łukasz Stelmach
2020-11-04 2:42 ` Andrew Lunn
2020-11-04 10:20 ` Lukasz Stelmach
2020-11-04 13:02 ` Andrew Lunn [this message]
2020-11-03 15:15 ` [PATCH v5 4/5] ARM: dts: exynos: Add Ethernet to Artik 5 board Łukasz Stelmach
2020-11-06 19:39 ` Krzysztof Kozlowski
2020-11-03 15:15 ` [PATCH v5 5/5] ARM: defconfig: Enable ax88796c driver Łukasz Stelmach
2020-11-06 19:40 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104130212.GU933237@lunn.ch \
--to=andrew@lunn.ch \
--cc=b.zolnierkie@samsung.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=jim.cromie@gmail.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=l.stelmach@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).