From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 752E0C4742C for ; Wed, 4 Nov 2020 14:08:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF591221E2 for ; Wed, 4 Nov 2020 14:08:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pL3BC7Gm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF591221E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+8CnyM65zkR4Delpb5Ches5yER0FRKXLD285mSQo+gA=; b=pL3BC7GmWZxw3lMAcmvlq4zAO fQlCiiOO1EyyrdzOTCa6794C7QLknniBhQrkTl7v24MY2lyr2f1vsZVkV8+39bOQDhsD0KVdt68lI Z0XgJE1wf3Zpmseqg1ZzcznI5a2LEfAqxWZemhVgsk9qTYjuF8l4+LbUrZpspQe8O7CjGAy58t0mK HyKOXn1fFsqmsYHnihTEPjMvboIUfXPg1dHyXQ4P2dpZ7e7QnmD61KVMkIjbaIQQ5kaaqrnz7i6Sn Fm9eObcijPFFoVwSTE3rXjUrg8A+Mlb6uH19p07V1KT6Yrbl2Ke/CHsYBBTIDy1kPRyQP4d055COy e3cKBrnWQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaJQe-0000xk-OH; Wed, 04 Nov 2020 14:06:24 +0000 Received: from mail-wm1-f67.google.com ([209.85.128.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaJQb-0000ww-6A for linux-arm-kernel@lists.infradead.org; Wed, 04 Nov 2020 14:06:22 +0000 Received: by mail-wm1-f67.google.com with SMTP id h22so2459987wmb.0 for ; Wed, 04 Nov 2020 06:06:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=S41teLRLSZ7isGd7nFyvP35fxvOeeax7aZ66a+ME5Ss=; b=Mxqj7XJORhHdeOB8UwfJ+WVTcN6ekwl/5udshWRTxKCrqeGLKeMar2BhKL62jeH3NY 4Ez/npIsz27ldD4t2vNATuFBsh0xivAn8I0Ig3qpV0tmv9kkaA70sHKJxng5cQ4S0lKr hIhkQSf3ROvr+9Gwse+I6um5aaqpwriA+jCx/yi8sfUp/UVlLfM0iMtCThAqyTjsREDM 8xwvGYozzFf+Y7ClVMq7juw3SL5yeS1zHXPU3VtOzGToKzriSZQx2eEMvBR47R7rGdT6 wYI/MXVO8BalP8cxlpHwKt3zGqwvItmeQHAXto60U4YO6UgS2CFCe3IEg/5C+v3SOhPm G55Q== X-Gm-Message-State: AOAM533UteOsK8GGls1KQp1DqpfY3T3a6SKDXP/I3kKWiKQDlyOY0BrF Wl1DoMjDBA3VL93wTbnLbOM= X-Google-Smtp-Source: ABdhPJzub2Qdl39XwePCwW5f4Na1s1gFDl9l1dWju07Y2lOINxiR82U83DMQ2PjXZBKrxm2EzbTIJg== X-Received: by 2002:a05:600c:2282:: with SMTP id 2mr5089187wmf.154.1604498779470; Wed, 04 Nov 2020 06:06:19 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id g186sm6885889wma.1.2020.11.04.06.06.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 06:06:17 -0800 (PST) Date: Wed, 4 Nov 2020 15:06:16 +0100 From: Krzysztof Kozlowski To: Sylwester Nawrocki Subject: Re: [PATCH v8 2/7] interconnect: Add generic interconnect driver for Exynos SoCs Message-ID: <20201104140616.GA3024@kozik-lap> References: <20201104103657.18007-1-s.nawrocki@samsung.com> <20201104103657.18007-3-s.nawrocki@samsung.com> <20201104123729.GA13371@kozik-lap> <346da718-2340-c862-9a1a-c5f64aae19c2@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <346da718-2340-c862-9a1a-c5f64aae19c2@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201104_090621_267336_FFEF5CD8 X-CRM114-Status: GOOD ( 23.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com, linux-pm@vger.kernel.org, sw0312.kim@samsung.com, a.swigon@samsung.com, robh+dt@kernel.org, linux-kernel@vger.kernel.org, inki.dae@samsung.com, cw00.choi@samsung.com, myungjoo.ham@samsung.com, dri-devel@lists.freedesktop.org, georgi.djakov@linaro.org, linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 04, 2020 at 02:22:37PM +0100, Sylwester Nawrocki wrote: > On 04.11.2020 13:37, Krzysztof Kozlowski wrote: > > On Wed, Nov 04, 2020 at 11:36:52AM +0100, Sylwester Nawrocki wrote: > > >> diff --git a/drivers/interconnect/Makefile b/drivers/interconnect/Makefile > >> index d203520..c2f9e9d 100644 > >> --- a/drivers/interconnect/Makefile > >> +++ b/drivers/interconnect/Makefile > >> @@ -6,3 +6,4 @@ icc-core-objs := core.o bulk.o > >> obj-$(CONFIG_INTERCONNECT) += icc-core.o > >> obj-$(CONFIG_INTERCONNECT_IMX) += imx/ > >> obj-$(CONFIG_INTERCONNECT_QCOM) += qcom/ > >> +obj-$(CONFIG_INTERCONNECT_SAMSUNG) += samsung/ > >> \ No newline at end of file > > > > This needs a fix. > > Corrected, thanks for pointing out. > > >> diff --git a/drivers/interconnect/samsung/Kconfig b/drivers/interconnect/samsung/Kconfig > >> new file mode 100644 > >> index 0000000..508ed64 > >> --- /dev/null > >> +++ b/drivers/interconnect/samsung/Kconfig > >> @@ -0,0 +1,13 @@ > >> +# SPDX-License-Identifier: GPL-2.0-only > >> +config INTERCONNECT_SAMSUNG > >> + bool "Samsung interconnect drivers" > > > > "Samsung SoC interconnect drivers" > > Changed. > > >> + depends on ARCH_EXYNOS || COMPILE_TEST > > > > Don't the depend on INTERCONNECT? > > This file gets included only if INTERCONNECT is enabled, see > higher level Kconfig file. I missed the include part, looks good. > > >> + help > >> + Interconnect drivers for Samsung SoCs. > >> + > >> + > > > > One line break > > Fixed. > > >> +config INTERCONNECT_EXYNOS > >> + tristate "Exynos generic interconnect driver" > >> + depends on INTERCONNECT_SAMSUNG > > > > How about: > > default y if ARCH_EXYNOS > > OK, added. > > >> + help > >> + Generic interconnect driver for Exynos SoCs. > >> diff --git a/drivers/interconnect/samsung/Makefile b/drivers/interconnect/samsung/Makefile > >> new file mode 100644 > >> index 0000000..e19d1df > >> --- /dev/null > >> +++ b/drivers/interconnect/samsung/Makefile > >> @@ -0,0 +1,4 @@ > >> +# SPDX-License-Identifier: GPL-2.0 > >> +exynos-interconnect-objs := exynos.o > > > > What is this line for? > > That allows to change the module name, so it's exynos-interconnect.ko > rather than just exynos.c. It's done similarly for other SoCs in > the subsystem. Thanks, makes sense. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel