From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB132C4741F for ; Wed, 4 Nov 2020 14:40:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 89A8120739 for ; Wed, 4 Nov 2020 14:40:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RkZYNCH6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89A8120739 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jqVT+MDVUEfRNXP6tZ3dg+/EUxYXkyKf2k/ijk5uxxY=; b=RkZYNCH6MxVspny+klg3K4LYH e7djIvE8xkPKka1VaBSsMpT0LcUrA0/9g7rardVpvd8A0N1OkgiadXtbjinJaSiDJ9sCra/sQ/G1Z 8p2uvAhKTF9kMraNw0cw9TaYazeE4viRbsa6miQucW/3goyyIXhjcnpKZAX92qiMha5gTWvtSlZtA 6vOUsD8votHMN8GvwNDXVRvgy+3vWg2ianH1vitlkA0muMYatbdmyR2zLJdOAvqsyjPM5MSR9SviY rbxiiqP9lMaZ9dM7IlwFnOQmBYTRUm1Ds9gF4DtB0Wv9lZrk3UvA9ebSVfLVIjaRTjl6LakFWYUBA uJRNUv6+A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaJw1-0004XM-JS; Wed, 04 Nov 2020 14:38:49 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaJvy-0004WR-Jg for linux-arm-kernel@lists.infradead.org; Wed, 04 Nov 2020 14:38:47 +0000 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kaJvq-005DwP-BX; Wed, 04 Nov 2020 15:38:38 +0100 Date: Wed, 4 Nov 2020 15:38:38 +0100 From: Andrew Lunn To: Lee Jones Subject: Re: [PATCH 06/12] net: ethernet: ti: am65-cpsw-qos: Demote non-conformant function header Message-ID: <20201104143838.GD1213539@lunn.ch> References: <20201104090610.1446616-1-lee.jones@linaro.org> <20201104090610.1446616-7-lee.jones@linaro.org> <20201104133354.GA933237@lunn.ch> <20201104142835.GD4488@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201104142835.GD4488@dell> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201104_093846_685996_6B6A1423 X-CRM114-Status: GOOD ( 16.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ivan Khoronzhuk , netdev@vger.kernel.org, "Gustavo A. R. Silva" , linux-kernel@vger.kernel.org, kuba@kernel.org, davem@davemloft.net, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 04, 2020 at 02:28:35PM +0000, Lee Jones wrote: > On Wed, 04 Nov 2020, Andrew Lunn wrote: > > > On Wed, Nov 04, 2020 at 09:06:04AM +0000, Lee Jones wrote: > > > Fixes the following W=1 kernel build warning(s): > > > > > > drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'ndev' not described in 'am65_cpsw_timer_set' > > > drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'est_new' not described in 'am65_cpsw_timer_set' > > > > > > Cc: "David S. Miller" > > > Cc: Jakub Kicinski > > > Cc: Ivan Khoronzhuk > > > Cc: "Gustavo A. R. Silva" > > > Cc: netdev@vger.kernel.org > > > Signed-off-by: Lee Jones > > > > Reviewed-by: Andrew Lunn > > > > I _think_ these have got missed so far in the various cleanup passes > > because of missing COMPILE_TEST. I've been adding that as part of > > fixing these warnings. When your respin, could you add that as well? > > Yes, no problem. > > Just for this symbol? Hi Lee I've not look at the Kbuild, but ideally so that all TI drivers get built when COMPILE_TEST is true. And this probably needs to happen for any patch i added a Reviewed-by: because i missed them as well. I'm using COMPILE_TEST but just for arm and x86, where as i guess you are using more randconfig builds, or less popular architectures? Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel