From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAEF1C2D0A3 for ; Wed, 4 Nov 2020 17:25:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1CCFE20782 for ; Wed, 4 Nov 2020 17:25:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NWe61OeV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CCFE20782 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Kx+VvuNz8aVzY9zr8CPyseLFADyEJQELVorEjmCl9x0=; b=NWe61OeVlrD1fhASXzzuifUAl fcR86KH+XmyKc15Xx8j6Fes1VzmNjvE6E+6z0j2wtkExoG/VaCS++h+S+mdNyKyz89ZRztVg6lqxV Q1yxxJpDxZTiaGKEDIvAMrJ2WE2ikonyc9AOwj+3iI9T+fi+r9hqne0tpY2HKbU9j0CECv+lMpAJM 5I+gfj9PdiOHmDGWf9fr+GhBQzMhnayXxvv9pfITsiHT3AvWa50i6CdxpQKrUrjL8zSwSLC4aHC0v 1sOQXe/ARJ/g9zJimK53VQTmo2MifCwTy+KgnZGDE5XIqMs1/Qspl2QX2dBuIwL4xWPui5I/vt0jr gEql3M18w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaMWq-0004tf-8m; Wed, 04 Nov 2020 17:25:00 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaMWm-0004sJ-T1 for linux-arm-kernel@lists.infradead.org; Wed, 04 Nov 2020 17:24:58 +0000 Received: from gaia (unknown [2.26.170.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 391AD20781; Wed, 4 Nov 2020 17:24:50 +0000 (UTC) Date: Wed, 4 Nov 2020 17:24:48 +0000 From: Catalin Marinas To: "Eric W. Biederman" Subject: Re: [PATCH v13 1/8] parisc: Drop parisc special case for __sighandler_t Message-ID: <20201104172447.GF28902@gaia> References: <7e26600459cb08c5016611b37fe88c23098b40eb.1604376407.git.pcc@google.com> <87a6vx6p11.fsf@x220.int.ebiederm.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87a6vx6p11.fsf@x220.int.ebiederm.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201104_122457_087569_04ECB2B6 X-CRM114-Status: GOOD ( 25.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Collingbourne , Helge Deller , Kevin Brodsky , Oleg Nesterov , linux-api@vger.kernel.org, "James E.J. Bottomley" , Kostya Serebryany , Linux ARM , Andrey Konovalov , David Spickett , Vincenzo Frascino , Will Deacon , Dave Martin , Evgenii Stepanov , Richard Henderson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 04, 2020 at 10:54:34AM -0600, Eric W. Biederman wrote: > Peter Collingbourne writes: > > From: Helge Deller > > > > I believe we can and *should* drop this parisc-specific typedef for > > __sighandler_t when compiling a 64-bit kernel. The reasons: > > > > 1. We don't have a 64-bit userspace yet, so nothing (on userspace side) > > can break. > > > > 2. Inside the Linux kernel, this is only used in kernel/signal.c, in > > function kernel_sigaction() where the signal handler is compared against > > SIG_IGN. SIG_IGN is defined as (__sighandler_t)1), so only the pointers > > are compared. > > > > 3. Even when a 64-bit userspace gets added at some point, I think > > __sighandler_t should be defined what it is: a function pointer struct. > > > > I compiled kernel/signal.c with and without the patch, and the produced code > > is identical in both cases. > > > > Signed-off-by: Helge Deller > > Reviewed-by: Peter Collingbourne > > Link: > > https://linux-review.googlesource.com/id/I21c43f21b264f339e3aa395626af838646f62d97 > > Peter as you have sent this, this also needs your Signed-off-by. > > Otherwise this looks reasonable to me. > Acked-by: "Eric W. Biederman" > > While the final bits look like they are still under discussion it looks > like the preceding cleanups are pretty solid at this point. Minor nits, unless you nak the whole approach of SA_FAULTFLAGS and SA_UNSUPPORTED ;) (it looks a bit complicated to me but I don't have a better idea for a generic implementation). > Any chance we can get the cleanups into a tree in linux-next so that > the discussion can focus on the core parts of this work? > > Perhaps I should pick up the clenaups? However you prefer (I usually start queuing patches at -rc3). If you pick them up, please provide a stable branch somewhere so that we can add the others on top. Thanks. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel