From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31BA8C00A89 for ; Thu, 5 Nov 2020 04:43:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A25882083B for ; Thu, 5 Nov 2020 04:43:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2cqoJHbS"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="aduHHERC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A25882083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bujQTixEAxaZ23pyvjnBzvsrkkw1xNGPgtg4+1510bA=; b=2cqoJHbS5eUcs5JzsXXGiDG9b pBlBzRxYnDRZvFI2ZjIFXd5reAeNwNjF7d3YUAa6CM5kv11iqExAn5tA8BLwdmqFAA+4IS/11M4Od 2x61y0ApMBGlx38QSxv484L2HRYM1VyubUf45rx1cXCAOtJbk4uoZI8n4ObIVta7nOITtiUlX3xdY pS5Znnh8dFVOlHfLoTXvnE83f+c7t7YLl4Bbe+tskI0UQyItHmzWB4es75FO5GUKPQwZKM7XKksOm jn4yo4uVrXophbA9gVS245meEfNIQtHcWiKhgWUP4OKgrp53q0LjmvIJN7POck2R6IcZu2vHVLItH EgHQkIWhQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaX7A-0006Ul-4r; Thu, 05 Nov 2020 04:43:12 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaW88-00016k-9A for linux-arm-kernel@merlin.infradead.org; Thu, 05 Nov 2020 03:40:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=E6N7y6aqHymIOGjWcFaM/nQ9os/1RczW+s0nXe0CnlM=; b=aduHHERCmij5rurimhH65tg1Cs EUZhza/xrY5X6yfXjiVD3tUMrLYXy2jvxFwqZ09HGUfLeRO2iYbv8RE/Jk4PCXwEuu4pFC5ONjSOW 97kp4WHG+2SEBkzwNLSR0OxdtVN5lzCF7CcinsDPsfH+D/bOSkZ96HV1fHJYruH7OqIx30WLmmP8D aHJrNoFWGfLrx1niao/CjbvwtHaXHLStDDM+OeHGUe95sJ64t6B0+e0EYYTackSDQvnmJop4k+YUi hM8A/RKu7riKa97JMaNHUx0mupyYjY9+2rbOCVUEwopY+d+EU05Cc2aCfLbSpqzKhJnAm8q9PBAUR WPvSyxVw==; Received: from mail-oi1-f195.google.com ([209.85.167.195]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaQ0q-0008Td-8P for linux-arm-kernel@lists.infradead.org; Wed, 04 Nov 2020 21:08:14 +0000 Received: by mail-oi1-f195.google.com with SMTP id 9so23690892oir.5 for ; Wed, 04 Nov 2020 13:08:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=E6N7y6aqHymIOGjWcFaM/nQ9os/1RczW+s0nXe0CnlM=; b=hQ2WAXHIHcTwgFdsBw4XqY3UoBqd7GVNx2N28Cnd/wbKQe5d9nxu6Zjm28r1vrqBpl XxvAren7hfAo6X0n8Xw+/qQruhFx8qlQtDmYPO8d4XI8BM/60oWILY6nxkb/oW+Orrub BPnbeoiHVOaEFJE6uRdi1iYHW+Ed54XO1GtKruUYNsxZtg1LE8YQPKaPMZKhPgGswXRb rrUTXEVz2JeHOrGaIR4C0JgT1Up3nKkXwasc+u0Cbif0W5vNCMvr4iybY56m9iXzQd7Y WY8qZrDe9YQ0jXTTm38rx1yKHRoncdzCbj+WM5XA9nWSvYWO3qtGTshrsirFV9ugV+JK v5Lg== X-Gm-Message-State: AOAM530ccz2DfL25aBBLExQ8LH+Lskgo91LXpIC+LXSAGPUf/dK6LrrD TujXHT8HSmu20eSM62iL1Q== X-Google-Smtp-Source: ABdhPJwgJn7aeZ8zCXOQwqnAD2VEZKNdyYfV8x1BfKUkOMGErVQR7l0m5hQ7mxJhgu8/lVoowdOfmw== X-Received: by 2002:aca:d6d3:: with SMTP id n202mr3608860oig.74.1604524085067; Wed, 04 Nov 2020 13:08:05 -0800 (PST) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id p72sm803239oop.28.2020.11.04.13.08.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 13:08:04 -0800 (PST) Received: (nullmailer pid 4127142 invoked by uid 1000); Wed, 04 Nov 2020 21:08:03 -0000 Date: Wed, 4 Nov 2020 15:08:03 -0600 From: Rob Herring To: Amelie DELAUNAY Subject: Re: [RESEND PATCH v3 1/4] dt-bindings: connector: add power-opmode optional property to usb-connector Message-ID: <20201104210803.GA4115079@bogus> References: <20201029095806.10648-1-amelie.delaunay@st.com> <20201029095806.10648-2-amelie.delaunay@st.com> <20201029154016.GA1917373@bogus> <860d5620-4fdf-6e01-9a04-3967d6fcfd6b@st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201104_210812_448644_2B479E6C X-CRM114-Status: GOOD ( 30.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Heikki Krogerus , Alexandre Torgue , Greg Kroah-Hartman , Linux USB List , Russell King , "linux-kernel@vger.kernel.org" , Maxime Coquelin , "moderated list:ARM/STM32 ARCHITECTURE" , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 30, 2020 at 04:27:14PM +0100, Amelie DELAUNAY wrote: > > > On 10/30/20 3:29 PM, Rob Herring wrote: > > On Thu, Oct 29, 2020 at 11:49 AM Amelie DELAUNAY wrote: > > > > > > > > > > > > On 10/29/20 4:40 PM, Rob Herring wrote: > > > > On Thu, Oct 29, 2020 at 10:58:03AM +0100, Amelie Delaunay wrote: > > > > > Power operation mode may depends on hardware design, so, add the optional > > > > > property power-opmode for usb-c connector to select the power operation > > > > > mode capability. > > > > > > > > > > Signed-off-by: Amelie Delaunay > > > > > --- > > > > > .../bindings/connector/usb-connector.yaml | 18 ++++++++++++++++++ > > > > > 1 file changed, 18 insertions(+) > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml > > > > > index 728f82db073d..200d19c60fd5 100644 > > > > > --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml > > > > > +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml > > > > > @@ -93,6 +93,24 @@ properties: > > > > > - device > > > > > - dual > > > > > > > > > > + power-opmode: > > > > > > > > I've acked this version: > > > > > > > > https://lore.kernel.org/r/20201020093627.256885-2-badhri@google.com > > > > > > > > > > frs is used for Fast Role Swap defined in USB PD spec. > > > I understand it allows to get the same information but I'm wondering why > > > the property name is limited to -frs- in this case. What about a > > > non-power delivery USB-C connector ? > > > > I've got no idea. The folks that know USB-C and PD details need to get > > together and work all this out. To me, it looks like the same thing... > > > > It looks but... > > The purpose of power-opmode property is to configure the USB-C controllers, > especially the non-PD USB-C controllers to determine the power operation > mode that the Type C connector will support and will advertise through CC > pins when it has no power delivery support, whatever the power role: Sink, > Source or Dual > The management of the property is the same that data-role and power-role > properties, and done by USB Type-C Connector Class. > > new-source-frs-typec-current specifies initial current capability of the new > source when vSafe5V is applied during PD3.0 Fast Role Swap. So here, this > property is not applied at usb-c controller configuration level, but during > PD Fast Role Swap, so when the Sink become the Source. > Moreover, the related driver code says FRS can only be supported by DRP > ports. So new-source-frs-typec-current property, in addition to being > specific to PD, is also dedicated to DRP usb-c controller. > The property is managed by Type-C Port Controller Manager for PD. But it's the same set of possible values, right? So we can align the values at least. Can we align the names in some way? power-opmode and frs-source-opmode or ?? Are these 2 properties mutually exclusive? If so, that should be captured. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel