From: Rob Herring <robh@kernel.org>
To: Jim Quinlan <james.quinlan@broadcom.com>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
open list <linux-kernel@vger.kernel.org>,
bcm-kernel-feedback-list@broadcom.com, sudeep.holla@arm.com,
"moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 1/2] dt-bindings: Add bindings for BrcmSTB SCMI mailbox driver
Date: Wed, 4 Nov 2020 15:50:50 -0600 [thread overview]
Message-ID: <20201104215050.GA4180546@bogus> (raw)
In-Reply-To: <20201029195913.5927-2-james.quinlan@broadcom.com>
On Thu, Oct 29, 2020 at 03:59:06PM -0400, Jim Quinlan wrote:
> Bindings are added. Only one interrupt is needed because
> we do not yet employ the SCMI p2a channel.
I still don't understand what this is. To repeat from v1: I thought SCMI
was a mailbox consumer, not provider?
>
> Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
> ---
> .../bindings/mailbox/brcm,brcmstb-mbox.yaml | 39 +++++++++++++++++++
> 1 file changed, 39 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mailbox/brcm,brcmstb-mbox.yaml
>
> diff --git a/Documentation/devicetree/bindings/mailbox/brcm,brcmstb-mbox.yaml b/Documentation/devicetree/bindings/mailbox/brcm,brcmstb-mbox.yaml
> new file mode 100644
> index 000000000000..797c0cc609a3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mailbox/brcm,brcmstb-mbox.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +$id: http://devicetree.org/schemas/mailbox/brcm,brcmstb-mbox.yaml#
> +
> +title: Broadcom STB mailbox driver bindings
> +
> +maintainers:
> + - Jim Quinlan <james.quinlan@broadcom.com>
> +
> +properties:
> + compatible:
> + enum:
> + - brcm,brcmstb-mbox
> +
> + interrupts:
> + items:
> + - description: a2p return interrupt, indicates SCMI msg completion.
> +
> + "#mbox-cells":
> + const: 1
> +
> +required:
> + - compatible
> + - interrupts
> + - "#mbox-cells"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + mailbox {
> + compatible = "brcm,brcmstb-mailbox";
> + #mbox-cells = <1>;
> + interrupts = <GIC_SPI 0xc6 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +...
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-05 3:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 19:59 [PATCH v4 0/2] mailbox: Add Broadcom STB mailbox driver for SCMI Jim Quinlan
2020-10-29 19:59 ` [PATCH v4 1/2] dt-bindings: Add bindings for BrcmSTB SCMI mailbox driver Jim Quinlan
2020-11-04 21:50 ` Rob Herring [this message]
2020-11-04 22:03 ` Jim Quinlan
2020-11-05 15:13 ` Rob Herring
2020-11-05 15:28 ` Jim Quinlan
2020-11-05 18:27 ` Sudeep Holla
2020-11-05 18:57 ` Jim Quinlan
2020-11-05 19:05 ` Sudeep Holla
2020-10-29 19:59 ` [PATCH v4 2/2] mailbox: Add Broadcom STB " Jim Quinlan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104215050.GA4180546@bogus \
--to=robh@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=james.quinlan@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).