From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBC36C00A89 for ; Thu, 5 Nov 2020 08:10:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D28922201 for ; Thu, 5 Nov 2020 08:10:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tNCArzpp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D28922201 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+deyAJgN3+9FHRi86244Bkm4qogBwQKyU04zzCE5lzU=; b=tNCArzppP9vl2upWvrKOe/JWd 07kGrIbwJA80aCw3ooz3lPxoQLzpnTqFDXX0JhIfxYAzW6WXFMHUH0XnEhFj0BeyJjaS/cNE8vXCn 3Arenn6zhkEXd/c1jQjWCXpBCPJ2k3xmrMQMmlHHihgbsNeurrGXth9DBA+t7qVZP2LzkU2hAB89J AzpWFeeGvrcvTaVkvJ+N9ieWYgphtzwrwt0qeCZVbJGHRd68q0oK3/Y5CXhVGo0AH1TBX2gw+EIG0 twXr79YRdeJeRzrs1XP4ixltXZLnXkHdAjEV5ASRbvbDOcoHsS3XA/GOrcWOluSDhomWBtOoJpFkO PS4EYFK+w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaaKT-00005q-EZ; Thu, 05 Nov 2020 08:09:09 +0000 Received: from mail-ed1-f65.google.com ([209.85.208.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaaKQ-000052-4z for linux-arm-kernel@lists.infradead.org; Thu, 05 Nov 2020 08:09:07 +0000 Received: by mail-ed1-f65.google.com with SMTP id e18so564737edy.6 for ; Thu, 05 Nov 2020 00:09:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VN2SNhST5biqDVcxltQIhYUxuznuc4xOUZgsRFlyXuE=; b=AQGlNsr2/uVYJLwhFKivL7Q8RY71Us+FMMVarjqJHeCCV2HlCMIvZ7pHTPLH8ECqBJ Ir7FhQ1A4Wj9fuwLmOurIKLjEkhZk+zeN+4c+KSaGdtmIciaZxSXuKzOaDZ8W5L5sGC8 ABKPG0aHMWafDvT06Pd64wxIhDOsIjTG+xYOd04e65HG9rq9gKhu2tVhYIFwYUBJhqkM WdTK00Hx2NsMVemY4sTpKR/nd4rgXpTM9FP2IWEMkJqgPYKzEaEn0QNiUn3NoqJlkc89 d1IfTO/iRVCDKh9evRkksETQD2mamXB2snOj7vBfy71lFDx/y908I+9NVjOf7re9Xyp5 76yg== X-Gm-Message-State: AOAM532c5pPaFqpAW+OKx0Dz0MQtAhtiSeKtgEifTPMVrpiuFn8HusXu vOVfK1LIj/55w7DBtjPj8Dk= X-Google-Smtp-Source: ABdhPJxd+6Pg5alxWbpWPvEy7Y+00ctaABN4nx3GTEKIZ2UZaS3xKMNHx8vvlh5hhS/GKjlkhTS7Zg== X-Received: by 2002:a05:6402:185:: with SMTP id r5mr1350938edv.263.1604563742891; Thu, 05 Nov 2020 00:09:02 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id a10sm416960edn.77.2020.11.05.00.09.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 00:09:01 -0800 (PST) Date: Thu, 5 Nov 2020 09:09:00 +0100 From: Krzysztof Kozlowski To: Linus Walleij Subject: Re: [PATCH 1/3 v2] Input: atmel_mxt_ts - Fix up inverted RESET handler Message-ID: <20201105080900.GA17235@kozik-lap> References: <20201104153032.1387747-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201104153032.1387747-1-linus.walleij@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201105_030906_235053_98224F3B X-CRM114-Status: GOOD ( 19.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Dmitry Torokhov , NXP Linux Team , Pengutronix Kernel Team , linux-input@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 04, 2020 at 04:30:30PM +0100, Linus Walleij wrote: > This driver uses GPIO descriptors to drive the touchscreen > RESET line. In the existing device trees this has in > conflict with intution been flagged as GPIO_ACTIVE_HIGH > and the driver then applies the reverse action by > driving the line low (setting to 0) to enter > reset state and driving the line high (setting to 1) to > get out of reset state. > > The correct way to handle active low GPIO lines is to > provide the GPIO_ACTIVE_LOW in the device tree (thus > properly describing the hardware) and letting the GPIO > framework invert the assertion (driving high) to a low > level and vice versa. > > This is considered a bug since the device trees are > incorrectly mis-specifying the line as active high. > > Fix the driver and all device trees specifying a reset > line. > > Cc: Krzysztof Kozlowski > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-tegra@vger.kernel.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: NXP Linux Team > Cc: Pengutronix Kernel Team > Signed-off-by: Linus Walleij > --- > ChangeLog v1->v2: > - New patch fixing this confusion before adding the > new YAML bindings. > - CC some misc maintainers and mailing lists that should > be aware that we do this change. Acked-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel