From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1972C00A89 for ; Thu, 5 Nov 2020 10:57:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5FFC620729 for ; Thu, 5 Nov 2020 10:57:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ru+arE2Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5FFC620729 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kFaAs9e8G77BFKi+qkQjcPQ6mrhVnCvsSePCCfXYaqw=; b=Ru+arE2YWAnRcviMVc+S+g78x ugvpXtG/jlWKvX3agRxsNOk1q8MTA9q2+y3B3GqRIq9QYPjcc+v7uGY2X/Ckj320zZ8vW/5FyK6Xv R5eLR9cn4+EceNH6nIVlu3m4APPPI2Sf+TJoqy56XCGKFlnOfpRnXmXz9l/RtPXKH1zM57C88r9Ow eoQ1cORMWQgM2sZQaqyhrotZkIFYlg+PEvutgdbWx8uUguBc4elCZZ9spHbdPTmpAIQ1Y/WVaTiBR +8nEC+MBWrRgLEeM9VB9UK2Vi903DwLA2qURFk+A84BOcXw2s+TlLeSH8maHvAghyrbfAXXEUySdv bcwSMIAQA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kacwc-0004pE-QK; Thu, 05 Nov 2020 10:56:42 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kacwa-0004oN-0V for linux-arm-kernel@lists.infradead.org; Thu, 05 Nov 2020 10:56:40 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D0C9F142F; Thu, 5 Nov 2020 02:56:38 -0800 (PST) Received: from e123083-lin (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0A4363F66E; Thu, 5 Nov 2020 02:56:35 -0800 (PST) Date: Thu, 5 Nov 2020 11:56:33 +0100 From: Morten Rasmussen To: Lukasz Luba Subject: Re: [PATCH v4 1/4] PM / EM: Add a flag indicating units of power values in Energy Model Message-ID: <20201105105633.GB8237@e123083-lin> References: <20201103090600.29053-1-lukasz.luba@arm.com> <20201103090600.29053-2-lukasz.luba@arm.com> <20201105091759.GA8237@e123083-lin> <876ca521-1576-63c5-9af5-b000f52cc17b@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <876ca521-1576-63c5-9af5-b000f52cc17b@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201105_055640_147220_BC7512A3 X-CRM114-Status: GOOD ( 15.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dianders@chromium.org, devicetree@vger.kernel.org, nm@ti.com, amitk@kernel.org, rnayak@codeaurora.org, daniel.lezcano@linaro.org, linux-doc@vger.kernel.org, sboyd@kernel.org, viresh.kumar@linaro.org, mka@chromium.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, qperret@google.com, robh+dt@kernel.org, sudeep.holla@arm.com, rafael@kernel.org, corbet@lwn.net, Dietmar.Eggemann@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 05, 2020 at 10:09:05AM +0000, Lukasz Luba wrote: > > > On 11/5/20 9:18 AM, Morten Rasmussen wrote: > > On Tue, Nov 03, 2020 at 09:05:57AM +0000, Lukasz Luba wrote: > > > @@ -79,7 +82,8 @@ struct em_data_callback { > > > struct em_perf_domain *em_cpu_get(int cpu); > > > struct em_perf_domain *em_pd_get(struct device *dev); > > > int em_dev_register_perf_domain(struct device *dev, unsigned int nr_states, > > > - struct em_data_callback *cb, cpumask_t *span); > > > + struct em_data_callback *cb, cpumask_t *spani, > > > > "spani" looks like a typo? > > > > Good catch, yes, the vim 'i'. > > Thank you Morten. I will resend this patch when you don't > find other issues in the rest of patches. The rest of the series looks okay to me. Morten _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel