From: Ionela Voinescu <ionela.voinescu@arm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: morten.rasmussen@arm.com, souvik.chakravarty@arm.com,
catalin.marinas@arm.com, sudeep.holla@arm.com,
linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com,
viresh.kumar@linaro.org, will@kernel.org,
valentin.schneider@arm.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 3/3] arm64: implement CPPC FFH support using AMUs
Date: Thu, 5 Nov 2020 14:10:57 +0000 [thread overview]
Message-ID: <20201105141057.GB22244@arm.com> (raw)
In-Reply-To: <20201105132823.GG82102@C02TD0UTHF1T.local>
Hi Mark,
On Thursday 05 Nov 2020 at 13:28:23 (+0000), Mark Rutland wrote:
[..]
> > +#ifdef CONFIG_ACPI_CPPC_LIB
> > +#include <acpi/cppc_acpi.h>
>
> As mentioned on patch 1, I think it'd be better to open-code the smp
> call functions here, e.g.
>
> static void cpu_read_corecnt(void *val)
> {
> *(u64 *)val = read_corecnt()
> }
>
> static void cpu_read_constcnt(void *val)
> {
> *(u64 *)val = read_constcnt()
> }
>
> ... as they're only needed here and it's much clearer what they're
> doing in-context. I think that would als oget rid of the warning you
> mention in the cover letter.
>
Many thanks for the review. I was tempted by the fewer lines of code of
the macro, for that very simple functionality of the counter reads, but
your arguments against it make sense.
I'll change this and 1/3 and push v4 later today.
Regards,
Ionela.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-11-05 14:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 12:26 [PATCH v3 0/3] arm64: cppc: add FFH support using AMUs Ionela Voinescu
2020-11-05 12:27 ` [PATCH v3 1/3] arm64: wrap and generalise counter read functions Ionela Voinescu
2020-11-05 13:27 ` Mark Rutland
2020-11-05 12:27 ` [PATCH v3 2/3] arm64: split counter validation function Ionela Voinescu
2020-11-05 12:27 ` [PATCH v3 3/3] arm64: implement CPPC FFH support using AMUs Ionela Voinescu
2020-11-05 13:28 ` Mark Rutland
2020-11-05 14:10 ` Ionela Voinescu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201105141057.GB22244@arm.com \
--to=ionela.voinescu@arm.com \
--cc=catalin.marinas@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=morten.rasmussen@arm.com \
--cc=souvik.chakravarty@arm.com \
--cc=sudeep.holla@arm.com \
--cc=valentin.schneider@arm.com \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).