From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAAFAC4741F for ; Thu, 5 Nov 2020 14:11:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E08E206DB for ; Thu, 5 Nov 2020 14:11:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="okRKJ5ue" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E08E206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Or0UlRzLGeVV5RUFDgwpxQ3XAT36nIahVUxOIEip+es=; b=okRKJ5uevV8RHs1Zm+j7GbvvL +dsiiQl67tbzIIUAxxZ4nzZEhv2Zbe8v7+Opr3kL7bsBcdQMRjfGlxdXmM4k320hPtZKyNRuZrump YRNIKIYZGwvLS3mXhSU7hKfwsKT7E+HtBbCFwSpt5CqPzI2sm4QXT53LAgy2gpEgz4tsP2auX6I5Y +B/h3tYtdCLF9KADfmm07N16QuxHzdfbL0VWV317IzFySbH/sjpEGYGqiPKNMXz61YQrAUCeCdSqg 25g9v66Woxrzlwgt8H+znCDzXSj6KW2voofLGKzzOnhA+xkwRypRcjtbHXC4rTMsEHGXP7F2kL2nd CFsIDs6vw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kafyg-0008M2-3c; Thu, 05 Nov 2020 14:11:02 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kafye-0008L8-42 for linux-arm-kernel@lists.infradead.org; Thu, 05 Nov 2020 14:11:00 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 46B7314BF; Thu, 5 Nov 2020 06:10:59 -0800 (PST) Received: from localhost (e108754-lin.cambridge.arm.com [10.1.198.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DC2653F719; Thu, 5 Nov 2020 06:10:58 -0800 (PST) Date: Thu, 5 Nov 2020 14:10:57 +0000 From: Ionela Voinescu To: Mark Rutland Subject: Re: [PATCH v3 3/3] arm64: implement CPPC FFH support using AMUs Message-ID: <20201105141057.GB22244@arm.com> References: <20201105122702.13916-1-ionela.voinescu@arm.com> <20201105122702.13916-4-ionela.voinescu@arm.com> <20201105132823.GG82102@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201105132823.GG82102@C02TD0UTHF1T.local> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201105_091100_224479_947C899F X-CRM114-Status: GOOD ( 13.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: morten.rasmussen@arm.com, souvik.chakravarty@arm.com, catalin.marinas@arm.com, sudeep.holla@arm.com, linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com, viresh.kumar@linaro.org, will@kernel.org, valentin.schneider@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mark, On Thursday 05 Nov 2020 at 13:28:23 (+0000), Mark Rutland wrote: [..] > > +#ifdef CONFIG_ACPI_CPPC_LIB > > +#include > > As mentioned on patch 1, I think it'd be better to open-code the smp > call functions here, e.g. > > static void cpu_read_corecnt(void *val) > { > *(u64 *)val = read_corecnt() > } > > static void cpu_read_constcnt(void *val) > { > *(u64 *)val = read_constcnt() > } > > ... as they're only needed here and it's much clearer what they're > doing in-context. I think that would als oget rid of the warning you > mention in the cover letter. > Many thanks for the review. I was tempted by the fewer lines of code of the macro, for that very simple functionality of the counter reads, but your arguments against it make sense. I'll change this and 1/3 and push v4 later today. Regards, Ionela. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel