From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1867DC55179 for ; Thu, 5 Nov 2020 17:40:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F652206CA for ; Thu, 5 Nov 2020 17:40:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="q+SfCzIM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F652206CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fr0n8PMtvE2hOaU29qQDySOCe4fNDwt3bJHg7TBFuMQ=; b=q+SfCzIMKSN3FNm3NQYYYWr2n m2J//NA8wikLek9p6gHIpNdFxaJzJZQmh3MmyohWzQv/7Sl1zzDSJIfPgPYAFAtMB8VXLLSkAhtKh f6GihHIqreuVYwL86QEeowG0mPPjIbkENgTWxMpIh2l3qeVBEPBuPEjIzCSR4u/0kYTPCLexYtuIV fwIK8WBpMLecaS/y4OKHiKbJf8BWJHXNcVCylbpI2inF4WGT6oLuJE7dJ9/znMl4+QV2s8K46C94P QLwMdx8EPlb8/79Rg8T9TSqKLh/3jMMhQCjWZ5V3q1/q2n15RKz8p+CYY76a62uCgbyc/ZUInv8RC o65y9Uolw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kajEC-00076u-1L; Thu, 05 Nov 2020 17:39:16 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kajE6-00074X-1b for linux-arm-kernel@lists.infradead.org; Thu, 05 Nov 2020 17:39:11 +0000 Received: from gaia (unknown [2.26.170.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7A230206CA; Thu, 5 Nov 2020 17:39:05 +0000 (UTC) Date: Thu, 5 Nov 2020 17:39:02 +0000 From: Catalin Marinas To: Andrey Konovalov Subject: Re: [PATCH v8 30/43] arm64: kasan: Allow enabling in-kernel MTE Message-ID: <20201105173901.GH30030@gaia> References: <5e3c76cac4b161fe39e3fc8ace614400bc2fb5b1.1604531793.git.andreyknvl@google.com> <20201105172549.GE30030@gaia> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201105_123910_217869_69BE6D28 X-CRM114-Status: GOOD ( 21.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux ARM , Marco Elver , Kevin Brodsky , Will Deacon , Branislav Rankov , kasan-dev , LKML , Linux Memory Management List , Alexander Potapenko , Evgenii Stepanov , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 05, 2020 at 06:29:17PM +0100, Andrey Konovalov wrote: > On Thu, Nov 5, 2020 at 6:26 PM Catalin Marinas wrote: > > > > On Thu, Nov 05, 2020 at 12:18:45AM +0100, Andrey Konovalov wrote: > > > diff --git a/arch/arm64/kernel/mte.c b/arch/arm64/kernel/mte.c > > > index 06ba6c923ab7..fcfbefcc3174 100644 > > > --- a/arch/arm64/kernel/mte.c > > > +++ b/arch/arm64/kernel/mte.c > > > @@ -121,6 +121,13 @@ void *mte_set_mem_tag_range(void *addr, size_t size, u8 tag) > > > return ptr; > > > } > > > > > > +void __init mte_init_tags(u64 max_tag) > > > +{ > > > + /* Enable MTE Sync Mode for EL1. */ > > > + sysreg_clear_set(sctlr_el1, SCTLR_ELx_TCF_MASK, SCTLR_ELx_TCF_SYNC); > > > + isb(); > > > +} > > > > Is this going to be called on each CPU? I quickly went through the rest > > of the patches and couldn't see how. > > Yes, on each CPU. This is done via kasan_init_hw_tags() that is called > from cpu_enable_mte(). This change is added in the "kasan, arm64: > implement HW_TAGS runtime". Ah, I got there eventually in patch 38. Too many indirections ;) (I'm sure we could have trimmed them down a bit, hw_init_tags == arch_init_tags == mte_init_tags). > Would it make sense to put it into a separate patch? I think that's fine. I had the impression that kasan_init_hw_tags() should only be called once. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel