From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 233D1C55178 for ; Thu, 5 Nov 2020 18:45:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1063206C0 for ; Thu, 5 Nov 2020 18:45:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IDI7+tp2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1063206C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gGkpqUf0QU2rOK1WBH78U7io5zpHSS+ZTuz27+nFMAY=; b=IDI7+tp204MWvDjdICyyuyQqz u/Tn/6tFKSnBJGvPFN+vrOyzPyIBeTLJCmT3KXcSzilLTRY9ov2vXrC9z1OzM/R6Yo4IIbbKdWFEC HoFnzRTJcmsXhQFJ2Vb3CQJPeKACEsWZKjvOy5aNjpkmmYL+mt6mPUTWBXgumcFtSto8M7bT0zCZD +5XY92iMCBkX+wiaTkb1oXNCIbEuyNC9ybFYZxyts81BcFksAD0MU5HZAsR5eRs8dJDs35uMdrfgD Z1WE8XaYNpJ7Ij7DrFU+b1IYMkpQOi8ZWiZTwWROkAvkUoaGDmMw8i9zJ4YoDImuJ4wIKJ03TBOT2 ZBWP47XQQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kakEm-0000xU-22; Thu, 05 Nov 2020 18:43:56 +0000 Received: from mail-oi1-f195.google.com ([209.85.167.195]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kakEj-0000wz-OD for linux-arm-kernel@lists.infradead.org; Thu, 05 Nov 2020 18:43:54 +0000 Received: by mail-oi1-f195.google.com with SMTP id t143so2713363oif.10 for ; Thu, 05 Nov 2020 10:43:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=d5oADnBeNIpIvCSojwrBHVdlvDCR/O5IS/nZKIy1ndA=; b=IMhD030gYI6qaVgsVUM19gZTcWBs2PLcqm+PXRGgIj3rRvXDEnr8dWEkjl7mTsFKke be6FP6Js7X+tXLSEZWkn/BO0JXTenTOSiQcQdagIiCSdXBvwJXL1kLvBqZdH91lOqYwK FL3OQk2t2kyP/mF98qGYOU89C1oU/B4MTLIzFajtLXLIM9oaK/pDa56H5JhJ/4raAvaS tZDUv8EO/iUQFLt8rybaI0iS9ZiMOQiTOhnd9XHnJDJb5Vw8zsyhvcB10F9l2bKCxdSV ku0OHi0jAA1G2ME7bjQLxnppoD9ZCfGyLRb361jhdZwOr040UBsiylaGbEhG9T+RA31n 55vg== X-Gm-Message-State: AOAM533FMwvaN9NDNlX1USFisxLnnlJC0jaUkuV9S9DQqA8ZOj5qLAe/ WIs1kkG0X5OS2VV1oTUNvg== X-Google-Smtp-Source: ABdhPJyYXmS7UjH4bUE7XXBl0KWexDWJQoYRb48zVqEn7FRn3jqT1JFDBgJKqsHgp8p6dVQEG+M/+Q== X-Received: by 2002:aca:c084:: with SMTP id q126mr506299oif.129.1604601832353; Thu, 05 Nov 2020 10:43:52 -0800 (PST) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id k10sm497430otb.81.2020.11.05.10.43.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 10:43:51 -0800 (PST) Received: (nullmailer pid 1613991 invoked by uid 1000); Thu, 05 Nov 2020 18:43:50 -0000 Date: Thu, 5 Nov 2020 12:43:50 -0600 From: Rob Herring To: Ajye Huang Subject: Re: [PATCH v5 1/2] ASoC: google: dt-bindings: modify machine bindings for two MICs case Message-ID: <20201105184350.GA1611477@bogus> References: <20201103103051.34553-1-ajye_huang@compal.corp-partner.google.com> <20201103103051.34553-2-ajye_huang@compal.corp-partner.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201103103051.34553-2-ajye_huang@compal.corp-partner.google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201105_134353_846379_27ECAB26 X-CRM114-Status: GOOD ( 17.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dianders@chromium.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Banajit Goswami , Srinivasa Rao Mandadapu , Liam Girdwood , linux-arm-msm@vger.kernel.org, Patrick Lai , Ajye Huang , linux-kernel@vger.kernel.org, tzungbi@chromium.org, Bjorn Andersson , Mark Brown , Rohit kumar , Andy Gross , srinivas.kandagatla@linaro.org, Jaroslav Kysela , linux-arm-kernel@lists.infradead.org, cychiang@chromium.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 03, 2020 at 06:30:50PM +0800, Ajye Huang wrote: > Add a property "dmic-gpios" for switching between two MICs. > > Signed-off-by: Ajye Huang > --- > .../bindings/sound/google,sc7180-trogdor.yaml | 58 +++++++++++++++++++ > 1 file changed, 58 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml b/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml > index efc34689d6b5..9e0505467e57 100644 > --- a/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml > +++ b/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml > @@ -34,6 +34,9 @@ properties: > "#size-cells": > const: 0 > > + dmic-gpios: > + description: GPIO for switching between DMICs Need to define how many (maxItems: 1). > + > patternProperties: > "^dai-link(@[0-9])?$": > description: > @@ -81,6 +84,7 @@ additionalProperties: false > examples: > > - | > + //Example 1 > sound { > compatible = "google,sc7180-trogdor"; > model = "sc7180-rt5682-max98357a-1mic"; > @@ -128,3 +132,57 @@ examples: > }; > }; > }; > + > + - | > + //Example 2 (2mic case) > + sound { > + compatible = "google,sc7180-trogdor"; > + model = "sc7180-rt5682-max98357a-2mic"; > + > + audio-routing = > + "Headphone Jack", "HPOL", > + "Headphone Jack", "HPOR"; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + dmic-gpios = <&tlmm 86 0>; Do we really need another example for this? Can't you just add it to the existing example? > + > + dai-link@0 { > + link-name = "MultiMedia0"; > + reg = <0>; > + cpu { > + sound-dai = <&lpass_cpu 0>; > + }; > + > + codec { > + sound-dai = <&alc5682 0>; > + }; > + }; > + > + dai-link@1 { > + link-name = "MultiMedia1"; > + reg = <1>; > + cpu { > + sound-dai = <&lpass_cpu 1>; > + }; > + > + codec { > + sound-dai = <&max98357a>; > + }; > + }; > + > + dai-link@2 { > + link-name = "MultiMedia2"; > + reg = <2>; > + cpu { > + sound-dai = <&lpass_hdmi 0>; > + }; > + > + codec { > + sound-dai = <&msm_dp>; > + }; > + }; > + }; > + > +... > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel