From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38885C2D0A3 for ; Fri, 6 Nov 2020 13:07:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A11A720702 for ; Fri, 6 Nov 2020 13:07:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ql/6Xanv"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JotNPZjc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A11A720702 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5JZk4FMf8GTGppmB4hH2fX+gXzouuDQmxv2LT6faeBM=; b=ql/6Xanv5zE6eqZ1e/abOHKw5 SZSMNnttUQslX3YuMHRk6EkCM1Qt8AivOgIkoCi/2GRJ56J4ocsQXyRJ/fEq6ciMMuq6qMHmXeAUi 1fzz/u0SNv9+adVb/fUzlA0OfbX6Fs9DMFFjr3Mgo0OqZSQZL7s3WC6VBk74x/wLfu+wN18cUruUW JzrwPZfaEmRIhxf0qXk2GystBDyzRcsAUREzQxAb+W+aRgblAY+U4fIjkSeJaPmupwqlRc+OkfwY3 wKiKX07huJqQXYFkoD3H/CWsyUd2153eDRvTag7NvvgLMrWkYdkkLQTQYxQQflOj7hBIfTq2pI9aM SGKK+WNmA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kb1S9-0001sT-Kc; Fri, 06 Nov 2020 13:06:53 +0000 Received: from mail-ot1-x342.google.com ([2607:f8b0:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kb1S7-0001rQ-D2 for linux-arm-kernel@lists.infradead.org; Fri, 06 Nov 2020 13:06:52 +0000 Received: by mail-ot1-x342.google.com with SMTP id 79so1145453otc.7 for ; Fri, 06 Nov 2020 05:06:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=fRK20G4/BGOrBRLDBmiiL7+5bvGQEl0XDwSOBPWbBI8=; b=JotNPZjcRcLLMkuJh6BLaDMSDw0g7P04Xc5AxvNd8vw3seVk1bWBFK5HRpSVUYTO6n oOVRugi+2iuG0C6UdIMZjoi/IByn0JrN3JEzxY7fSYsz8ESmjt/RCRwwOqbEYnDBBpIy 41R+7lhPGbrQTBqfYfZ9oQuw4l6XJhIiowlsXRb8iAHInVIlyFk8RviH1mSHXniuRGX3 yiYwEdEyYCYv8B0a1m8nctmtQldvR+L5yZczLKgmns6QXJOfDpnjYK9feNC8fURO1UJc HfrPDHlI41/nLcozi0PMKg3XF1J2oeW2TOXAvlPgpMFCSPzToEUMp/rHeSCxIlNEEUFo QAaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=fRK20G4/BGOrBRLDBmiiL7+5bvGQEl0XDwSOBPWbBI8=; b=X9ifL+h9xmF3HgpARikVT/k1GJv8Q6qUgdVQXOn9hGAC6NmRl+e95ot4le1FV6+PE1 Kr5BzmDGgodNs6/3VXjid0zvQxoeYuVZ4T+s/HVR1dYwIHi1p+fpVJtb1FZhmXDDGHNb YLZoM+bV2+u65ZxsBdOsDrV9Gt867zE9kwarU1qKUAGOKr9LbHUa/WJGhAvJ4JLm9z2b F+0BzPTimZMjFzhyocYaBLZH+eXVz3tgxPhHp8DhQOtOpb/waVDO0UYgRT2jZ6sJaR8B 0B/y19q+fuwk7hXhhnc86txOdaKndU94PIEXkDT0+Oidd1XXgWZs0bPne5nL4/3mQk2j K12Q== X-Gm-Message-State: AOAM53117W1HIr/R6bsxYsbsuCKlgL+1URvdapy1T2vaXvbc8sEAmANt j89jiYaELofh7ID6bS7sAf4= X-Google-Smtp-Source: ABdhPJzRc9hhnOoI4fdYnfJ7tHtsKnHiE1V8K23BxTe2pXu/JQNI10YNh9dPjDG0eyzVTDtu3k11Xw== X-Received: by 2002:a9d:6c4b:: with SMTP id g11mr1010166otq.265.1604668006787; Fri, 06 Nov 2020 05:06:46 -0800 (PST) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id m10sm294602oon.27.2020.11.06.05.06.45 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 06 Nov 2020 05:06:46 -0800 (PST) Date: Fri, 6 Nov 2020 05:06:44 -0800 From: Guenter Roeck To: Christophe Roullier Subject: Re: [PATCH 1/1] watchdog: stm32_iwdg: don't print an error on probe deferral Message-ID: <20201106130644.GA14837@roeck-us.net> References: <20201106094627.21132-1-christophe.roullier@st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201106094627.21132-1-christophe.roullier@st.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201106_080651_475064_5294A37C X-CRM114-Status: GOOD ( 20.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Etienne Carriere , alexandre.torgue@st.com, linux-kernel@vger.kernel.org, mcoquelin.stm32@gmail.com, wim@linux-watchdog.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 06, 2020 at 10:46:27AM +0100, Christophe Roullier wrote: > From: Etienne Carriere > > Do not print an error trace when deferring probe for clock resources. > > Signed-off-by: Etienne Carriere > Signed-off-by: Christophe Roullier > --- > drivers/watchdog/stm32_iwdg.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/watchdog/stm32_iwdg.c b/drivers/watchdog/stm32_iwdg.c > index 25188d6bbe15..1b71c205cee0 100644 > --- a/drivers/watchdog/stm32_iwdg.c > +++ b/drivers/watchdog/stm32_iwdg.c > @@ -163,7 +163,8 @@ static int stm32_iwdg_clk_init(struct platform_device *pdev, > > wdt->clk_lsi = devm_clk_get(dev, "lsi"); > if (IS_ERR(wdt->clk_lsi)) { > - dev_err(dev, "Unable to get lsi clock\n"); > + if (PTR_ERR(wdt->clk_lsi) != -EPROBE_DEFER) > + dev_err(dev, "Unable to get lsi clock\n"); > return PTR_ERR(wdt->clk_lsi); I would suggest to use return dev_err_probe(dev, PTR_ERR(wdt->clk_lsi), "Unable to get lsi clock\n"); Guenter > } > > @@ -171,7 +172,8 @@ static int stm32_iwdg_clk_init(struct platform_device *pdev, > if (wdt->data->has_pclk) { > wdt->clk_pclk = devm_clk_get(dev, "pclk"); > if (IS_ERR(wdt->clk_pclk)) { > - dev_err(dev, "Unable to get pclk clock\n"); > + if (PTR_ERR(wdt->clk_pclk) != -EPROBE_DEFER) > + dev_err(dev, "Unable to get pclk clock\n"); > return PTR_ERR(wdt->clk_pclk); > } > > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel