From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0445EC2D0A3 for ; Fri, 6 Nov 2020 18:03:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7938820853 for ; Fri, 6 Nov 2020 18:03:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qnZIatm2"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M24HNHlp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7938820853 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WpF/xeYDBWznnxewtd9adlXd+/vGiL3Dm91hvQu4zaM=; b=qnZIatm2fBlqBn0xNu/rgz2zy woc6u642RYk0PHBjIHPiYqFMLjHM3NdUNxdCMCUeFN2Up/pcnq3r37Dd0Yd2fdRHax/j8BcgYmrn6 bR1LpX2cCU2ghajR5146/fFoVh7M1V2RB8n6UokjnoRYaxRrMyh99Hrx1DWO/yS0ypoHyXHJvE/TJ WNkyTiO7bUi39TBOBk6BhulZQDM94z2XxQSMJYDVtlN9AYvuw7Hid0CGuH7l9X1zS14JZu2BvHLQ0 viUCYfpnZvY5rQj0wl3kU3cOG83TEYu7cSxfv3MtwsVp3pDCi3uN4fONvOnvXjtp5HhYLmxQV/LVB aJvW70gBw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kb64z-0003UL-DB; Fri, 06 Nov 2020 18:03:17 +0000 Received: from mail-qt1-x844.google.com ([2607:f8b0:4864:20::844]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kb64x-0003Ti-D2 for linux-arm-kernel@lists.infradead.org; Fri, 06 Nov 2020 18:03:16 +0000 Received: by mail-qt1-x844.google.com with SMTP id 3so1369100qtx.3 for ; Fri, 06 Nov 2020 10:03:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=p1CcGa5j+LtJL5zURX6fDA5w3O8+Vz5UmqHSHkyTHyI=; b=M24HNHlp2Av/ocP/HGwx3Kfvpq/m2n7nwu3HWio44Ma0zLCwSG6KK+jBNEjW2t/mVc 2dV1A4AFVHInwbI8eMn6R6RRtsPKyWNYfCrhRhF11AixmfINzps6OPhE4oHI8EQnk/yh d/ei6kv7tzW/15vtjRB8bMBp2+VOjdO5JHzcUsyB8LkmzR8/vVizjzUfn+P34qnbsndo 1pX6jGKVxX/8WuJv/PiD5dUFlR6JJgiF0KFnMLtqEOJzWxVDVWHjRRRt0gNHpvU54EE1 nSwxyMX1hlW+bStOrKd2jY3KUvWtXxJV291FDH8f9MXg4kz4rZfdx/i54l9jjMMLA7Fg 4Hdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=p1CcGa5j+LtJL5zURX6fDA5w3O8+Vz5UmqHSHkyTHyI=; b=PNnx9zq4JbHdW1vvuUZTq7VBMoYSIJ9cWs6dViiGayypS2yZik65r+SxHUFx/pHmiY VBpASwbMpgdRYTLG3hhYld9VpkuNIii8HQzr7u7sF5HFHQOUTibYtDDjuD/SjM66R4ja YAvAXngnzyqZ60kVKU3lKthZ3s72LIEus4Mo7PziJOby/2FKrm+k23lv4mKyr/8GarWn L+oirj+qJNuTrwklZNxZKbnFwnmcNohtCWWZ3CvSjUW14GYYA84QUprrLydRTiM04LKR sHtnEwhwR0IrapnM8gq0ErDgqhankRanidP6x3IDqVsFL7dB/1MAoiZ8tjyXIWCS0/M+ XRHg== X-Gm-Message-State: AOAM531nMg3YCbKot8c/bcA0Fqhl+pOMlM4EJ/fJIZKfJQYrJlXcBWR8 aHFrXmCcIXXo0a+OJ1yTk84= X-Google-Smtp-Source: ABdhPJy7PvOTlP6z2fkw7p/r4ZDxeOC9ZDf7brV+12OHkv0igghG75GEiUiDfAngXmxe30fv56Oeig== X-Received: by 2002:ac8:705b:: with SMTP id y27mr2626562qtm.192.1604685793651; Fri, 06 Nov 2020 10:03:13 -0800 (PST) Received: from ubuntu-m3-large-x86 ([2604:1380:45f1:1d00::1]) by smtp.gmail.com with ESMTPSA id d18sm996591qka.41.2020.11.06.10.03.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 10:03:12 -0800 (PST) Date: Fri, 6 Nov 2020 11:03:11 -0700 From: Nathan Chancellor To: Arnd Bergmann Subject: Re: [PATCH 1/2] arm: lib: xor-neon: remove unnecessary GCC < 4.6 warning Message-ID: <20201106180311.GC2959494@ubuntu-m3-large-x86> References: <20201106051436.2384842-1-adrian.ratiu@collabora.com> <20201106051436.2384842-2-adrian.ratiu@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201106_130315_460647_6BA9540C X-CRM114-Status: GOOD ( 24.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Adrian Ratiu , Nick Desaulniers , Russell King , "linux-kernel@vger.kernel.org" , clang-built-linux , Collabora kernel ML , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 06, 2020 at 03:46:36PM +0100, Arnd Bergmann wrote: > On Fri, Nov 6, 2020 at 6:14 AM Adrian Ratiu wrote: > > > > From: Nathan Chancellor > > > > Drop warning because kernel now requires GCC >= v4.9 after > > commit 6ec4476ac825 ("Raise gcc version requirement to 4.9"). > > > > Reported-by: Nick Desaulniers > > Signed-off-by: Nathan Chancellor > > Signed-off-by: Adrian Ratiu > > --- > > arch/arm/lib/xor-neon.c | 9 +-------- > > 1 file changed, 1 insertion(+), 8 deletions(-) > > > > diff --git a/arch/arm/lib/xor-neon.c b/arch/arm/lib/xor-neon.c > > index b99dd8e1c93f..e1e76186ec23 100644 > > --- a/arch/arm/lib/xor-neon.c > > +++ b/arch/arm/lib/xor-neon.c > > @@ -19,15 +19,8 @@ MODULE_LICENSE("GPL"); > > * -ftree-vectorize) to attempt to exploit implicit parallelism and emit > > * NEON instructions. > > */ > > -#if __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 6) > > +#ifdef CONFIG_CC_IS_GCC > > #pragma GCC optimize "tree-vectorize" > > -#else > > -/* > > - * While older versions of GCC do not generate incorrect code, they fail to > > - * recognize the parallel nature of these functions, and emit plain ARM code, > > - * which is known to be slower than the optimized ARM code in asm-arm/xor.h. > > - */ > > -#warning This code requires at least version 4.6 of GCC > > #endif > > I think we still need the #else path, otherwise we don't warn about > clang being broken here. > > If it is intentional that we now silently build this code with clang > without it working as intended, that should be mentioned in the > changelog. > > Arnd Maybe patch 2/2 should come before this one? With that patch, we are not even going to build this code so this patch purely becomes a "we do not support this GCC version anymore" cleanup patch. Cheers, Nathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel