From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AB80C2D0A3 for ; Fri, 6 Nov 2020 20:36:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EEAC320719 for ; Fri, 6 Nov 2020 20:36:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IRF1gboT"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lWoh3Sdh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EEAC320719 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RdpfmddwKWwiMGsAExrfP2zLwrNbONkqpCuBobNX3hs=; b=IRF1gboTiDPbDUCesZMQCXmXD iaB5d9Po5SLsqNBTmMvCOCWwBWtTx/+KQCLKMXi0jghekd8+CaqL5lx6CK9tUjtODyRtLmScf/Tc2 Xfxdr4O68EiHbhBzLEyd5NJeQdcWuONgHvNOluH3wuHc+10XuZIP/RXplrzJ5VEqwX95Kc7MaGQyW gOZGYGX41NtgbD2Z50zKQgD48JxaUn6PooAueRF4R4HlZCsB1LQpblK004RYzGMyKGOvTYpdW9Kjd ecuKNasd2uKvfEtcnH8Jb9K1iWKSU/JKFGwlukSsM8YZieqX8Vi3cMFU79hg/2wgOu1qi7fvhJy+I xkIW5tJgA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kb8Rc-0007IC-HD; Fri, 06 Nov 2020 20:34:48 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kb8RZ-0007HW-Dh for linux-arm-kernel@lists.infradead.org; Fri, 06 Nov 2020 20:34:46 +0000 Received: by mail-pf1-x441.google.com with SMTP id 10so2443913pfp.5 for ; Fri, 06 Nov 2020 12:34:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2KkxLBPEW3Bs3fGukbxI8lyHUIDDucrAm1orqPYuJAo=; b=lWoh3SdhQyLLcHfEZt+CX9NH2HIoW5TjSsyk6+DC1RTgYcVXCUhAxW/l+oAKy5c8NN PraVCVN8XoRu1sP8QbHvPz2vtbrW5fcQvUX1kQK6dk4F0DLXaEbzID8PmixICzG9kizO KwtmRB5gHJIZe17eOcuixQDgR4+NiP7idZNTl2S6GkqCqkLHuCXEfKopKCuXPOtDu867 xbvxKVVHpZAh5J47zImkM4PUKXGGFCB2lzGrN3uH7URITKcZIZb2/1A4V0tYK04mKzHa Tvbt034gyxcXEOFVtxFtmwIilAxw8Lo7DQtseixS2W+GAbYXYiRAp3gOk/zk+kQV/UfI QUwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2KkxLBPEW3Bs3fGukbxI8lyHUIDDucrAm1orqPYuJAo=; b=dP0ehoUpAjeYoJacBV9wwSFTdkeFwKTYeQSPVdA7eLfKc3iocAyl0p0e5aOgn7Yqqi +VtGV5PbfvcnGubfiHuUnqyi/jshDGWXn2r9UR6zrqQ5+aZnul/X/YxrAd2fpAUNyL/i et3xLYEDdebMrExK7cZVz94eoOVYzrBHn8YIt2FU5FDHo4yQN9r90ny9myyInuor/It2 +WxQ6D+OJ3MfqoOy8a2mdmto+SqueLjSt+a6nv5ecVeagX4BdW9tPQzPIp0w0oQoiIit 3j+3eDegyPElOHHxX+4Rmv2iyEzvKl1IX4FJo6kksbTr0T1HJ/krnNaDnC3kFV8FIf0t cp6Q== X-Gm-Message-State: AOAM530kbMnG8VYK7ux1kuD/SEuHKMc4AqBs1N4lCyj1f4+M2eW/jPqe JQdFBbqnXX0QBWwGFThDetj56Q== X-Google-Smtp-Source: ABdhPJzZvlRJNgQe9ztrxNrZsQvU9Rj1m2vXE53gBtkxweeX5ZPuHFK3ShkhcAGXF3+2X0lYdNprrg== X-Received: by 2002:a17:90b:e14:: with SMTP id ge20mr1363483pjb.78.1604694880658; Fri, 06 Nov 2020 12:34:40 -0800 (PST) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id q23sm3243713pfg.18.2020.11.06.12.34.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 12:34:40 -0800 (PST) Date: Fri, 6 Nov 2020 13:34:38 -0700 From: Mathieu Poirier To: Suzuki K Poulose Subject: Re: [PATCH v3 19/26] coresight: etm4x: Detect access early on the target CPU Message-ID: <20201106203438.GB3299843@xps15> References: <20201028220945.3826358-1-suzuki.poulose@arm.com> <20201028220945.3826358-21-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201028220945.3826358-21-suzuki.poulose@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201106_153445_501259_C95B974E X-CRM114-Status: GOOD ( 25.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: coresight@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 28, 2020 at 10:09:38PM +0000, Suzuki K Poulose wrote: > In preparation to detect the support for system instruction > support, move the detection of the device access to the target > CPU. > > Signed-off-by: Suzuki K Poulose > --- > .../coresight/coresight-etm4x-core.c | 45 ++++++++++++++++--- > 1 file changed, 40 insertions(+), 5 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c > index f038bb10bc78..308674ab746c 100644 > --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c > +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c > @@ -56,6 +56,11 @@ static u64 etm4_get_access_type(struct etmv4_config *config); > > static enum cpuhp_state hp_online; > > +struct etm_init_arg { s/etm_init_arg/etm4_init_arg > + struct etmv4_drvdata *drvdata; > + struct csdev_access *csa; > +}; > + > u64 etm4x_sysreg_read(struct csdev_access *csa, > u32 offset, > bool _relaxed, > @@ -669,6 +674,22 @@ static const struct coresight_ops etm4_cs_ops = { > .source_ops = &etm4_source_ops, > }; > > +static bool etm_init_iomem_access(struct etmv4_drvdata *drvdata, > + struct csdev_access *csa) > +{ > + *csa = CSDEV_ACCESS_IOMEM(drvdata->base); > + return true; > +} > + > +static bool etm_init_csdev_access(struct etmv4_drvdata *drvdata, > + struct csdev_access *csa) > +{ > + if (drvdata->base) > + return etm_init_iomem_access(drvdata, csa); > + > + return false; > +} Returning a boolean rather than an int for the above two functions seems odd to me. > + > static void etm4_init_arch_data(void *info) > { > u32 etmidr0; > @@ -677,11 +698,22 @@ static void etm4_init_arch_data(void *info) > u32 etmidr3; > u32 etmidr4; > u32 etmidr5; > - struct etmv4_drvdata *drvdata = info; > - struct csdev_access tmp_csa = CSDEV_ACCESS_IOMEM(drvdata->base); > - struct csdev_access *csa = &tmp_csa; > + struct etm_init_arg *init_arg = info; > + struct etmv4_drvdata *drvdata; > + struct csdev_access *csa; > int i; > > + drvdata = init_arg->drvdata; > + csa = init_arg->csa; > + > + /* > + * If we are unable to detect the access mechanism, > + * or unable to detect the trace unit type, fail > + * early. > + */ > + if (!etm_init_csdev_access(drvdata, csa)) > + return; > + > /* Make sure all registers are accessible */ > etm4_os_unlock_csa(drvdata, csa); > etm4_cs_unlock(drvdata, csa); > @@ -1524,6 +1556,7 @@ static int etm4_probe(struct amba_device *adev, const struct amba_id *id) > struct etmv4_drvdata *drvdata; > struct resource *res = &adev->res; > struct coresight_desc desc = { 0 }; > + struct etm_init_arg init_arg = { 0 }; > > drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL); > if (!drvdata) > @@ -1551,7 +1584,6 @@ static int etm4_probe(struct amba_device *adev, const struct amba_id *id) > return PTR_ERR(base); > > drvdata->base = base; > - desc.access = CSDEV_ACCESS_IOMEM(base); > > spin_lock_init(&drvdata->spinlock); > > @@ -1563,8 +1595,11 @@ static int etm4_probe(struct amba_device *adev, const struct amba_id *id) > if (!desc.name) > return -ENOMEM; > > + init_arg.drvdata = drvdata; > + init_arg.csa = &desc.access; > + > if (smp_call_function_single(drvdata->cpu, > - etm4_init_arch_data, drvdata, 1)) > + etm4_init_arch_data, &init_arg, 1)) > dev_err(dev, "ETM arch init failed\n"); > > if (etm4_arch_supported(drvdata->arch) == false) > -- > 2.24.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel