From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03EB3C388F9 for ; Sun, 8 Nov 2020 13:22:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E01A206F4 for ; Sun, 8 Nov 2020 13:22:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="amzNaasn"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="B4LVcidP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E01A206F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=K6ErzvXrVowcyl5SNY4oQh0LLcRgq0Q2+fsQXWVJGDk=; b=amzNaasn3aO0eR/+h0EiCQ5A0 4dWi4OMKTuKCozerruivfr/OF1FBlHLQMBaNDFpUA7fWSv67CUQkU4CWgeE/fXccPhZw8pL63ihsl VJyrnjCTdkdGnReIgBFPAvH3oBW52ejeWvidlwuNybmbQY8M19ePtobA5Zs9m4PhyVy5iXHKhA2Xq 0vzGVJJPXtJKjLJtG2L5eRDwhKAOx/q+tjil0Qujpt4i9K5YQyLoiDO6LyIyXKOzTrjHW39lJS4iO 2DffZ7+bCzODyaCQdbf8p0xPAbRsNtKrTPntNwKE67q94/KfzN5q68opibXmrEnKyQrV9+owFUAwG +SJ4wM/qA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kbkdY-0007QS-72; Sun, 08 Nov 2020 13:21:40 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kbkdU-0007PV-Oj; Sun, 08 Nov 2020 13:21:37 +0000 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 71619206E3; Sun, 8 Nov 2020 13:21:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604841695; bh=SkSaZbbxbQKlOyOPpNzaJmiIA3JNvn8dwgGWjfjN+QE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B4LVcidPH89nRcLhaaOqQuqZ//Xwx4z/bwAId7RogC4qHijueLwYDdlMOGsBajKnw ixHHmNnGau6nQGSI7eZSMZg+vvZeoN5wJIbx9j+OSjsobsDFy5NY2O/cM0kM0NRKJe UDvCl7vF/UFzDXD/gth7CDHwo3hiY2AO9NNQvFgE= Date: Sun, 8 Nov 2020 08:21:34 -0500 From: Sasha Levin To: Martin Blumenstingl Subject: Re: [PATCH AUTOSEL 5.4 05/24] arm64: dts: amlogic: meson-g12: use the G12A specific dwmac compatible Message-ID: <20201108132134.GQ2092@sasha-vm> References: <20201103012007.183429-1-sashal@kernel.org> <20201103012007.183429-5-sashal@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201108_082136_911762_59CB8351 X-CRM114-Status: GOOD ( 14.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Neil Armstrong , Kevin Hilman , linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 03, 2020 at 06:53:17AM +0100, Martin Blumenstingl wrote: >Hi Sasha, > >On Tue, Nov 3, 2020 at 2:20 AM Sasha Levin wrote: >> >> From: Martin Blumenstingl >> >> [ Upstream commit 1fdc97ae450ede2b4911d6737a57e6fca63b5f4a ] >> >> We have a dedicated "amlogic,meson-g12a-dwmac" compatible string for the >> Ethernet controller since commit 3efdb92426bf4 ("dt-bindings: net: >> dwmac-meson: Add a compatible string for G12A onwards"). >> Using the AXG compatible string worked fine so far because the >> dwmac-meson8b driver doesn't handle the newly introduced register bits >> for G12A. However, once that changes the driver must be probed with the >> correct compatible string to manage these new register bits. >> >> Signed-off-by: Martin Blumenstingl >> Reviewed-by: Neil Armstrong >> Signed-off-by: Kevin Hilman >> Link: https://lore.kernel.org/r/20200925211743.537496-1-martin.blumenstingl@googlemail.com >> Signed-off-by: Sasha Levin >if this patch will be included in 5.4-stable then please also backport >the following two commits: >- 3efdb92426bf4 ("dt-bindings: net: dwmac-meson: Add a compatible >string for G12A onwards") >- a4f63342d03d2d ("net: stmmac: dwmac-meson8b: add a compatible string >for G12A SoCs") > >Without these above two commits we'll lose Ethernet connectivity >because there's no G12A compatible string in 5.4 yet > >The quick solution would be to not backport this patch because the >driver in question doesn't do anything with the new compatible string >yet. I'll drop it from older branches that don't have those commits, thanks! -- Thanks, Sasha _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel