From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4F00C388F9 for ; Sun, 8 Nov 2020 18:10:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7AA1D206F4 for ; Sun, 8 Nov 2020 18:10:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="wnLCofeW"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HjUj3vk1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7AA1D206F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alum.mit.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=22A6eoICZVsTS3nSaHIxmOnaEDuF0cJNKWE+B38GfHQ=; b=wnLCofeWGCQm4mqIs83GjhJVk OSZs8T3h2IV8eQVOfJMgQYw0cZ/4K4filbQQ/8KQ/C1mi4O1WAOMNSVjprK4fgDKtabS2TfmJHBBB Uu/lFYVtIIZkLuTaZ4FsRd/l6zKe3yg79mpqTvZ2TYy/8B0z7AQ3ww/+X/eXVhrrpK8oR149xZk0r 7Y0ZZ5VBjTnEc3bY8HZZqKQK7nUTsWMOkoXW+JkO/pFK4iNc1Idfe5CZitQ/vtmGREnufMk20cbXF ex2v894aRksB/EJoYHayj0TMKQameNs9R5sOTCUjPOmLfSKM3hCYtaLY1MFzMs1XTJeH2iNqDt5xu mpzMm1jwg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kbp8P-0007RE-MV; Sun, 08 Nov 2020 18:09:49 +0000 Received: from mail-qt1-x844.google.com ([2607:f8b0:4864:20::844]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kbp8M-0007Qg-Rh for linux-arm-kernel@lists.infradead.org; Sun, 08 Nov 2020 18:09:48 +0000 Received: by mail-qt1-x844.google.com with SMTP id i12so4527125qtj.0 for ; Sun, 08 Nov 2020 10:09:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=G5g4G9/pMoKvIIjm2dH1OzGwv4YgDFb04vpHh+6il6Q=; b=HjUj3vk1YvHJ/1TU09xxN1u4zHLyXww0OEl1jfnbys6vjzhS8yumDvyL2d6SEK55xh qjO5EbMCMn/T+Hx0wpY4vp5QLy3rz76n75fLx+jOaJC09yWFm/9byZ+qslhAfeyO2804 0MR5cGwTPd5YOGR4DxUzCjbqsVQrFarElHvrRhqFl5t4hKOnXlTndPe2gWJCVizOs1D3 NG8Q2Zx+sEci1XEbabGWva1Q1e7VJHL6SL2aFYLjobrqUi1Otmqg7hMI+J8JqLwnQMOo FEc28LVi9p2R+n+5OV46xPleRYZTOQ4rFB9ZdoJpZ+EySM9wCTfx3YdoYA2GRJx2o8jA g5Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:date:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=G5g4G9/pMoKvIIjm2dH1OzGwv4YgDFb04vpHh+6il6Q=; b=kRtjO8CY3IDi52gcVXMNrdT2mSiCuXmaD2PF7vukcDXDdhk05wxR6JWKT6DubqqW1U rkm5iegKNfFqO2AyDzNCSrXJCfoZyBa1sv08SN0kdlNyjloWFT5MqS9+XY4X9VS5/RCb KUc29xH6+FgOBYNv8481LIHWYpmPOg323uSqRvffag4WQVAqsXYUpZY8Ih5fLymNt7jL iLj9IV+SVRbsUoG7AmFHZ5eqr48cvkyAfbZ/hCB37kG1uPHZaHutC9IrdrSKSExR4i7x /ugJh3cR0JxNi6AqZoLSaYoKAvKQG8zTGoiH+siRysIllx7qmYqPq771clXhzqURRz57 4b4A== X-Gm-Message-State: AOAM530TVhWkqa0+eOFFgK5E2/mkL+yy/IycUOoIrR5CpMLXTHbb5Azv KwUSmixO1+NBypYAIpe/h6g= X-Google-Smtp-Source: ABdhPJyFsrYkJzsxcPe5TPtLx5Vk7cOEj9xIJsl1xckxeybmWUJdce8YE/1T+O4NhqRPRaTNgv2lJw== X-Received: by 2002:ac8:b87:: with SMTP id h7mr10068398qti.87.1604858984780; Sun, 08 Nov 2020 10:09:44 -0800 (PST) Received: from rani.riverdale.lan ([2001:470:1f07:5f3::b55f]) by smtp.gmail.com with ESMTPSA id q70sm4790359qka.87.2020.11.08.10.09.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Nov 2020 10:09:44 -0800 (PST) From: Arvind Sankar X-Google-Original-From: Arvind Sankar Date: Sun, 8 Nov 2020 13:09:42 -0500 To: Arvind Sankar Subject: Re: [PATCH 2/2] arm: lib: xor-neon: disable clang vectorization Message-ID: <20201108180942.GA226037@rani.riverdale.lan> References: <20201106051436.2384842-1-adrian.ratiu@collabora.com> <20201106051436.2384842-3-adrian.ratiu@collabora.com> <20201108174014.GA219672@rani.riverdale.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201108174014.GA219672@rani.riverdale.lan> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201108_130946_976159_6CAC069D X-CRM114-Status: GOOD ( 34.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Adrian Ratiu , Nick Desaulniers , Russell King , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Nathan Chancellor , kernel@collabora.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Nov 08, 2020 at 12:40:14PM -0500, Arvind Sankar wrote: > On Fri, Nov 06, 2020 at 07:14:36AM +0200, Adrian Ratiu wrote: > > Due to a Clang bug [1] neon autoloop vectorization does not happen or > > happens badly with no gains and considering previous GCC experiences > > which generated unoptimized code which was worse than the default asm > > implementation, it is safer to default clang builds to the known good > > generic implementation. > > > > The kernel currently supports a minimum Clang version of v10.0.1, see > > commit 1f7a44f63e6c ("compiler-clang: add build check for clang 10.0.1"). > > > > When the bug gets eventually fixed, this commit could be reverted or, > > if the minimum clang version bump takes a long time, a warning could > > be added for users to upgrade their compilers like was done for GCC. > > > > [1] https://bugs.llvm.org/show_bug.cgi?id=40976 > > > > Signed-off-by: Adrian Ratiu > > --- > > arch/arm/include/asm/xor.h | 3 ++- > > arch/arm/lib/Makefile | 3 +++ > > arch/arm/lib/xor-neon.c | 4 ++++ > > 3 files changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/include/asm/xor.h b/arch/arm/include/asm/xor.h > > index aefddec79286..49937dafaa71 100644 > > --- a/arch/arm/include/asm/xor.h > > +++ b/arch/arm/include/asm/xor.h > > @@ -141,7 +141,8 @@ static struct xor_block_template xor_block_arm4regs = { > > NEON_TEMPLATES; \ > > } while (0) > > > > -#ifdef CONFIG_KERNEL_MODE_NEON > > +/* disabled on clang/arm due to https://bugs.llvm.org/show_bug.cgi?id=40976 */ > > +#if defined(CONFIG_KERNEL_MODE_NEON) && !defined(CONFIG_CC_IS_CLANG) > > > > extern struct xor_block_template const xor_block_neon_inner; > > > > diff --git a/arch/arm/lib/Makefile b/arch/arm/lib/Makefile > > index 6d2ba454f25b..53f9e7dd9714 100644 > > --- a/arch/arm/lib/Makefile > > +++ b/arch/arm/lib/Makefile > > @@ -43,8 +43,11 @@ endif > > $(obj)/csumpartialcopy.o: $(obj)/csumpartialcopygeneric.S > > $(obj)/csumpartialcopyuser.o: $(obj)/csumpartialcopygeneric.S > > > > +# disabled on clang/arm due to https://bugs.llvm.org/show_bug.cgi?id=40976 > > +ifndef CONFIG_CC_IS_CLANG > > ifeq ($(CONFIG_KERNEL_MODE_NEON),y) > > NEON_FLAGS := -march=armv7-a -mfloat-abi=softfp -mfpu=neon > > CFLAGS_xor-neon.o += $(NEON_FLAGS) > > obj-$(CONFIG_XOR_BLOCKS) += xor-neon.o > > endif > > +endif > > diff --git a/arch/arm/lib/xor-neon.c b/arch/arm/lib/xor-neon.c > > index e1e76186ec23..84c91c48dfa2 100644 > > --- a/arch/arm/lib/xor-neon.c > > +++ b/arch/arm/lib/xor-neon.c > > @@ -18,6 +18,10 @@ MODULE_LICENSE("GPL"); > > * Pull in the reference implementations while instructing GCC (through > > * -ftree-vectorize) to attempt to exploit implicit parallelism and emit > > * NEON instructions. > > + > > + * On Clang the loop vectorizer is enabled by default, but due to a bug > > + * (https://bugs.llvm.org/show_bug.cgi?id=40976) vectorization is broke > > + * so xor-neon is disabled in favor of the default reg implementations. > > */ > > #ifdef CONFIG_CC_IS_GCC > > #pragma GCC optimize "tree-vectorize" > > -- > > 2.29.0 > > > > It's actually a bad idea to use #pragma GCC optimize. This is basically > the same as tagging all the functions with __attribute__((optimize)), > which GCC does not recommend for production use, as it _replaces_ > optimization options rather than appending to them, and has been > observed to result in dropping important compiler flags. > > There've been a few discussions recently around other such cases: > https://lore.kernel.org/lkml/20201028171506.15682-1-ardb@kernel.org/ > https://lore.kernel.org/lkml/20201028081123.GT2628@hirez.programming.kicks-ass.net/ > > For this file, given that it is supposed to use -ftree-vectorize for the > whole file anyway, is there any reason it's not just added to CFLAGS via > the Makefile? This seems to be the only use of pragma optimize in the > kernel. Eg, this shows that the pragma results in dropping -fno-strict-aliasing. https://godbolt.org/z/1nfrKT The first function does not use vectorization because s and s->a might alias. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel