From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36C85C2D0A3 for ; Mon, 9 Nov 2020 11:28:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD9F2206ED for ; Mon, 9 Nov 2020 11:28:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pnYbZ0iK"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="uKXn/WS5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD9F2206ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xPuNlExSe6ROwzmTL7nYyrli+9rcaRx9FC0RL+5hDlY=; b=pnYbZ0iK0tQFlsM3hXf+hqwOL X5W9MxoDH4Txyclec+Ez8GCA9jChv8Cy48y8WBCO+q1zHlk57/3x+dlYAFCJEf8iHKmuK5iUgHIvG CBlMFhP3P/hv6/pdaVUdvNtJyFPlo5RsyDiMgXYyWF9A5oYumKcUW94uJEFewuoqCon2OopTamTxX K7Zok3/K73Ken1McUz+5s60LSSycOx/kq31YzEwBPRz7B+iSaspDnVppZaDEEkboB6YIf5BGi+80Y 5SnIaramkONcBsY98nS3HnyKCfDZCGCmwu/ZauwY1mEtcfK0UAypHmZlEcLQO/UN1jFxF966UeD9H LvV05fa/Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kc5KO-0002uc-I5; Mon, 09 Nov 2020 11:27:16 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kc5KJ-0002sc-8T for linux-arm-kernel@lists.infradead.org; Mon, 09 Nov 2020 11:27:13 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 73ADD206ED; Mon, 9 Nov 2020 11:27:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604921230; bh=qdycJ+u4UuMDCCZqeoQqE4jvV2ZHD4y67TPD1O4A2bs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uKXn/WS5gLoLJ/gQ7rPUxtWhhP97Ad00UBPTPc2b/XH033JTe9wXrlYv6VpYGM5/7 yeU8xOP9iK9U8b6JLbO9uFk20NEF2Lk3xyf4k9Fm6VlybrEh351pa4RCa5Kp8Mm/AH 9s0L9BrIuvX/ZU7Kudp95REDEqNSlJZZaFC1F+po= Date: Mon, 9 Nov 2020 11:27:06 +0000 From: Will Deacon To: Ross Meikleham Subject: Re: [PATCH] arm64: Kconfig RANDOMIZE_MODULE_REGION_FULL correction Message-ID: <20201109112705.GC14356@willie-the-truck> References: <20201107143119.GA98510@Charon.home> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201107143119.GA98510@Charon.home> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201109_062711_455219_EB30D920 X-CRM114-Status: GOOD ( 23.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: catalin.marinas@arm.com, trivial@kernel.org, ardb@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ross, [+Ard] On Sat, Nov 07, 2020 at 02:31:19PM +0000, Ross Meikleham wrote: > In the 5.1.5 Kernel RANDOMIZE_MODULE_REGION_FULL was a 4GB window, > however this was changed to 2GB from 5.1.6 5.1.5 and 5.1.6 are both stable releases, so it's not terribly useful to talk about them here and you can't really infer much about when the change was introduced. Please can you refer to the commit instead? I think you want: commit b2eed9b58811 ("arm64/kernel: kaslr: reduce module randomization range to 2 GB") > (see /arch/arm64/kernel/kaslr.c). This updates the (you can remove the "see ..." part as it's obvious once you refer to the commit. > config description for RANDOMIZE_MODULE_REGION_FULL in /arch/arm64/Kconfig > to reflect this. There's no need to say "This...". Documentation/process/submitting-patches.rst has a bit about how to write commit messages, but I suggest changing this last sentence to: Fix the stale Kconfig entry for RANDOMIZE_MODULE_REGION_FULL. > Signed-off-by: Ross Meikleham > --- > arch/arm64/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 6d232837cbee..b8fd2c590057 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -1782,11 +1782,11 @@ config RANDOMIZE_BASE > If unsure, say N. > > config RANDOMIZE_MODULE_REGION_FULL > - bool "Randomize the module region over a 4 GB range" > + bool "Randomize the module region over a 2 GB range" > depends on RANDOMIZE_BASE > default y > help > - Randomizes the location of the module region inside a 4 GB window > + Randomizes the location of the module region inside a 2 GB window > covering the core kernel. This way, it is less likely for modules > to leak information about the location of core kernel data structures > but it does imply that function calls between modules and the core Patch looks fine. Please send a v2 with the commit message sorted out and I can queue it as a fix. Cheers, Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel