From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C185C2D0A3 for ; Mon, 9 Nov 2020 11:49:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2B3CF206ED for ; Mon, 9 Nov 2020 11:49:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WR9aTZHU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B3CF206ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Zj4lkrdyUkxSNTSS2PH5SZ0/zNa+F594xO6FXcrPi/k=; b=WR9aTZHUB/9sVnbrumAESWOU/ Z1nXZ4WbMMlpGeAnzituOZHb/o1paCKpPmAa06XOcpr/pd9QiRkOOTTaEuGOm00mjiJpjyDpzD7W8 TrXOoC+KcicnB+obbK9K0K+2wO9Wo0HSyaoFrv21nFRy5nENZ1P8OpeOlg3+SQEigBBOCx2zgl7bI G05xOU1VUoF/P2QcnnvuEjSm+SYGLueoeMTM3FWlQQQ4a1Ci02b+2Yktmw+3cJOlukrTaWskv0mbr KeYsa/2mgm6NHcBpaqMNXsqka/89D2Nm4CyZjOOK2Q3Qomkm5ov8JP6SG/leayYewnzq+iHpSoT0l mkSdXOk/g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kc5f6-0003tX-WB; Mon, 09 Nov 2020 11:48:41 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kc5f1-0003qj-RB for linux-arm-kernel@lists.infradead.org; Mon, 09 Nov 2020 11:48:37 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 35A66106F; Mon, 9 Nov 2020 03:48:34 -0800 (PST) Received: from C02TD0UTHF1T.local (unknown [10.57.58.112]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A77F93F718; Mon, 9 Nov 2020 03:48:32 -0800 (PST) Date: Mon, 9 Nov 2020 11:48:25 +0000 From: Mark Rutland To: Anshuman Khandual Subject: Re: [PATCH] arm64/smp: Drop the macro S(x,s) Message-ID: <20201109114825.GA64518@C02TD0UTHF1T.local> References: <1604921916-23368-1-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1604921916-23368-1-git-send-email-anshuman.khandual@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201109_064836_043590_F2EFBD2F X-CRM114-Status: GOOD ( 17.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marc Zyngier Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 09, 2020 at 05:08:36PM +0530, Anshuman Khandual wrote: > Mapping between IPI type index and its string is direct without requiring > an additional offset. Hence the existing macro S(x, s) is now redundant > and can just be dropped. This also makes the code clean and simple. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Mark Rutland > Cc: Marc Zyngier > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual Nice cleanup! Acked-by: Mark Rutland Mark. > --- > arch/arm64/kernel/smp.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c > index 09c96f57818c..65d18a618abe 100644 > --- a/arch/arm64/kernel/smp.c > +++ b/arch/arm64/kernel/smp.c > @@ -786,14 +786,13 @@ void __init smp_prepare_cpus(unsigned int max_cpus) > } > > static const char *ipi_types[NR_IPI] __tracepoint_string = { > -#define S(x,s) [x] = s > - S(IPI_RESCHEDULE, "Rescheduling interrupts"), > - S(IPI_CALL_FUNC, "Function call interrupts"), > - S(IPI_CPU_STOP, "CPU stop interrupts"), > - S(IPI_CPU_CRASH_STOP, "CPU stop (for crash dump) interrupts"), > - S(IPI_TIMER, "Timer broadcast interrupts"), > - S(IPI_IRQ_WORK, "IRQ work interrupts"), > - S(IPI_WAKEUP, "CPU wake-up interrupts"), > + [IPI_RESCHEDULE] = "Rescheduling interrupts", > + [IPI_CALL_FUNC] = "Function call interrupts", > + [IPI_CPU_STOP] = "CPU stop interrupts", > + [IPI_CPU_CRASH_STOP] = "CPU stop (for crash dump) interrupts", > + [IPI_TIMER] = "Timer broadcast interrupts", > + [IPI_IRQ_WORK] = "IRQ work interrupts", > + [IPI_WAKEUP] = "CPU wake-up interrupts", > }; > > static void smp_cross_call(const struct cpumask *target, unsigned int ipinr); > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel