From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: devicetree <devicetree@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Lars Povlsen <lars.povlsen@microchip.com>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v8 2/3] pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO
Date: Mon, 9 Nov 2020 16:27:48 +0100 [thread overview]
Message-ID: <20201109152748.GA1691943@piout.net> (raw)
In-Reply-To: <CAHp75Vc7eRDq5wUyUdvCZCnV_VS+afGnbJpQeDSeXVE9K_MGng@mail.gmail.com>
On 09/11/2020 17:16:49+0200, Andy Shevchenko wrote:
> On Mon, Nov 9, 2020 at 4:32 PM Alexandre Belloni
> <alexandre.belloni@bootlin.com> wrote:
> > On 09/11/2020 16:17:40+0200, Andy Shevchenko wrote:
> > > > + if (input != bank->is_input) {
> > >
> > > > + dev_err(pctldev->dev, "Pin %d direction as %s is not possible\n",
> > > > + pin, input ? "input" : "output");
> > >
> > > Do we need this noise? Isn't user space getting a proper error code as
> > > per doc and can handle this?
> >
> > Why would userspace get the error code?
>
> Huh?! Why it shouldn't. How will users know if they are doing something wrong?
>
> > Userspace should never have to
> > handle gpios directly or you are doing something wrong.
>
> This is true, but check how error codes are propagated to the user space.
>
your point is to remove an error message because the error may be
propagated to userspace. My point is that userspace should never use
gpios and the kernel has to be the consumer. I don't see how your answer
is relevant here. Did you already check all the call sites from the
kernel too?
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-09 15:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 13:26 [PATCH v8 0/3] Adding support for Microchip/Microsemi serial GPIO controller Lars Povlsen
2020-11-09 13:26 ` [PATCH v8 1/3] dt-bindings: pinctrl: Add bindings for pinctrl-microchip-sgpio driver Lars Povlsen
2020-11-09 13:26 ` [PATCH v8 2/3] pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO Lars Povlsen
2020-11-09 14:17 ` Andy Shevchenko
2020-11-09 14:32 ` Alexandre Belloni
2020-11-09 15:16 ` Andy Shevchenko
2020-11-09 15:27 ` Alexandre Belloni [this message]
2020-11-09 16:15 ` Andy Shevchenko
2020-11-09 16:22 ` Alexandre Belloni
2020-11-10 15:59 ` Lars Povlsen
2020-11-10 15:51 ` Lars Povlsen
2020-11-10 16:26 ` Andy Shevchenko
2020-11-11 8:51 ` Lars Povlsen
2020-11-11 11:26 ` Andy Shevchenko
2020-11-11 11:53 ` Lars Povlsen
2020-11-09 13:26 ` [PATCH v8 3/3] arm64: dts: sparx5: Add SGPIO devices Lars Povlsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109152748.GA1691943@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).