From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D37B8C5517A for ; Mon, 9 Nov 2020 17:21:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F4E020897 for ; Mon, 9 Nov 2020 17:21:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pYJyxlDh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F4E020897 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RRfKgvGcONp1Rf+WseQ0jZEqUbDTcM24xiZx1m1sTds=; b=pYJyxlDhmyEQ+JjcClJMjfUnt VCM91fuqRTNrnQrsRgqp+1+n1qKq0Kub7G7f+UyzymGq6zrKos00wnVFFhk1Pqp+MBs5b0LJksbMB x4JT6rz7e/nohVw3j1SWKr7XWbeQwB8Elm3wmBMAFAPPjhodUY3eexchZaEVTHskeeDHYMhSt7RqM vb+eiPw7ntcXv0z6+uoNlzu4oTsaKbgDgT2JLYBRmZ1Szdkwv3t/jfuj8YE5fYbz/K+xmny4/DLR9 bV5ikXhDQQqt7lz9rQtnxZnxhIhK3C4zqn8UmB+etfaVjoi+bEg9YrwXn4vYMPHGQoNBjFdm7egq4 XdMCKGHtA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcAr8-0002cx-2W; Mon, 09 Nov 2020 17:21:26 +0000 Received: from mga11.intel.com ([192.55.52.93]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcAr5-0002cJ-77 for linux-arm-kernel@lists.infradead.org; Mon, 09 Nov 2020 17:21:24 +0000 IronPort-SDR: 0EQ+aHuritCa70e3URMchH9EazbomWm6FfdVH5k6v+0hWYrPPsMzViyFDxMH+tLpj+tvWrCgcx UghKd0GyaT0w== X-IronPort-AV: E=McAfee;i="6000,8403,9800"; a="166329502" X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="166329502" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2020 09:21:20 -0800 IronPort-SDR: A4eSjrjqpfJfkTizVTZkSMuHaiIfk/cCuliExX/anFiyOMtQtGl5XfEkTN0CFmOznpRKuBLyqf JMOZ8d3gfM7A== X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="530836851" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2020 09:21:18 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kcAs0-005F7O-G2; Mon, 09 Nov 2020 19:22:20 +0200 Date: Mon, 9 Nov 2020 19:22:20 +0200 From: Andy Shevchenko To: William Breathitt Gray Subject: Re: [PATCH v12 4/4] gpio: xilinx: Utilize generic bitmap_get_value and _set_value Message-ID: <20201109172220.GI4077@smile.fi.intel.com> References: <15a044d3ba23f00c31fd09437bdd3e5924bb91cd.1603055402.git.syednwaris@gmail.com> <20201101150033.GA68138@shinobu> <20201109123411.GA19869@syed> <20201109134128.GA5596@shinobu> <20201109164529.GA28710@syed.domain.name> <20201109171140.GA14045@shinobu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201109171140.GA14045@shinobu> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201109_122123_480564_5328713F X-CRM114-Status: GOOD ( 19.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Bartosz Golaszewski , Linus Walleij , "linux-kernel@vger.kernel.org" , Michal Simek , "open list:GPIO SUBSYSTEM" , Andrew Morton , Syed Nayyar Waris , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 09, 2020 at 12:11:40PM -0500, William Breathitt Gray wrote: > On Mon, Nov 09, 2020 at 10:15:29PM +0530, Syed Nayyar Waris wrote: > > On Mon, Nov 09, 2020 at 03:41:53PM +0100, Arnd Bergmann wrote: ... > > static inline void bitmap_set_value(unsigned long *map, > > - unsigned long value, > > + unsigned long value, const size_t length, > > unsigned long start, unsigned long nbits) > > { > > const size_t index = BIT_WORD(start); > > @@ -15,6 +15,10 @@ static inline void bitmap_set_value(unsigned long *map, > > } else { > > map[index + 0] &= ~BITMAP_FIRST_WORD_MASK(start); > > map[index + 0] |= value << offset; > > + > > + if (index + 1 >= length) > > + __builtin_unreachable(); > > + > > map[index + 1] &= ~BITMAP_LAST_WORD_MASK(start + nbits); > > map[index + 1] |= value >> space; > > } > > Hi Syed, > > Let's rename 'length' to 'nbits' as Arnd suggested, and rename 'nbits' > to value_width. length here is in longs. I guess this is the point of entire patch. But to me sounds like it would be better to have simply bitmap_set_value64() / bitmap_set_value32() with proper optimization done and forget about variadic ones for now. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel