From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B71C8C2D0A3 for ; Mon, 9 Nov 2020 22:07:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 398F92068D for ; Mon, 9 Nov 2020 22:07:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TcRm2/6/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 398F92068D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+YF5w75fftrP/a/Yk9wdr+5kWse7UicPnklYKJ25UnM=; b=TcRm2/6/d652GFmHMTVAQMdnS FtXIkYB9HNUbF/uFOjo8Kuc6CLGuz512wdadqEf3fj4MdT8IBBS+QfigAZW6kxzjYXzjScFv2s2J+ /Gs4HGjPK6I2dhKnLU6dCyCHlQHvGbreYuQXgZqdk5nU5iWELElBSdsogMV7xYI1+Uw4hDQhW7l5L ZesJaFpmVkHoeDD03EU5o34uHZtQz+FddDCHojxmnR02/kcXBCHTtepZ4HXMMrLNIb2NxwP2oDV9Y Sns4qBkb/DD5ZcR9ZP7jR5ciw21O/Vhpb+8sBNiuMhCUzVBKK2zYsE5rsBbCJQoMVbW0lYDt5VMPa m6RG1y1bw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcFIK-00065L-OW; Mon, 09 Nov 2020 22:05:48 +0000 Received: from mail-ot1-f65.google.com ([209.85.210.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcFII-00064H-4Q for linux-arm-kernel@lists.infradead.org; Mon, 09 Nov 2020 22:05:46 +0000 Received: by mail-ot1-f65.google.com with SMTP id k3so10519763otp.12 for ; Mon, 09 Nov 2020 14:05:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=52NYZ271dr+PKdWpg4JTe6Y+p4BKdJ9pDbLvzjgDFuc=; b=KEgxaAufOKaVKFX7les4FXES1SK9NtqJXi5Ha6fckusIbUXRdsNVE/xi3U3uVHOVua H45zrlMZwkOENLwcx+CNqQP0TBiTXnWJVwGSb0QuBj1+/GHc64Dbnd7qhHWMIGn6YVeO 6NywTAwF/oYiRExTFZ6LC4Q0SalZziVVASQ+noheWC591MgtJxhifLgnE8nM+MFm7qmE Svpuk0HE2lmajzjsXdZhx2wkh7ow/MbeR5SbVrrI7YRwnej+A4FQstGJww9xsOjP2rkw jgfAcoUEWVtzvL+w1cRowWuwfCfwDtVCX5kKSf/LjNZF755YXobqm52LNPn4lqNq4hoi L5QQ== X-Gm-Message-State: AOAM532eHCuiz7PDFkCp8qfVYEfByCIJWf0D1LYHxv/OmsVXiCqkf1YS QMmMl0YJ3UyVI8cueeA6eQ== X-Google-Smtp-Source: ABdhPJxx4SE/QHPlDjjGj+QgeFGayPPDmyrll7ozw0tT+d61+YMddA1OvZIQaqNq3R3mJqhxC0OBmw== X-Received: by 2002:a9d:3b84:: with SMTP id k4mr12695420otc.4.1604959545107; Mon, 09 Nov 2020 14:05:45 -0800 (PST) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id b92sm2802672otc.70.2020.11.09.14.05.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 14:05:44 -0800 (PST) Received: (nullmailer pid 1838533 invoked by uid 1000); Mon, 09 Nov 2020 22:05:43 -0000 Date: Mon, 9 Nov 2020 16:05:43 -0600 From: Rob Herring To: Michael Walle Subject: Re: [PATCH v3 3/9] clk: qoriq: provide constants for the type Message-ID: <20201109220543.GA1835644@bogus> References: <20201108185113.31377-1-michael@walle.cc> <20201108185113.31377-4-michael@walle.cc> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201108185113.31377-4-michael@walle.cc> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201109_170546_191539_203FB03C X-CRM114-Status: GOOD ( 23.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Xiaowei Bao , Stephen Boyd , Vladimir Oltean , Michael Turquette , linux-kernel@vger.kernel.org, Li Yang , Ashish Kumar , "Y . b . Lu" , Shawn Guo , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Nov 08, 2020 at 07:51:07PM +0100, Michael Walle wrote: > To avoid future mistakes in the device tree for the clockgen module, add > constants for the clockgen subtype as well as a macro for the PLL > divider. > > Signed-off-by: Michael Walle > --- > Changes since v2: > - new patch > > drivers/clk/clk-qoriq.c | 13 +++++++------ > include/dt-bindings/clock/fsl,qoriq-clockgen.h | 15 +++++++++++++++ > 2 files changed, 22 insertions(+), 6 deletions(-) > create mode 100644 include/dt-bindings/clock/fsl,qoriq-clockgen.h > > diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c > index 46101c6a20f2..70aa521e7e7f 100644 > --- a/drivers/clk/clk-qoriq.c > +++ b/drivers/clk/clk-qoriq.c > @@ -7,6 +7,7 @@ > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > +#include > #include > #include > #include > @@ -1368,33 +1369,33 @@ static struct clk *clockgen_clk_get(struct of_phandle_args *clkspec, void *data) > idx = clkspec->args[1]; > > switch (type) { > - case 0: > + case QORIQ_CLK_SYSCLK: > if (idx != 0) > goto bad_args; > clk = cg->sysclk; > break; > - case 1: > + case QORIQ_CLK_CMUX: > if (idx >= ARRAY_SIZE(cg->cmux)) > goto bad_args; > clk = cg->cmux[idx]; > break; > - case 2: > + case QORIQ_CLK_HWACCEL: > if (idx >= ARRAY_SIZE(cg->hwaccel)) > goto bad_args; > clk = cg->hwaccel[idx]; > break; > - case 3: > + case QORIQ_CLK_FMAN: > if (idx >= ARRAY_SIZE(cg->fman)) > goto bad_args; > clk = cg->fman[idx]; > break; > - case 4: > + case QORIQ_CLK_PLATFORM_PLL: > pll = &cg->pll[PLATFORM_PLL]; > if (idx >= ARRAY_SIZE(pll->div)) > goto bad_args; > clk = pll->div[idx].clk; > break; > - case 5: > + case QORIQ_CLK_CORECLK: > if (idx != 0) > goto bad_args; > clk = cg->coreclk; > diff --git a/include/dt-bindings/clock/fsl,qoriq-clockgen.h b/include/dt-bindings/clock/fsl,qoriq-clockgen.h > new file mode 100644 > index 000000000000..ddec7d0bdc7f > --- /dev/null > +++ b/include/dt-bindings/clock/fsl,qoriq-clockgen.h > @@ -0,0 +1,15 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > + > +#ifndef DT_CLOCK_FSL_QORIQ_CLOCKGEN_H > +#define DT_CLOCK_FSL_QORIQ_CLOCKGEN_H > + > +#define QORIQ_CLK_SYSCLK 0 > +#define QORIQ_CLK_CMUX 1 > +#define QORIQ_CLK_HWACCEL 2 > +#define QORIQ_CLK_FMAN 3 > +#define QORIQ_CLK_PLATFORM_PLL 4 > +#define QORIQ_CLK_CORECLK 5 > + > +#define QORIQ_CLK_PLL_DIV(x) ((x) - 1) This is not used and doesn't seem like part of the ABI (shared with dts files). > + > +#endif /* DT_CLOCK_FSL_QORIQ_CLOCKGEN_H */ > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel