From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68FBEC388F7 for ; Tue, 10 Nov 2020 22:08:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 097CB20781 for ; Tue, 10 Nov 2020 22:08:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FUIN/6IA"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dBFVI7Er" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 097CB20781 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/DM1zG3dRoAzlpfTcH11a41zr+SK3BwyZC1GBqSG3IE=; b=FUIN/6IApYawvNnDONBMQQsKA Z7jYV7znLOumlf5QInrN5ViO1vt6PLFv9UYzkOIcK/JjsAXqZRWmvoES7D/m+3KNcLqZPw3Wf52Fr V8/MwKI3vrCr3D7l5HhrI7IAYNadp34gXnsqqJv8MYYBedVy8Mnlurhq4PnZS1U2gaScgRKMvLOY5 Y01Js/vzsmysm0e1I4diG18qRAoLnIUAhTT37lc1FeYekc2o0BjdPDkIX5zAzkzwV0Yyau35aN8I6 Io4pSgLfsuMTGxvOT0w6wHWUK5e0UmDh8v7uWrjr9KuHgI/yVHv3ziQ+2bJzN6oR89KRONUjMkgM0 TBHT3k3yg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcbmx-0003hy-FR; Tue, 10 Nov 2020 22:06:55 +0000 Received: from mail-ed1-x543.google.com ([2a00:1450:4864:20::543]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcbmu-0003gp-5j for linux-arm-kernel@lists.infradead.org; Tue, 10 Nov 2020 22:06:53 +0000 Received: by mail-ed1-x543.google.com with SMTP id v22so92165edt.9 for ; Tue, 10 Nov 2020 14:06:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ScC75wP02JgAQnoPoluzDISIKUTt7c3WoT6HKef6yH0=; b=dBFVI7ErZs51pKrmKb7dNp8ZBJxmYF/Rccih1C0hZ1zsNz1gioisKEuTMnAGxOnSCn OYidsTp1BF3trdMOWLxITc0kW9J70RVjbXeE3OOrOeJatH7qVDNxz+CMCgJNncRikhL7 1PXHVZTTXzQxWU2jqWWnILlYr9zoXfnjKuHa2g05ZWyyQnYAriZmMnpDa52jiJHkeIPd ww3fTgqod9+5UQmP4FSGk9hLZ4fsmB3woK1GzhnGvmOQMUyehTPU5Dc4wldm5ZocQBYy Nsk/Anr5MOyUKqyJr3yTsldPMGpeuDzgi3qtX048qywDxs7xmoZzxkLull1C5lvLu4Tz u0kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ScC75wP02JgAQnoPoluzDISIKUTt7c3WoT6HKef6yH0=; b=TqpTijIsxiXAVXLlTwAh0s2FztamodYh1ZMQb0Y7WkewSf/jzS/Pdknzv0yvYXzQ/V Nh6Cmw6j/NXXtR5NoGqXECDIdAQ/lb7lFsRznnTXFxIrQ4+kDkRkDMkDr3kyU5lgli9e eeeD9hQptQqClPGvJDqXX9k8+KN75nt4ANZ6eM8S2d9VGcF5jklY9RnKLlqS+IPyyrO7 04AWIcnYwUz9+oPNpn5XKPInkrcCylSUxjrLZB4thMSWYCAhhfZWdY6N4yjaW85M4UW+ V84o2Jp3GFM5Fs23/Ol/G95e6pqvkRgmvzzyJS70F9TrC3ikcANqtkLgSi8fcR+DhmDI eDLw== X-Gm-Message-State: AOAM530gOz+vJytO1eV8V8TZcpIOu80CRvVbN4cnVIaBIR8brLMY8KAE k89+es9sKlq4jGOE3zBwb9s= X-Google-Smtp-Source: ABdhPJysXoRimH8cY1wEZy+FFZd4ZuxG/cdTeDnWFdxCkTtNate9qgKVA/sLEyqkLNZg6AaZ1rkzRA== X-Received: by 2002:a05:6402:783:: with SMTP id d3mr23728408edy.168.1605046010782; Tue, 10 Nov 2020 14:06:50 -0800 (PST) Received: from skbuf ([188.25.2.177]) by smtp.gmail.com with ESMTPSA id x20sm45449ejv.66.2020.11.10.14.06.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2020 14:06:50 -0800 (PST) Date: Wed, 11 Nov 2020 00:06:47 +0200 From: Vladimir Oltean To: Florian Fainelli Subject: Re: [PATCH 04/10] ARM: dts: BCM5301X: Add a default compatible for switch node Message-ID: <20201110220647.r5ol44etxa7xxql3@skbuf> References: <20201110033113.31090-1-f.fainelli@gmail.com> <20201110033113.31090-5-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201110033113.31090-5-f.fainelli@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201110_170652_564280_FA0C6A31 X-CRM114-Status: GOOD ( 22.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Scott Branden , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , netdev@vger.kernel.org, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , open list , Vivien Didelot , Rob Herring , "maintainer:BROADCOM IPROC ARM ARCHITECTURE" , Hauke Mehrtens , Ray Jui , Jakub Kicinski , Kurt Kanzenbach , "David S. Miller" , "moderated list:BROADCOM IPROC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 09, 2020 at 07:31:07PM -0800, Florian Fainelli wrote: > Provide a default compatible string which is based on the 53010 SRAB > compatible, this allows us to have sane defaults and silences the > following warnings: > > arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dt.yaml: > ethernet-switch@18007000: compatible: 'oneOf' conditional failed, one > must be fixed: > ['brcm,bcm5301x-srab'] is too short > 'brcm,bcm5325' was expected > 'brcm,bcm53115' was expected > 'brcm,bcm53125' was expected > 'brcm,bcm53128' was expected > 'brcm,bcm5365' was expected > 'brcm,bcm5395' was expected > 'brcm,bcm5389' was expected > 'brcm,bcm5397' was expected > 'brcm,bcm5398' was expected > 'brcm,bcm11360-srab' was expected > 'brcm,bcm5301x-srab' is not one of ['brcm,bcm53010-srab', > 'brcm,bcm53011-srab', 'brcm,bcm53012-srab', 'brcm,bcm53018-srab', > 'brcm,bcm53019-srab'] > 'brcm,bcm5301x-srab' is not one of ['brcm,bcm11404-srab', > 'brcm,bcm11407-srab', 'brcm,bcm11409-srab', 'brcm,bcm58310-srab', > 'brcm,bcm58311-srab', 'brcm,bcm58313-srab'] > 'brcm,bcm5301x-srab' is not one of ['brcm,bcm58522-srab', > 'brcm,bcm58523-srab', 'brcm,bcm58525-srab', 'brcm,bcm58622-srab', > 'brcm,bcm58623-srab', 'brcm,bcm58625-srab', 'brcm,bcm88312-srab'] > 'brcm,bcm5301x-srab' is not one of ['brcm,bcm3384-switch', > 'brcm,bcm6328-switch', 'brcm,bcm6368-switch'] > From schema: > Documentation/devicetree/bindings/net/dsa/b53.yaml > > Signed-off-by: Florian Fainelli > --- Nice, I didn't know DSA supported the switch inside this device. In the default AsusWRT, the switch is well hidden from the kernel :) Not that it makes any difference as far as I can see, but how do you know this a BCM53010 SRAB specifically? > arch/arm/boot/dts/bcm5301x.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi > index ee23c0841699..807580dd89f5 100644 > --- a/arch/arm/boot/dts/bcm5301x.dtsi > +++ b/arch/arm/boot/dts/bcm5301x.dtsi > @@ -483,7 +483,7 @@ thermal: thermal@1800c2c0 { > }; > > srab: ethernet-switch@18007000 { > - compatible = "brcm,bcm5301x-srab"; > + compatible = "brcm,bcm53010-srab", "brcm,bcm5301x-srab"; > reg = <0x18007000 0x1000>; > > status = "disabled"; > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel