From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6B4DC61DD8 for ; Tue, 10 Nov 2020 23:32:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7BEB12080A for ; Tue, 10 Nov 2020 23:32:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mfcanI3J"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hU6Mbm0+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BEB12080A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=W5uLa4OhNyL03K0f0OrpiTjc5ronoSRJsgrs78tQuYU=; b=mfcanI3J3aL3Tf12SlA49DcF9 sv+GwSliqQ9grc9JsZ+zdgatV/JxIRG3VEch43zdeU/wXT9Xzm7WnHjVaEqs+CIMwXtjNQ/gKPp0U +kX69aXhbyPWBck6ivBSEZSEDmP/hv/Dpx/UD2odeqG/0/zd6mv1d19YQaNLjuWN1tGaX1ihrDX3M sFkbtNDx9qUtNEBKFslg9lprr3Ajm3IQRsWH7domdNekWX1pq6gJMNAcAIplwxW/vNUDl5Im5C9+V n0UbVC0rDC/FjKqMzqnAWt905KYARgOP752ttGKrO7ekb3CnCJDm1miZS/sd0e+xZcW/TdFVeoYdj J1z9QEuXQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcd6x-00008K-Op; Tue, 10 Nov 2020 23:31:39 +0000 Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcbsI-0004wz-Rp for linux-arm-kernel@lists.infradead.org; Tue, 10 Nov 2020 22:12:44 +0000 Received: by mail-ed1-x544.google.com with SMTP id k9so127752edo.5 for ; Tue, 10 Nov 2020 14:12:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=P7+OdEtVINuaWn7XQg8+rcvcv6O3BqOjRYLAkjkwIXk=; b=hU6Mbm0+F75S0Q16vh/Wx9PCWHZWgSJrY8F78lbNJZrNCC3D5zNOZLMfJMC/u5vDXo y+hP01MmAeqhGFqgZsx+8rxYNek1qHsg8Ewm3Hij1Vny7WY0q7yCUaFf5/RJd9g84fIf QXBQaQRxyV0eCwNa9IJp5xDNoZlCJktDVHjaPHSux7c+grOOS6Kz75T9pkPjHAiLz2Hb ldWPJz8h2jPM2kcZ+7C/5WnOszNoQXpaTKatTeTTOwwgA7IQxI/9vWmQIkv4RAdWI3js CAGW8N33iM6hFUruvvgT607SzcQ2zoAxxcBDR7IOV9IqFjfhxMteF60VsJNyh03Og98C iQzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=P7+OdEtVINuaWn7XQg8+rcvcv6O3BqOjRYLAkjkwIXk=; b=BMy5E4kcQIwyolFXrlNAt0gvKoIfBbi3zO7uvZ7qahUy7zFymwjpVyAgnUHfSmRP/x /D+eTWnSfM18CgbhB5mE80EKdgkbs56a0xWPhlsH7OBlttSBIIGNOyv2iNHEwY6+q6O4 pC70/gG+ZPDpw7SACJt5EswyhhqJOAJe/ms/HdICNSbMFY05gHvGBNeermweQPULDEfl CLa8l7b526utmG6BZv8cE95KjZmyGCwGxcqZLRaYT9ehX4LKGRo0aoLlPhVJVChab7OK FyfBcz2c9RkxXi/wozjkCn8mOGDI4idfKiTS+naT1S5hwmydXDwaHYc8p/pSx0UpE9C6 mXgg== X-Gm-Message-State: AOAM5339Fhe+cSl3rVBepAovfWCXp2uyBXcVR6IgI9eUuV12rMQcCTJS yOeVU5duUM1PBONZShxBypo= X-Google-Smtp-Source: ABdhPJyWbdsaRQBLaCOll12qGnDs4KmJNSvNWEhvwy/xD0a3MCdi+OcCpCKKRrObi9xNN3ccEeqHqA== X-Received: by 2002:a50:ed14:: with SMTP id j20mr24037840eds.247.1605046343636; Tue, 10 Nov 2020 14:12:23 -0800 (PST) Received: from skbuf ([188.25.2.177]) by smtp.gmail.com with ESMTPSA id y4sm12143edr.20.2020.11.10.14.12.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2020 14:12:23 -0800 (PST) Date: Wed, 11 Nov 2020 00:12:21 +0200 From: Vladimir Oltean To: Florian Fainelli Subject: Re: [PATCH 05/10] ARM: dts: BCM5301X: Provide defaults ports container node Message-ID: <20201110221221.4sxx5h3346no7y3y@skbuf> References: <20201110033113.31090-1-f.fainelli@gmail.com> <20201110033113.31090-6-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201110033113.31090-6-f.fainelli@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201110_171227_042017_88E56609 X-CRM114-Status: GOOD ( 20.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Scott Branden , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , netdev@vger.kernel.org, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , open list , Vivien Didelot , Rob Herring , "maintainer:BROADCOM IPROC ARM ARCHITECTURE" , Hauke Mehrtens , Ray Jui , Jakub Kicinski , Kurt Kanzenbach , "David S. Miller" , "moderated list:BROADCOM IPROC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 09, 2020 at 07:31:08PM -0800, Florian Fainelli wrote: > Provide an empty 'ports' container node with the correct #address-cells > and #size-cells properties. This silences the following warning: > > arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dt.yaml: > ethernet-switch@18007000: 'oneOf' conditional failed, one must be fixed: > 'ports' is a required property > 'ethernet-ports' is a required property > From schema: > Documentation/devicetree/bindings/net/dsa/b53.yaml > > Signed-off-by: Florian Fainelli > --- > arch/arm/boot/dts/bcm5301x.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi > index 807580dd89f5..89993a8a6765 100644 > --- a/arch/arm/boot/dts/bcm5301x.dtsi > +++ b/arch/arm/boot/dts/bcm5301x.dtsi > @@ -489,6 +489,10 @@ srab: ethernet-switch@18007000 { > status = "disabled"; > > /* ports are defined in board DTS */ > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + }; This look a bit 'lone wolf' here. Not sure how much time you intend to spend on this, but FWIW, others prefer to declare all ports in the SoC DTSI with status = "disabled", and just enable the ones used per-board, and add labels and PHY handles also per-board. Example: fsl-ls1028a.dtsi and fsl-ls1028a-rdb.dts. > }; > > rng: rng@18004000 { > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel