From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85092C388F7 for ; Tue, 10 Nov 2020 22:39:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A1832068D for ; Tue, 10 Nov 2020 22:39:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MbrAUa5I"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NFxx6otC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A1832068D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Iux8wzbFPlTAmABCpmMix76MfLpfrxrqS1bQANN20lU=; b=MbrAUa5IUZx1MtleVU3XQcRaS 72O0UWiy1Ra0iTbsHCWeB6bjC+/A6JIE9TH/bTSPwRk2g6oX0nftIZkuqJyLKJBlWlS1v3mndOefR 7vppFul18iymA1xnPRd0dML0Ke80eKczB90LmC1D/4STaEppBcsWCcPBAFa2eZovTEUSJxKbcOPFJ l2B/Er5qK2y1QXn3HV5vfJnQ9nNI6H4Hx/sUjG901pxGuLCWougjYeFz6pnrSWk7aTiExaTtmWIm2 W9MgHZz0OoejEPryEJZcobA3njMqEpBAVFlUf/aVdiLPPIY6xSmebp0w5cC0hGbfXZ6Job4L3LPZF pPYGdQ6Vw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kccHb-0008Bs-UY; Tue, 10 Nov 2020 22:38:36 +0000 Received: from mail-ej1-x644.google.com ([2a00:1450:4864:20::644]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcc7M-0003bP-TL for linux-arm-kernel@lists.infradead.org; Tue, 10 Nov 2020 22:28:09 +0000 Received: by mail-ej1-x644.google.com with SMTP id cw8so19918958ejb.8 for ; Tue, 10 Nov 2020 14:28:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IDwqcl49mFRj/GQI1sIJo5TSDn2DCgIJIB4tlo20bkQ=; b=NFxx6otCj2aPXrKIQ10imsjVP+bu3Ha8B8pCjqD7c/YYYL6VjsGsg+53t0mqr3fq0B RuoDT4ebf6LgEL3U9BIUAS2OBwTzvo5j88HOJK70B1nbKOSDB1UJ3cp6j8gvi2oF9701 ImgGKDgSjI58Qwyb43wv7Hx7s3w7fUDNLLwnMhenIQtDqCw9WdmVoSA8MHc3r/GQHWvX krUrD9kcICk3hfSgqyytYgdsxfguZ8uCcKYAQKDS8fOJaNc3FcEM5C3SHFr0wsTSILJ/ Qw3y5/HALBizYwW4uGyDKF/ctXaq9Y4dTcixxyY2u0umFDqfXi4ABp6nYGdEFeAaosDb nm2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IDwqcl49mFRj/GQI1sIJo5TSDn2DCgIJIB4tlo20bkQ=; b=PRyQQGiFUgDTFxKXhZracuKpH6qaVMgSPAtU6OIxb6yGBnChS8pIJzauEsC3X7+soc JovqWfRqFuc5miKyyIBYfxPnroSUw3vRFefdWY1GepZLMGYvPfI+ApUs+kamD8daUaXL MRMsjH69ucn9qO7ItWv2w9jbnFwqr9VHSouS22mpxt4hOE6bjqpQlfrT5lXJwnHcv7dQ XpGgMowoqWpUhX8Cgh4vV1xiJTxWULicztNU9XRiqLq1Zl82jIC+vlqNiOEpeQsjyIWx 0224dOuo52G/F5DXtEzU9yUioc+2DITudI0LLgBZNtUxXVF+fiMrjgB6Lyl6vB1cknaC UkpQ== X-Gm-Message-State: AOAM532OEDoJBmSyiLAyqx0+QWtXBkRIpds+wTpbTlQI62O/X+IdC9uc +qBpT0yhszRQWIuou63yp6A= X-Google-Smtp-Source: ABdhPJwPwGVQoQGrKxgHqOIurAWewCfL99Qo9IkQWt4sYsTPmrTmPBMocc7mlyvbgMxk1dcZOzK64A== X-Received: by 2002:a17:906:3a4e:: with SMTP id a14mr21936517ejf.140.1605047279356; Tue, 10 Nov 2020 14:27:59 -0800 (PST) Received: from skbuf ([188.25.2.177]) by smtp.gmail.com with ESMTPSA id b24sm16440edt.68.2020.11.10.14.27.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2020 14:27:58 -0800 (PST) Date: Wed, 11 Nov 2020 00:27:56 +0200 From: Vladimir Oltean To: Florian Fainelli Subject: Re: [PATCH 07/10] ARM: dts: NSP: Fix Ethernet switch SGMII register name Message-ID: <20201110222756.alaii5mr6fcwq4lx@skbuf> References: <20201110033113.31090-1-f.fainelli@gmail.com> <20201110033113.31090-8-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201110033113.31090-8-f.fainelli@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201110_172801_061053_65891BFF X-CRM114-Status: GOOD ( 22.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Scott Branden , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , netdev@vger.kernel.org, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , open list , Vivien Didelot , Rob Herring , "maintainer:BROADCOM IPROC ARM ARCHITECTURE" , Hauke Mehrtens , Ray Jui , Jakub Kicinski , Kurt Kanzenbach , "David S. Miller" , "moderated list:BROADCOM IPROC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 09, 2020 at 07:31:10PM -0800, Florian Fainelli wrote: > The register name should be "sgmii_config", not "sgmii", this is not a > functional change since no code is currently looking for that register > by name (or at all). > > Signed-off-by: Florian Fainelli > --- I.e. no one calls devm_platform_ioremap_resource(pdev, 2), and even if it did, the register name wouldn't matter. ...but at least it's documented that it should be called "sgmii_config". And the address is the same as the one that's documented for the SGMII register base in SoCs with "brcm,nsp-srab", so even without documentation, it is pretty clear to me that it was a mistake calling it simply "sgmii". And if that address is incorrect anyways, at least that would be a separate issue. Reviewed-by: Vladimir Oltean > arch/arm/boot/dts/bcm-nsp.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-nsp.dtsi > index e7d08959d5fe..09fd7e55c069 100644 > --- a/arch/arm/boot/dts/bcm-nsp.dtsi > +++ b/arch/arm/boot/dts/bcm-nsp.dtsi > @@ -390,7 +390,7 @@ srab: ethernet-switch@36000 { > reg = <0x36000 0x1000>, > <0x3f308 0x8>, > <0x3f410 0xc>; > - reg-names = "srab", "mux_config", "sgmii"; > + reg-names = "srab", "mux_config", "sgmii_config"; > interrupts = , > , > , > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel