From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77ACDC388F7 for ; Tue, 10 Nov 2020 22:49:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 013712076E for ; Tue, 10 Nov 2020 22:49:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WTpQNo6+"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lxv2PaOv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 013712076E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JK8BXmeRVA68tmEpzHPSYD0b8KPwJJu7Vwz8pEqDnS0=; b=WTpQNo6+pPFFSeBl84XeNghS3 bNP7THddBaLt7VyKVAYzhl7FY1yRJJV7Se5QUD0T++iHSWl9nE0CjdPqm41TJ8M+EYIrQ2+8XtMl/ 5PoCG+8mjw9hqa3nKuCgAvEVIu1z77gbLvhQkZBPAEg5wW0sH9oJLqS2ntdy5liaUr0ZYHEQrKHgq AYvudvMz/OfHCwmAkHtKp4D3XjSnbecGtcDgStuvTmosRFT+4Z24beReO4cu7wNtW2LeY3NaoKX3d C9rt4tcFp9USXNC90ofivpI1vOrgrEDdNaVdktD4KUcgobZIrLKGrwPhH5itDs9gQEp+kzdBeEhTg Qhlu05M1A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kccRE-00049Y-8c; Tue, 10 Nov 2020 22:48:32 +0000 Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kccR6-00047U-P4 for linux-arm-kernel@lists.infradead.org; Tue, 10 Nov 2020 22:48:27 +0000 Received: by mail-ed1-x542.google.com with SMTP id o20so221152eds.3 for ; Tue, 10 Nov 2020 14:48:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Em8WmoYAvsXVW5SzBtkWgE8omnO3+c4rMhoVObwwjsk=; b=lxv2PaOvwPDyJPfCeBZHoeHvFyarLc7JGIvHAfhVDSy6drxmEHL4vhm3B2Ysu1UfhU NspZc78ZfwNzl1SRzdTRcoAkri5QzHOrN1GySZd+otwHlcHXcdProhZ6a8XlM6TXWd+k i8O2ilk1nH2d5bLo/H0lBT4tKnAMY7CPjGgD+9bDeeVayedKjY2J3eOMBVoJMHf+8gR5 wXHxTE65VZVgJv+w0qwYEFi97velqUluljCcA3spM2lAPdSflyuJly69pcCxb/vaoPMm EO4EeJ6I6GnqBiN0i1GgejfiFST4OChxG1OBv4vqHL1kPvgwSosXLJtkqHApAVAfHTEI FUNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Em8WmoYAvsXVW5SzBtkWgE8omnO3+c4rMhoVObwwjsk=; b=p7n8t3Qjboy9IynzQHeOMLhk5R4U3BW6upJw8RHONp1BBkZFZjYnSGlo75AUkcRVfx mUPmdj1GuO3F0z3bWVhIroG43pZOfmvLxnYYsI5sU4LEq/gKsqSajoSzwYH0i+8Jwy6i vMIr2VXyj1ivgwiw9zFUU2VykqAu4NDMjfU0d5UJIAPAq8/JvQPQcC8SC0ghSPBcXVrA 8LSf1oq7ciRMcmZstG4YlqJ0c4OdUrObqrxnWyPgMflLqHBnQxYJsspK2fil0C09nIMC r/s2FMFuaidGckVxtUA6gLO56Mvpwe7zjcltebv9m3HNMdBa8LepURGMdVY8JLsF8niU tETQ== X-Gm-Message-State: AOAM533/7mGHspm3uVv0VI9FfbzgHuyh3ejKaZH0vgXbGnuXYQrOphB7 nZ2Brtq60uwNR7pN35RVprA= X-Google-Smtp-Source: ABdhPJywtLEXQhr+THCrnyE2wBAiXh/ZBTDTv7mMPPinrudG7I9DUvaxIl4rqPj9sCMN2iOK0HbdgA== X-Received: by 2002:a05:6402:783:: with SMTP id d3mr23885455edy.168.1605048503378; Tue, 10 Nov 2020 14:48:23 -0800 (PST) Received: from skbuf ([188.25.2.177]) by smtp.gmail.com with ESMTPSA id a17sm37417eda.45.2020.11.10.14.48.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2020 14:48:22 -0800 (PST) Date: Wed, 11 Nov 2020 00:48:20 +0200 From: Vladimir Oltean To: Florian Fainelli Subject: Re: [PATCH 08/10] ARM: dts: NSP: Add a default compatible for switch node Message-ID: <20201110224820.gbz3tcl6lzjbe3zo@skbuf> References: <20201110033113.31090-1-f.fainelli@gmail.com> <20201110033113.31090-9-f.fainelli@gmail.com> <20201110223709.vca534wynwgfkz77@skbuf> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201110_174824_932525_59EFC2ED X-CRM114-Status: GOOD ( 33.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Scott Branden , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , netdev@vger.kernel.org, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , open list , Vivien Didelot , Rob Herring , "maintainer:BROADCOM IPROC ARM ARCHITECTURE" , Hauke Mehrtens , Ray Jui , Jakub Kicinski , Kurt Kanzenbach , "David S. Miller" , "moderated list:BROADCOM IPROC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 10, 2020 at 02:40:43PM -0800, Florian Fainelli wrote: > On 11/10/20 2:37 PM, Vladimir Oltean wrote: > > On Mon, Nov 09, 2020 at 07:31:11PM -0800, Florian Fainelli wrote: > >> Provide a default compatible string which is based on the 58522 SRAB > >> compatible, this allows us to have sane defaults and silences the > >> following warnings: > >> > >> arch/arm/boot/dts/bcm958522er.dt.yaml: > >> ethernet-switch@36000: compatible: 'oneOf' conditional failed, > >> one > >> must be fixed: > >> ['brcm,bcm5301x-srab'] is too short > >> 'brcm,bcm5325' was expected > >> 'brcm,bcm53115' was expected > >> 'brcm,bcm53125' was expected > >> 'brcm,bcm53128' was expected > >> 'brcm,bcm5365' was expected > >> 'brcm,bcm5395' was expected > >> 'brcm,bcm5389' was expected > >> 'brcm,bcm5397' was expected > >> 'brcm,bcm5398' was expected > >> 'brcm,bcm11360-srab' was expected > >> 'brcm,bcm5301x-srab' is not one of ['brcm,bcm53010-srab', > >> 'brcm,bcm53011-srab', 'brcm,bcm53012-srab', 'brcm,bcm53018-srab', > >> 'brcm,bcm53019-srab'] > >> 'brcm,bcm5301x-srab' is not one of ['brcm,bcm11404-srab', > >> 'brcm,bcm11407-srab', 'brcm,bcm11409-srab', 'brcm,bcm58310-srab', > >> 'brcm,bcm58311-srab', 'brcm,bcm58313-srab'] > >> 'brcm,bcm5301x-srab' is not one of ['brcm,bcm58522-srab', > >> 'brcm,bcm58523-srab', 'brcm,bcm58525-srab', 'brcm,bcm58622-srab', > >> 'brcm,bcm58623-srab', 'brcm,bcm58625-srab', 'brcm,bcm88312-srab'] > >> 'brcm,bcm5301x-srab' is not one of ['brcm,bcm3384-switch', > >> 'brcm,bcm6328-switch', 'brcm,bcm6368-switch'] > >> From schema: > >> Documentation/devicetree/bindings/net/dsa/b53.yaml > >> > >> Signed-off-by: Florian Fainelli > >> --- > >> arch/arm/boot/dts/bcm-nsp.dtsi | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-nsp.dtsi > >> index 09fd7e55c069..8453865d1439 100644 > >> --- a/arch/arm/boot/dts/bcm-nsp.dtsi > >> +++ b/arch/arm/boot/dts/bcm-nsp.dtsi > >> @@ -386,7 +386,7 @@ ccbtimer1: timer@35000 { > >> }; > >> > >> srab: ethernet-switch@36000 { > >> - compatible = "brcm,nsp-srab"; > >> + compatible = "brcm,bcm58522-srab", "brcm,nsp-srab"; > >> reg = <0x36000 0x1000>, > >> <0x3f308 0x8>, > >> <0x3f410 0xc>; > >> -- > >> 2.25.1 > >> > > > > I am not getting this. > > The line: > > #include "bcm-nsp.dtsi" > > > > can be found in: > > > > arch/arm/boot/dts/bcm988312hr.dts > > arch/arm/boot/dts/bcm958625hr.dts > > arch/arm/boot/dts/bcm958622hr.dts > > arch/arm/boot/dts/bcm958625k.dts > > arch/arm/boot/dts/bcm958522er.dts > > arch/arm/boot/dts/bcm958525er.dts > > arch/arm/boot/dts/bcm958623hr.dts > > arch/arm/boot/dts/bcm958525xmc.dts > > > > > > The pattern for the other DTS files that include this seems to be to > > overwrite the compatible locally in bcm958522er.dts, like this: > > > > &srab { > > compatible = "brcm,bcm58522-srab", "brcm,nsp-srab"; > > }; > > > > Is there a reason why you are choosing to put an SoC specific compatible > > in the common bcm-nsp.dtsi? > > It is necessary to silence the warnings provided in the commit message > even when the srab node is disabled, since the dt_binding_check rule > will check all of the nodes matching the pattern. If there is a better > way to do this, I would gladly do it differently. > -- > Florian I am still not getting it. The exact 3 lines from above will not change the "status" property from "disabled" to "okay", so I don't understand why it matters whether it's enabled or not. The dt_binding_check error isn't in the DTSI, it's in bcm958522er.dts. All that needs to be done is that the bcm958522er.dts needs to override the compatible from the DTSI and only the compatible, I believe. With no occurrence of an incomplete list of compatibles in any final DTS, the dt_binding_check should not complain about that single occurrence in the DTSI as far as I know (and I did not test this). _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel