From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15E50C5517A for ; Wed, 11 Nov 2020 01:10:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F1E221D7F for ; Wed, 11 Nov 2020 01:10:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BQjRbm6b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F1E221D7F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Cr2oNFLVi4e4WtURdX1N36W3ErNIFPcgVegmrb9qUW4=; b=BQjRbm6b8wFZ6amgxhqSeLE9Z gXmU6SzRzJYuZBFW9pSjYS9nvujMwxnylxvDQpDyNBH0qsvoy0RchmA01x+/7jZlC1l5U/G2xirIc AAk50whPc48ttuxUBbBO1kqoevq73BIsn0OKzq/9zgtdBS/f3QcX5rrwf2xzadEgkAC+CzD56HZSd HkOsGkzUhB4h6zO4Cte4+8qvrwBuQPFZKjpuBemu0uONSp/Z5NAULjESHxMBl2zCdcVjoNfpP8Ibb pCnT2L+uczB5QrZjv2XJchCZd63NRGTf9UNlfwCe2oUCFnROBN5kyZtMMmOJ0UuuNUJ9RtLd49JCl XUoXLYGkQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcedU-0008FT-8e; Wed, 11 Nov 2020 01:09:20 +0000 Received: from [2002:c35c:fd02::1] (helo=ZenIV.linux.org.uk) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcedS-0008Et-J5 for linux-arm-kernel@lists.infradead.org; Wed, 11 Nov 2020 01:09:19 +0000 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcedK-003BHU-BW; Wed, 11 Nov 2020 01:09:10 +0000 Date: Wed, 11 Nov 2020 01:09:10 +0000 From: Al Viro To: Ansuel Smith Subject: Re: [PATCH] arm64: fix missing include in asm uaccess.h Message-ID: <20201111010910.GZ3576660@ZenIV.linux.org.uk> References: <20201111004440.8783-1-ansuelsmth@gmail.com> <20201111005826.GY3576660@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201111005826.GY3576660@ZenIV.linux.org.uk> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201110_200918_651173_0AEF73D3 X-CRM114-Status: GOOD ( 21.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Pavel Tatashin , Catalin Marinas , linux-kernel@vger.kernel.org, Andrew Morton , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 11, 2020 at 12:58:26AM +0000, Al Viro wrote: > On Wed, Nov 11, 2020 at 01:44:38AM +0100, Ansuel Smith wrote: > > Fix a compilation error as PF_KTHREAD is defined in linux/sched.h and > > this is missing. > > > > Fixes: df325e05a682 ("arm64: Validate tagged addresses in access_ok() > > called from kernel threads") > > Signed-off-by: Ansuel Smith > > --- > > arch/arm64/include/asm/uaccess.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm64/include/asm/uaccess.h b/arch/arm64/include/asm/uaccess.h > > index 991dd5f031e4..51a4f63f464a 100644 > > --- a/arch/arm64/include/asm/uaccess.h > > +++ b/arch/arm64/include/asm/uaccess.h > > @@ -7,6 +7,8 @@ > > #ifndef __ASM_UACCESS_H > > #define __ASM_UACCESS_H > > > > +#include > > + > > #include > > #include > > #include > > NAK. The real bug is in arch/arm64/include/asm/asm-prototypes.h - > it has no business pulling asm/uaccess.h > > Just include linux/uaccess.h instead. BTW, $ grep -n uaccess.h `find -name asm-prototypes.h` ./arch/alpha/include/asm/asm-prototypes.h:7:#include ./arch/arm64/include/asm/asm-prototypes.h:18:#include ./arch/ia64/include/asm/asm-prototypes.h:12:#include ./arch/mips/include/asm/asm-prototypes.h:6:#include ./arch/powerpc/include/asm/asm-prototypes.h:14:#include ./arch/sparc/include/asm/asm-prototypes.h:9:#include ./arch/x86/include/asm/asm-prototypes.h:3:#include Spot the irregularity... While we are at it, $ git grep -n -w '#.*include.*asm/uaccess.h' arch/arm64/include/asm/asm-prototypes.h:18:#include arch/nds32/math-emu/fpuemu.c:5:#include arch/powerpc/kvm/book3s_xive_native.c:15:#include arch/powerpc/mm/book3s64/radix_pgtable.c:30:#include drivers/s390/net/ctcm_mpc.c:50:#include /* instead of ok ? */ include/linux/uaccess.h:11:#include The last one is the only such include that should exist; drivers/s390 one is obviously a false positive. And IMO the right thing to do is to replace the remaining arch/* instances with includes of linux/uaccess.h. All of those are asking for trouble; any change moving e.g. a common variant of some primitive into linux/uaccess.h might end up breaking those. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel