From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB421C388F9 for ; Wed, 11 Nov 2020 18:44:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2585020659 for ; Wed, 11 Nov 2020 18:44:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="be3LZUU0"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="q5lLWorc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2585020659 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YaQzOK3oWeHygbKYG7vHBYmRvITRnxy2zcJG57Afmbk=; b=be3LZUU0+uwJCB3HHQBrIjh/h e6zPFsgdKNjrsbIT0eKNkNCyRFf+SoOiYGxn87ZPfyimjl+LdPqKtUY5bL92Jzb3XqbFB8fmGURyz gXOXcrMCVL1M8ZGx9x7iLCzF465WaM8HVj6yOG3QxMCW8cywy5trzSJI3oJ/DDlfb/OkM8OmCbsvj NB8kvuUCRk7KVk7OX8WDLJGhjFhOiqcGi+9jRjnpq75cAXMkOxUzC14hZLCe29l2tbs/GZQJkm/ng swao/jU+8T2BmnUmswAMJnyoBer/nAhz+l2iap5kZpoDqUN5JqHiO57PuBNFGNwU2MMIx72DaXvex kZGUBr0vw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcv57-0001yr-6J; Wed, 11 Nov 2020 18:42:57 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcv54-0001xt-Uw for linux-arm-kernel@lists.infradead.org; Wed, 11 Nov 2020 18:42:55 +0000 Received: by mail-wr1-x441.google.com with SMTP id 23so3511565wrc.8 for ; Wed, 11 Nov 2020 10:42:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VohxCgmaGc6F7Ktsca4rjVlrZ86gTh1fROnDD+cvua8=; b=q5lLWorcNvq+9Yc6F6OpKuLSxNfpexysmfo67YGIJQm9USpyAY1a0El1997oZE4wkP 8oqytOtFLxzPFKfILJzTJgYc46xAEBJFyWtuM1LTEETuUfNL/KuH8ikBmZDq/UqQ/Id/ E76iFLtXpDU/wuvo8+MAmKHQCxr/+4O4OJqc5u5N9uJbn25p6NqFNx+WALMGSWhTODnh kD66Fx1jLku1gDyfDnSOvkDgGCyu+iraGYhFX9JP4kQehD2F7J+O34XvINm9mbxUzcAS hQoG/Tiqe7+nF2rMK/813dHUyO2G+HXvIe2S5qscLlRg2Xzo7BlnfmqUHUy+lnNI4FXY 5KCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VohxCgmaGc6F7Ktsca4rjVlrZ86gTh1fROnDD+cvua8=; b=Ep5i3b34KMS/MUeUPCZoyqLcNXqmZYNXowjvTcabn7kM/2JuTnhAkr23Og65LRGpE7 fdLNYMT57Ws+5udn12B+n6GeX3wf6uO7n3OksWqplfrzzWQeh6y4sH5W+v8jkMg8CLoD Rs8UgXjNuvI7zmoPl9P+Ubd8O10WWcYp+aqi50EhpnZxLBHOocW6IXhK+q2lANl0nj/h I6aT7TYE2JaZmKUHG9i9+keQHyIXORyE6oAj5OMBAGXRtm65Pe7czhZMSXolHr5FXQFX xbbbv1fP5USD6x6JQmGspNlQN/o8wmVrXMpPi7tLZuxNtjlRvCk3DlhzmiC+K+mIVZkO HoTg== X-Gm-Message-State: AOAM530XMDdyh9HKVih0hTK1RtbSsLUWx3kZx/duPsrWSdBUbFFgaQAO scCEipGT5EbotJ/qhLF4l+U6DA== X-Google-Smtp-Source: ABdhPJwhO/pOEHygpEN38k/rCWZcOpBcvG2IP4pMbw5LM7pzlX+NSLqrby7G/rFyaxB3/C6to3EXwQ== X-Received: by 2002:a5d:66c3:: with SMTP id k3mr26447563wrw.123.1605120173432; Wed, 11 Nov 2020 10:42:53 -0800 (PST) Received: from elver.google.com ([2a00:79e0:15:13:f693:9fff:fef4:2449]) by smtp.gmail.com with ESMTPSA id n10sm3431496wrv.77.2020.11.11.10.42.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2020 10:42:52 -0800 (PST) Date: Wed, 11 Nov 2020 19:42:46 +0100 From: Marco Elver To: Andrey Konovalov Subject: Re: [PATCH v2 13/20] kasan: simplify kasan_poison_kfree Message-ID: <20201111184246.GO517454@elver.google.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.14.6 (2020-07-11) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201111_134255_053635_6023F3E4 X-CRM114-Status: GOOD ( 20.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Branislav Rankov , Catalin Marinas , Kevin Brodsky , Will Deacon , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Evgenii Stepanov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 10, 2020 at 11:20PM +0100, Andrey Konovalov wrote: > kasan_poison_kfree() is currently only called for mempool allocations > that are backed by either kmem_cache_alloc() or kmalloc(). Therefore, the > page passed to kasan_poison_kfree() is always PageSlab() and there's no > need to do the check. Remove it. > > Signed-off-by: Andrey Konovalov > Reviewed-by: Dmitry Vyukov > Link: https://linux-review.googlesource.com/id/If31f88726745da8744c6bea96fb32584e6c2778c > --- > mm/kasan/common.c | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) Reviewed-by: Marco Elver > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index 385863eaec2c..819403548f2e 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -432,16 +432,7 @@ void __kasan_poison_kfree(void *ptr, unsigned long ip) > struct page *page; > > page = virt_to_head_page(ptr); > - > - if (unlikely(!PageSlab(page))) { > - if (ptr != page_address(page)) { > - kasan_report_invalid_free(ptr, ip); > - return; > - } > - kasan_poison_memory(ptr, page_size(page), KASAN_FREE_PAGE); > - } else { > - ____kasan_slab_free(page->slab_cache, ptr, ip, false); > - } > + ____kasan_slab_free(page->slab_cache, ptr, ip, false); > } > > void __kasan_kfree_large(void *ptr, unsigned long ip) > -- > 2.29.2.222.g5d2a92d10f8-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel