From: Catalin Marinas <catalin.marinas@arm.com>
To: Will Deacon <will@kernel.org>
Cc: Albert Ou <aou@eecs.berkeley.edu>,
linux-kernel@vger.kernel.org, Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-riscv@lists.infradead.org,
tangyouling <tangyouling@loongson.cn>,
ardb@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: Change the location of DISCARDS
Date: Thu, 12 Nov 2020 13:17:40 +0000 [thread overview]
Message-ID: <20201112131740.GN29613@gaia> (raw)
In-Reply-To: <20201106090737.GA9496@willie-the-truck>
On Fri, Nov 06, 2020 at 09:07:38AM +0000, Will Deacon wrote:
> On Fri, Nov 06, 2020 at 09:06:42AM +0800, tangyouling wrote:
> > In the include/asm-generic/vmlinux.lds.h:978, the description is as follows:
> > DISCARDS must be the last of output section definitions so that such archs
> > put those in earlier section definitions.
>
> Sure, I see that text, but I don't get why it matters. It would be nice to
> have some rationale as to what could go wrong if they aren't at the end,
> so we can improve that comment and avoid the inevitable regression in the
> future when things get shuffled around.
Maybe on other architectures or some old toolchains made a difference in
the resulting binary image size. It doesn't seem to be the case for
arm64.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-11-12 13:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 10:48 [PATCH] arm64: Change the location of DISCARDS Youling Tang
2020-11-05 21:47 ` Will Deacon
2020-11-06 1:06 ` tangyouling
2020-11-06 9:07 ` Will Deacon
2020-11-12 13:17 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112131740.GN29613@gaia \
--to=catalin.marinas@arm.com \
--cc=aou@eecs.berkeley.edu \
--cc=ardb@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=tangyouling@loongson.cn \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox