From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57D94C2D0A3 for ; Thu, 12 Nov 2020 14:58:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD37122201 for ; Thu, 12 Nov 2020 14:58:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="e5ypxOb8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD37122201 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oHafQtxvnQFRm2uu/mveJby+Be0GP3vwot+aLk3kJP8=; b=e5ypxOb84uMsfG61IREp/eM1H pjF1MLt/3pWx52v/G/boqFsZ2AYf7yzJFzAFsxWTzqV9U/OW5EQJDAaYqDa0WRkUEchyDulb3DBH6 Ot1k9r2Y1PpH0uly8zmzUf03a02nnBxwY9kE9UCXZ30LH9EeOmFsdcHTiomRFiJb2EJElB2Xsqi/b lFCxxh3jB0NrkNZFesyHbSy4vaTd482VQgIQ32essTu8taiwoNk8bc1o1eNRm3PtXgODGQNJF40Pr 7zZ7nTGha6c03jhmzxjLkm5lXon9fI0lFj5Am6exsJLC2wFWQUb17VBpfRLi6dC5OLJzcbw05MAVs T8oA85+5A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdE2w-0007xn-7q; Thu, 12 Nov 2020 14:57:58 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdE2t-0007wn-RM for linux-arm-kernel@lists.infradead.org; Thu, 12 Nov 2020 14:57:56 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A9469139F; Thu, 12 Nov 2020 06:57:53 -0800 (PST) Received: from bogus (unknown [10.57.15.107]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E41353F73C; Thu, 12 Nov 2020 06:57:51 -0800 (PST) Date: Thu, 12 Nov 2020 14:57:44 +0000 From: Sudeep Holla To: Cristian Marussi Subject: Re: [PATCH v2 1/1] firmware: arm_scmi: Add SCMI System Power Control driver Message-ID: <20201112145744.wwehqweh2aqo7klp@bogus> References: <20201026205531.25585-1-cristian.marussi@arm.com> <20201026205531.25585-2-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201026205531.25585-2-cristian.marussi@arm.com> User-Agent: NeoMutt/20171215 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201112_095756_004293_25A31C09 X-CRM114-Status: GOOD ( 14.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sudeep Holla , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, lukasz.luba@arm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 26, 2020 at 08:55:31PM +0000, Cristian Marussi wrote: > Add an SCMI System Power control driver to handle platform's requests > carried by SYSTEM_POWER_STATE_NOTIFIER notifications: such platform > requested system power state transitions are handled accordingly, > gracefully or forcefully, depending on the notifications' message flags. > > Graceful requests are by default relayed to userspace using the same > Kernel API used to handle ACPI Shutdown bus events: alternatively, instead, > a few available module parameters can be used to tunnel instead such > requests to userspace via signals addressed to CAD pid. > > When handling graceful requests, grant userspace processes a maximum > (configurable) time to perform their duties and then revert to a forceful > transition, so avoiding completely timing out platform's maximum grace time > and hitting possible abrupt power-cuts. > > Signed-off-by: Cristian Marussi > --- > drivers/firmware/Kconfig | 12 + > drivers/firmware/arm_scmi/Makefile | 1 + > .../firmware/arm_scmi/scmi_power_control.c | 387 ++++++++++++++++++ > 3 files changed, 400 insertions(+) > create mode 100644 drivers/firmware/arm_scmi/scmi_power_control.c > [nit] Since you have just one patch, it is generally preferred to place all the extra non commit messages here after diff stat to have a single thread of discussion. Anyways, probably ccing Arnd/Greg/or anyone who has made some feature changes in this area(e.g. kernel/reboot.c) might help to get some useful feedback here. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel