From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81549C5519F for ; Thu, 12 Nov 2020 17:53:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC51F216C4 for ; Thu, 12 Nov 2020 17:53:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MYWZv4DM"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MMfgWC4Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC51F216C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LzZ/U8V1rgADcLAsTVPajmom2XN4U3ISlKHayuU9XN4=; b=MYWZv4DMRHZ5Zy5ohTpnOek0e Tl7VPuXtx5MLHFq9s0B6LjSxL70JTUv1VCw0rFR4/WnpzU1otR/4hpCSoop6+0eg61b1lp9xLyOz1 gnA19mBmVmZzSf+QYQhXBH3Y2do7/Qv2FR24BguNRLZT8oqS6Aea3Z4Rh5ox5ORmOhnwB3aAzPC9o bL5y6b64aAVp205a9FQBD1CQkeQ9F5WomLJTpOzc84Bp2BIVEPUmFYeq8dUe+t0qsQF765OqLiy3m LGKuhlOkVdksUDtz/b9ybM9ugavJ9ZgFaInTtcjklk0rnDNrGHo+ZYCsJ8jNImVlomU9A0CPulyoM XfVF2p5zA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdGlj-0002ma-Dw; Thu, 12 Nov 2020 17:52:23 +0000 Received: from mail-qv1-xf41.google.com ([2607:f8b0:4864:20::f41]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdGlg-0002l1-5W for linux-arm-kernel@lists.infradead.org; Thu, 12 Nov 2020 17:52:21 +0000 Received: by mail-qv1-xf41.google.com with SMTP id x13so3168971qvk.8 for ; Thu, 12 Nov 2020 09:52:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=MV5o1y23M6b0t2UlHjVlNzL4uzRL01omBINxln5TdCQ=; b=MMfgWC4Zy6KQDFVRuppfuq4P5nBlHlt4vVEz6Tme1TGsdmsmafbdljmiU+g/x85W13 HSMho/kP8YGtI506/BGAKE3B/+ju1VXKG5ezURDoRjzoBUi7XWf1Jj9CCNbDYS8LWSBi fzPHUconGbSLmEeD5C9q0vkaIvqeAPKq1Kc43dIxRuEZNx5DptpjvR0CjKJ05q7y4NZ8 Onweg2ldWMZhbHesNv+Wtglaemn3LInkvRgS+OrKir/gBp2zU4R7IT+H2UEmublNKTzU iP7weuI9YMf/+aBewl5Ix7XLH/2tsB0wv5vi6khWuJ90MhEPsC4vcKMlUUkwuq4HNBSi nebg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MV5o1y23M6b0t2UlHjVlNzL4uzRL01omBINxln5TdCQ=; b=X0QkUcIq4RDMkadKYovdJLPmV4ul+xR+yNAAoscCiLyCBTsVeLVCZckVl2MYwf2Ykf Gk6LK/ohs0T773rZlstiM137pVi9BlQ3teNAOqBS2758shRjpUazIRTxdUwwPysuCsHF awZHe3KiMJiLaIunFBzrmEuDxhEo5+BW93ytMJOh7GLM4rrnl+KTKB/3Mq9uSCuvv7uh iJK6QP17QOn61MIjP+V7oDQ6zTnRjL6lXzja0DdHTBsgsQFLBUpmKA4GGTuBO8v4pXOS CbYCB/4UB86nM7prfmRCR16lBcKZuITW8ZTm8zeVAzrmzXPaymelLC9dLaWJX8uMOaCs hK7A== X-Gm-Message-State: AOAM533IlqoSqRKn/syQxoIZ/831Wu+/fHfEoSUVZcOmGJJX1a9gTwkD CZVzpE3PhULQb9qBxAl/scw= X-Google-Smtp-Source: ABdhPJxnBevAdWjFPnYT13kO9g6OzXiSBIgK0nm2il49lpkpQ1jQOyNPKGdPDhhnhV0zncnrwIy8vw== X-Received: by 2002:a0c:bd19:: with SMTP id m25mr831736qvg.52.1605203538329; Thu, 12 Nov 2020 09:52:18 -0800 (PST) Received: from ubuntu-m3-large-x86 ([2604:1380:45f1:1d00::1]) by smtp.gmail.com with ESMTPSA id k64sm5255179qkc.97.2020.11.12.09.52.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 09:52:17 -0800 (PST) Date: Thu, 12 Nov 2020 10:52:16 -0700 From: Nathan Chancellor To: Ard Biesheuvel Subject: Re: [PATCH 2/5 v16] ARM: Replace string mem* functions for KASan Message-ID: <20201112175216.GB934563@ubuntu-m3-large-x86> References: <20201106094434.GA3268933@ubuntu-m3-large-x86> <20201106151554.GU1551@shell.armlinux.org.uk> <20201109160643.GY1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201112_125220_260622_C1D88FA3 X-CRM114-Status: GOOD ( 43.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Rothwell , Florian Fainelli , Ahmad Fatoum , Arnd Bergmann , Abbott Liu , Linus Walleij , Russell King - ARM Linux admin , kasan-dev , Mike Rapoport , Linux-Next Mailing List , Alexander Potapenko , Linux ARM , Andrey Ryabinin , Naresh Kamboju , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 12, 2020 at 04:05:52PM +0100, Ard Biesheuvel wrote: > On Thu, 12 Nov 2020 at 14:51, Linus Walleij wrote: > > > > On Tue, Nov 10, 2020 at 1:05 PM Ard Biesheuvel wrote: > > > On Mon, 9 Nov 2020 at 17:07, Russell King - ARM Linux admin > > > wrote: > > > > > > > > On Mon, Nov 09, 2020 at 05:02:09PM +0100, Linus Walleij wrote: > > > > > On Fri, Nov 6, 2020 at 4:16 PM Russell King - ARM Linux admin > > > > > wrote: > > > > > > On Fri, Nov 06, 2020 at 02:37:21PM +0100, Linus Walleij wrote: > > > > > > > > > > > > Aha. So shall we submit this to Russell? I figure that his git will not > > > > > > > build *without* the changes from mmotm? > > > > > > > > > > > > > > That tree isn't using git either is it? > > > > > > > > > > > > > > Is this one of those cases where we should ask Stephen R > > > > > > > to carry this patch on top of -next until the merge window? > > > > > > > > > > > > Another solution would be to drop 9017/2 ("Enable KASan for ARM") > > > > > > until the following merge window, and queue up the non-conflicing > > > > > > ARM KASan fixes in my "misc" branch along with the rest of KASan, > > > > > > and the conflicting patches along with 9017/2 in the following > > > > > > merge window. > > > > > > > > > > > > That means delaying KASan enablement another three months or so, > > > > > > but should result in less headaches about how to avoid build > > > > > > breakage with different bits going through different trees. > > > > > > > > > > > > Comments? > > > > > > > > > > I suppose I would survive deferring it. Or we could merge the > > > > > smaller enablement patch towards the end of the merge > > > > > window once the MM changes are in. > > > > > > > > > > If it is just *one* patch in the MM tree I suppose we could also > > > > > just apply that one patch also to the ARM tree, and then this > > > > > fixup on top. It does look a bit convoluted in the git history with > > > > > two hashes and the same patch twice, but it's what I've done > > > > > at times when there was no other choice that doing that or > > > > > deferring development. It works as long as the patches are > > > > > textually identical: git will cope. > > > > > > > > I thought there was a problem that if I applied the fix then my tree > > > > no longer builds without the changes in -mm? > > > > > > > > > > Indeed. Someone is changing the __alias() wrappers [for no good reason > > > afaict] in a way that does not allow for new users of those wrappers > > > to come in concurrently. > > > > > > Hency my suggestion to switch to the raw __attribute__((alias(".."))) > > > notation for the time being, and switch back to __alias() somewhere > > > after v5.11-rc1. > > > > > > Or we might add this to the file in question > > > > > > #undef __alias > > > #define __alias(symbol) __attribute__((__alias__(symbol))) > > > > > > and switch to the quoted versions of the identifier. Then we can just > > > drop these two lines again later, after v5.11-rc1 > > > > I was under the impression that there was some "post-next" > > trick that mmot apply this patch after -next has been merged > > so it's solved now? > > > > Yes, it appears that [0] has been picked up, I guess we weren't cc'ed > on the version that was sent to akpm [which is fine btw, although a > followup reply here that things are all good now would have been > appreciated] > > > https://lore.kernel.org/linux-arm-kernel/20201109001712.3384097-1-natechancellor@gmail.com/ Hi Ard, Odd, you were on the list of people to receive that patch and you acked it but it seems that Andrew did not CC you when he actually applied the patch: https://lore.kernel.org/mm-commits/20201110212436.yGYhesom8%25akpm@linux-foundation.org/ My apologies for not following up, we appear to be all good now for the time being (aside from the futex issue that I reported earlier). Cheers, Nathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel