From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBA99C2D0E4 for ; Fri, 13 Nov 2020 00:12:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A18820872 for ; Fri, 13 Nov 2020 00:12:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XYFO8VIN"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UMjD5dL2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A18820872 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7rp0yjqtPCnf1wFmISaZ38BpgZ3ZFL+gKUKHi3sJFJM=; b=XYFO8VIN8ncL2TVlWVnwvhD3o ZPwkRW8fwBNnTzvWT3J9Cpzs10977r7dWQFmcdfTWJbqKiFBZO8Fi+lvMsOOh5bvyFCAUzwO34U26 8BcVZXST3gOe02pm48CLa72RZWpxsMSigXIPY74BknTS4gHvo9f2KkW0gTDeYD3snZYamHwEpyBG7 Bs5YfatgtMZrtgV8BufOVFFrPZK5MWyy0EWCq/uo10qmKzeL7v9vnmeZ61sFfuFTTLhH5OctSpyvp oHo0xaslfbtI+WFQoyy7ChWJRvtX8AyZ8e9M9yJULAvsOHg9eJrtGgwDAu2OLqERT3UoDR33JZnO2 p9sZm7fcQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdMgP-0000mn-Oq; Fri, 13 Nov 2020 00:11:17 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdMgM-0000mQ-UX for linux-arm-kernel@lists.infradead.org; Fri, 13 Nov 2020 00:11:16 +0000 Received: by mail-pl1-x643.google.com with SMTP id d3so3656925plo.4 for ; Thu, 12 Nov 2020 16:11:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=RK4vyXnSzDNj6HCSMeHyJb8S3q5pAL7sF5uNlKmM1eg=; b=UMjD5dL2JGpe30/bBx3Frdie5+BRjZBXM+CDYsK+MLnccUSyXhTb8sloXj760Z7dIm 2c9mvhYOpyEQrowgfANyAsJjmmfzIMKuOXBeU3jxcoeLYOWp2Zq19xAWhMfHR+GK2knp o+TbVBKR5c1K+1e5krmbcVz104QSZqrLOYCgR7+WVCmQZeUHWI/oL2fUETGaRaEkjsN0 F35v9vU31Tu1g9yJ4Dc1zYmE8dhHGAG7YfIUZn6QlFKtiguJjZM7ReDpU7tCSNaMyejR bh+suDAAS3X6KszZJ/Q7bIB2e35jz2iJapOFaz4JXFBKePCGVQtkvHVxf+Bul90bV/7V GpsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=RK4vyXnSzDNj6HCSMeHyJb8S3q5pAL7sF5uNlKmM1eg=; b=HOpuWzXjiRd3Myg8wglUocpSmNY/iNXk+6ukwBYJ6fyje65HZVZqlvZiQxVS7dmLOW eL45abU6sWkrdNGsvM5rNiqwDrL43pxBaPCzwGOJ1qO0mzXl2zF1jPgPdaBXVdtzdnko ESSSgvja7g526bzWn4fkasnWQZB5u2Fgk1BgT+WGCzAwNA067rfYeSqMX+FQp/5BVnMu WXMzIgDH4I4LNpQXkrHykg97QnXhe/gWpCqMk00jOKUqiBlbW2UN0AdPVC2JKIFGY8Sj D0LM3BNUXPxDP5W1MfBJ8bnjr1Efjbex9WnSMuDtnHUOrn88AcH99lVSEtbRYjHdyxC+ OOpw== X-Gm-Message-State: AOAM531uRFMeyAgVonRiHJCpI1rUjhI5sd3iwJtOLx+evXk3NnBYaMUy 2Hy5FdHH1EwOKuNwo9Pt19yvWA== X-Google-Smtp-Source: ABdhPJx6t/7v1ApWk0rH8otp47usjz1/ltFJYjzloAqHCZiciz1yvCy53G3siqlBgZG4tdU/PFdpTg== X-Received: by 2002:a17:902:7049:b029:d7:e413:8aba with SMTP id h9-20020a1709027049b02900d7e4138abamr1835028plt.30.1605226269860; Thu, 12 Nov 2020 16:11:09 -0800 (PST) Received: from leoy-ThinkPad-X240s ([103.127.239.100]) by smtp.gmail.com with ESMTPSA id w2sm189761pfb.104.2020.11.12.16.11.07 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 12 Nov 2020 16:11:09 -0800 (PST) Date: Fri, 13 Nov 2020 08:11:05 +0800 From: Leo Yan To: Suzuki K Poulose Subject: Re: [PATCH 3/3] rfc: perf: cs_etm: Detect pid in VMID for kernel running at EL2 Message-ID: <20201113001105.GA22708@leoy-ThinkPad-X240s> References: <20201110183313.1823760-1-suzuki.poulose@arm.com> <20201110183313.1823760-4-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201112_191115_292540_8B12B881 X-CRM114-Status: GOOD ( 17.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Al Grant , "mathieu.poirier@linaro.org" , Anshuman Khandual , "coresight@lists.linaro.org" , "linux-arm-kernel@lists.infradead.org" , "mike.leach@linaro.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 11, 2020 at 11:40:03AM +0000, Suzuki Kuruppassery Poulose wrote: > On 11/11/20 11:03 AM, Al Grant wrote: [...] > > But if you must do it heuristically at decode time based on what > > you see in packets, then it would be safer to say that if you see both > > VMID and CONTEXIDR, the TID will be in VMID. > > This may not be entirely correct, unless we correlate the VMID_OPT. Because, > when we add Virtualization support (vmid == actual vmid). > > So we should do: > if (VMID && VMIDOPT) { > tid = pid; > } else if (CID) { > > } Rather than heuristic method, I think we can use metadata to store "pid" entry in the function cs_etm_get_metadata(), so that in the record phase, the "pid" is stored into perf data file. When decode the trace data, we can retrieve "pid" value from the metadata, and can base on the "pid" value to make decision for using context_id or VMID. The metadata can be accessed by referring cs_etm_queue::cs_etm_auxtrace::metadata; but the file util/cs-etm-decoder/cs-etm-decoder.c cannot directly access the metadata structure due to "cs_etm_queue" and "cs_etm_auxtrace" both are defined in util/cs-etm.c. It's better to introduce a helper function in util/cs-etm.c to retrieve "pid" value, like: u64 cs_etm__etmq_get_pid_type(struct cs_etm_queue *etmq); Thanks, Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel